Re: [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup

[Kevin Hilman <khilman@ti.com>]

Rajendra Nayak <rnayak@ti.com> writes:

> For the I2C module to be wakeup capable, programming I2C_WE
> register (which was skipped for OMAP4430) is needed
> even on OMAP4.
> This fixes i2c controller timeouts which were seen recently
> with the static dependency being cleared between MPU and
> L4PER clockdomains.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> ---
> Patch is based on 2.6.38-rc7 kernel.

Acked-by: Kevin Hilman <khilman@ti.com>

Ben, looks like another fix that should be queued for 2.6.38-rc.

Thanks,

Kevin


>
>  drivers/i2c/busses/i2c-omap.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 829a2a1..58a58c7 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -378,9 +378,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
>  			 * REVISIT: Some wkup sources might not be needed.
>  			 */
>  			dev->westate = OMAP_I2C_WE_ALL;
> -			if (dev->rev < OMAP_I2C_REV_ON_4430)
> -				omap_i2c_write_reg(dev, OMAP_I2C_WE_REG,
> -								dev->westate);
> +			omap_i2c_write_reg(dev, OMAP_I2C_WE_REG, dev->westate);
>  		}
>  	}
>  	omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);