From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: serial module
Date: Sat, 23 Jun 2007 14:32:47 +0200 [thread overview]
Message-ID: <87ejk2onps.fsf@xs4all.nl> (raw)
In-Reply-To: <20070623115827.GA27818@aragorn> (Robert Millan's message of "Sat, 23 Jun 2007 13:58:27 +0200")
Robert Millan <rmh@aybabtu.com> writes:
Hi,
> Any reason why the serial module is not enabled in i386-pc builds? (see
> diff below)
You forgot a changelog entry :-/
> diff -ur grub2-1.95+20070621.old/conf/i386-pc.rmk grub2-1.95+20070621/conf/i386-pc.rmk
> --- grub2-1.95+20070621.old/conf/i386-pc.rmk 2007-06-11 08:26:18.000000000 +0200
> +++ grub2-1.95+20070621/conf/i386-pc.rmk 2007-06-23 13:56:12.000000000 +0200
> @@ -91,7 +91,7 @@
> commands/terminal.c commands/ls.c commands/test.c \
> commands/search.c commands/blocklist.c \
> commands/i386/pc/halt.c commands/i386/pc/reboot.c \
> - commands/i386/cpuid.c \
> + commands/i386/cpuid.c term/i386/pc/serial.c \
Why do you add it to grub-emu? This is wrong because you can't access
the hardware from grub-emu. The same is true for cpuid, I think. Are
you sure it works in grub-emu? Please test if it still builds, when
adding stuff.
> disk/loopback.c disk/raid.c disk/lvm.c \
> fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \
> fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \
> @@ -131,7 +131,7 @@
> pkgdata_MODULES = _chain.mod _linux.mod linux.mod normal.mod \
> _multiboot.mod chain.mod multiboot.mod reboot.mod halt.mod \
> vbe.mod vbetest.mod vbeinfo.mod video.mod gfxterm.mod \
> - videotest.mod play.mod bitmap.mod tga.mod cpuid.mod
> + videotest.mod play.mod bitmap.mod tga.mod cpuid.mod serial.mod
Good catch, I also wonder why this wasn't added. Can you please apply
this change?
--
Marco
next prev parent reply other threads:[~2007-06-23 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-23 11:58 serial module Robert Millan
2007-06-23 12:32 ` Marco Gerards [this message]
2007-06-23 14:46 ` Robert Millan
2007-06-23 15:13 ` Marco Gerards
2007-06-23 17:42 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ejk2onps.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.