Re: serial module

[Marco Gerards <mgerards@xs4all.nl>]

Robert Millan <rmh@aybabtu.com> writes:

> On Sat, Jun 23, 2007 at 02:32:47PM +0200, Marco Gerards wrote:
>> 
>> You forgot a changelog entry :-/
>
> How about..
>
> 	* conf/i386-pc.rmk: (pkgdata_MODULES): Add serial.mod.

Good, except for the first ":".

[...]

>> The same is true for cpuid, I think.  Are
>> you sure it works in grub-emu?
>
> Yes, cpuid should work everywhere as long as your cpu supports it.

Oh, nice :-).  I should try it :-).

>> Please test if it still builds, when
>> adding stuff.
>
> Sure (I even tested that it runs and sets up the serial console correctly).

I meant testing grub-emu.  It is disabled by default, so you might not
notice breaking it, when you do.

>> >  	disk/loopback.c	disk/raid.c disk/lvm.c				\
>> >  	fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c	\
>> >  	fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c	\
>> > @@ -131,7 +131,7 @@
>> >  pkgdata_MODULES = _chain.mod _linux.mod linux.mod normal.mod \
>> >  	_multiboot.mod chain.mod multiboot.mod reboot.mod halt.mod	\
>> >  	vbe.mod vbetest.mod vbeinfo.mod video.mod gfxterm.mod \
>> > -	videotest.mod play.mod bitmap.mod tga.mod cpuid.mod
>> > +	videotest.mod play.mod bitmap.mod tga.mod cpuid.mod serial.mod
>> 
>> Good catch, I also wonder why this wasn't added.  Can you please apply
>> this change?
>
> Done.

Thanks a lot.

--
Marco