From: Marco Gerards <mgerards@xs4all.nl>
To: Johan Rydberg <jrydberg@night.trouble.net>
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: patch for kern/efi/mm.c (big memmap)
Date: Thu, 28 Sep 2006 16:16:48 +0200 [thread overview]
Message-ID: <87ejtw13fz.fsf@xs4all.nl> (raw)
In-Reply-To: <874pus9ihz.fsf@night.trouble.net> (Johan Rydberg's message of "Thu, 28 Sep 2006 16:24:24 +0200")
Johan Rydberg <jrydberg@night.trouble.net> writes:
> Marco Gerards <mgerards@xs4all.nl> writes:
>
>>> + memory_map = grub_efi_allocate_pages
>>> + (0, 2 * BYTES_TO_PAGES (memory_map_size + 0x1000));
>>>
>>> I suppose you add 0x1000 to round it up. Maybe we should change
>>> the BYTES_TO_PAGES macro to do roundup.
>>
>> Agreed. Can you make this change as well?
>
> Done. See attached patch.
Great, I assume you can fixup the changelog entry as well?
> I'll commit it after I get a few minutes over to test it.
Cool.
--
Marco
prev parent reply other threads:[~2006-09-28 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 11:48 patch for kern/efi/mm.c (big memmap) tgingold
2006-09-28 13:00 ` Marco Gerards
2006-09-28 13:04 ` tgingold
2006-09-28 13:41 ` Marco Gerards
2006-09-28 14:01 ` Johan Rydberg
2006-09-28 13:52 ` Marco Gerards
2006-09-28 14:24 ` Johan Rydberg
2006-09-28 14:16 ` Marco Gerards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ejtw13fz.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
--cc=jrydberg@night.trouble.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.