From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: patch for kern/efi/mm.c (big memmap)
Date: Thu, 28 Sep 2006 15:41:56 +0200 [thread overview]
Message-ID: <87r6xw1523.fsf@xs4all.nl> (raw)
In-Reply-To: <1159448688.451bc870e9851@imp1-g19.free.fr> (tgingold@free.fr's message of "Thu, 28 Sep 2006 15:04:48 +0200")
tgingold@free.fr writes:
> This is on an ia64 system (Tiger).
I just noticed that because of your other patches, neat! :-)
>> Cool. Can you please send in this patch in unified diff format (diff
>> -up) and provide a changelog entry? And while you on it, most people
>> here prefer patches being sent inline so it is easier to read and to
>> give feedback on.
> Sorry, this is my first patch!
Hopefully you didn't see my feedback as evil comments ;-). My reason
to tell you all this is to get patches in the form we would like to
see them for easy review and quick integration.
> Tristan.
>
> 2006-09-28 Tristan Gingold <tristan.gingold@bull.net>
>
> * kern/efi/mm.c (grub_efi_mm_init): MEMORY_MAP_SIZE removed,
> dynamically get the size of the memory map.
Great. There are a few changes I will make before committing this
patch. Please have a look at the commit email to see what was changed
and why. I will most likely commit this patch Sunday evening,
certainly not before that, sorry.
--
Marco
next prev parent reply other threads:[~2006-09-28 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 11:48 patch for kern/efi/mm.c (big memmap) tgingold
2006-09-28 13:00 ` Marco Gerards
2006-09-28 13:04 ` tgingold
2006-09-28 13:41 ` Marco Gerards [this message]
2006-09-28 14:01 ` Johan Rydberg
2006-09-28 13:52 ` Marco Gerards
2006-09-28 14:24 ` Johan Rydberg
2006-09-28 14:16 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r6xw1523.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.