* [PATCH 1/2] plugins: Fix resource leak in connect_socket()
@ 2020-10-28 13:45 ` AlexChen
0 siblings, 0 replies; 8+ messages in thread
From: AlexChen @ 2020-10-28 13:45 UTC (permalink / raw)
To: alex.bennee, mjt, Laurent Vivier
Cc: qemu-devel, qemu-trivial, zhang.zhanghailiang, zhengchuan
Close the fd when connect() fails.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
contrib/plugins/lockstep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index a696673dff..319bd44b83 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
perror("failed to connect");
+ close(fd);
return false;
}
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 1/2] plugins: Fix resource leak in connect_socket()
@ 2020-10-28 13:45 ` AlexChen
0 siblings, 0 replies; 8+ messages in thread
From: AlexChen @ 2020-10-28 13:45 UTC (permalink / raw)
To: alex.bennee, mjt, Laurent Vivier
Cc: qemu-trivial, zhengchuan, qemu-devel, zhang.zhanghailiang
Close the fd when connect() fails.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
contrib/plugins/lockstep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index a696673dff..319bd44b83 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
perror("failed to connect");
+ close(fd);
return false;
}
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
2020-10-28 13:45 ` AlexChen
@ 2020-11-05 6:53 ` AlexChen
-1 siblings, 0 replies; 8+ messages in thread
From: AlexChen @ 2020-11-05 6:53 UTC (permalink / raw)
To: alex.bennee, mjt, Laurent Vivier
Cc: qemu-devel, qemu-trivial, zhang.zhanghailiang, zhengchuan
Kindly ping.
On 2020/10/28 21:45, AlexChen wrote:
> Close the fd when connect() fails.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> contrib/plugins/lockstep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index a696673dff..319bd44b83 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>
> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
> perror("failed to connect");
> + close(fd);
> return false;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
@ 2020-11-05 6:53 ` AlexChen
0 siblings, 0 replies; 8+ messages in thread
From: AlexChen @ 2020-11-05 6:53 UTC (permalink / raw)
To: alex.bennee, mjt, Laurent Vivier
Cc: qemu-trivial, zhengchuan, qemu-devel, zhang.zhanghailiang
Kindly ping.
On 2020/10/28 21:45, AlexChen wrote:
> Close the fd when connect() fails.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> contrib/plugins/lockstep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index a696673dff..319bd44b83 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>
> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
> perror("failed to connect");
> + close(fd);
> return false;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
2020-11-05 6:53 ` AlexChen
@ 2020-11-05 10:37 ` Alex Bennée
-1 siblings, 0 replies; 8+ messages in thread
From: Alex Bennée @ 2020-11-05 10:37 UTC (permalink / raw)
To: AlexChen
Cc: mjt, Laurent Vivier, qemu-devel, qemu-trivial,
zhang.zhanghailiang, zhengchuan
AlexChen <alex.chen@huawei.com> writes:
> Kindly ping.
Ahh sorry I missed these. Was there a cover letter for the series?
>
> On 2020/10/28 21:45, AlexChen wrote:
>> Close the fd when connect() fails.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: AlexChen <alex.chen@huawei.com>
>> ---
>> contrib/plugins/lockstep.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
>> index a696673dff..319bd44b83 100644
>> --- a/contrib/plugins/lockstep.c
>> +++ b/contrib/plugins/lockstep.c
>> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>>
>> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
>> perror("failed to connect");
>> + close(fd);
>> return false;
>> }
>>
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
@ 2020-11-05 10:37 ` Alex Bennée
0 siblings, 0 replies; 8+ messages in thread
From: Alex Bennée @ 2020-11-05 10:37 UTC (permalink / raw)
To: AlexChen
Cc: zhang.zhanghailiang, qemu-trivial, mjt, Laurent Vivier,
qemu-devel, zhengchuan
AlexChen <alex.chen@huawei.com> writes:
> Kindly ping.
Ahh sorry I missed these. Was there a cover letter for the series?
>
> On 2020/10/28 21:45, AlexChen wrote:
>> Close the fd when connect() fails.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: AlexChen <alex.chen@huawei.com>
>> ---
>> contrib/plugins/lockstep.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
>> index a696673dff..319bd44b83 100644
>> --- a/contrib/plugins/lockstep.c
>> +++ b/contrib/plugins/lockstep.c
>> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>>
>> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
>> perror("failed to connect");
>> + close(fd);
>> return false;
>> }
>>
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
2020-11-05 10:37 ` Alex Bennée
@ 2020-11-06 1:40 ` AlexChen
-1 siblings, 0 replies; 8+ messages in thread
From: AlexChen @ 2020-11-06 1:40 UTC (permalink / raw)
To: Alex Bennée
Cc: mjt, Laurent Vivier, qemu-devel, qemu-trivial,
zhang.zhanghailiang, zhengchuan
On 2020/11/5 18:37, Alex Bennée wrote:
>
> AlexChen <alex.chen@huawei.com> writes:
>
>> Kindly ping.
>
> Ahh sorry I missed these. Was there a cover letter for the series?
>
I forgot to send the cover letter, I will send the patch V2 with the cover letter.
Thanks,
Alex Chen
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-11-06 1:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28 13:45 [PATCH 1/2] plugins: Fix resource leak in connect_socket() AlexChen
2020-10-28 13:45 ` AlexChen
2020-11-05 6:53 ` AlexChen
2020-11-05 6:53 ` AlexChen
2020-11-05 10:37 ` Alex Bennée
2020-11-05 10:37 ` Alex Bennée
2020-11-06 1:40 ` AlexChen
2020-11-06 1:40 ` AlexChen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.