From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 06/15] drm/i915: Check the execlist queue for pending requests before declaring idle
Date: Thu, 20 Jul 2017 15:23:58 +0300 [thread overview]
Message-ID: <87fudr70v5.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20170717091141.23102-6-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Including a check against the execlist queue before calling the engine
> idle and passing hangcheck.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index cba120f3d89d..fbac94557ffa 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1407,6 +1407,10 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine)
> if (port_request(&engine->execlist_port[0]))
> return false;
>
> + /* ELSP is empty, but there are ready requests? */
> + if (READ_ONCE(engine->execlist_first))
> + return false;
> +
> /* Ring stopped? */
> if (!ring_is_idle(engine))
> return false;
> --
> 2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-20 12:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 9:11 [PATCH 01/15] drm/i915: Report execlists irq bit in debugfs Chris Wilson
2017-07-17 9:11 ` [PATCH 02/15] drm/i915: Reset context image on engines after triggering the reset Chris Wilson
2017-07-17 9:11 ` [PATCH 03/15] drm/i915: Serialize per-engine resets against new requests Chris Wilson
2017-07-17 21:58 ` Michel Thierry
2017-07-17 9:11 ` [PATCH 04/15] drm/i915: Flush the execlist ports if idle Chris Wilson
2017-07-20 12:18 ` Mika Kuoppala
2017-07-20 12:28 ` Chris Wilson
2017-07-20 13:12 ` Mika Kuoppala
2017-07-17 9:11 ` [PATCH 05/15] drm/i915: Check execlist/ring status during hangcheck Chris Wilson
2017-07-17 23:11 ` Michel Thierry
2017-07-17 9:11 ` [PATCH 06/15] drm/i915: Check the execlist queue for pending requests before declaring idle Chris Wilson
2017-07-20 12:23 ` Mika Kuoppala [this message]
2017-07-17 9:11 ` [PATCH 07/15] drm/i915: Move idle checks before intel_engine_init_global_seqno() Chris Wilson
2017-07-20 13:16 ` Mika Kuoppala
2017-07-17 9:11 ` [PATCH 08/15] drm/i915: Clear execlist port[] before updating seqno on wedging Chris Wilson
2017-07-20 13:31 ` Mika Kuoppala
2017-07-20 13:54 ` Chris Wilson
2017-07-20 14:14 ` Mika Kuoppala
2017-07-17 9:11 ` [PATCH 09/15] drm/i915: Wake up waiters after setting the WEDGED bit Chris Wilson
2017-07-20 13:48 ` Mika Kuoppala
2017-07-17 9:11 ` [PATCH 10/15] drm/i915: Assert that machine is wedged for nop_submit_request Chris Wilson
2017-07-18 0:15 ` Michel Thierry
2017-07-20 12:51 ` Chris Wilson
2017-07-20 17:10 ` Michel Thierry
2017-07-17 9:11 ` [PATCH 11/15] drm/i915: Clear engine irq posted following a reset Chris Wilson
2017-07-17 22:05 ` Michel Thierry
2017-07-17 9:11 ` [PATCH 12/15] drm/i915: Make i915_gem_context_mark_guilty() safe for unlocked updates Chris Wilson
2017-07-17 9:11 ` [PATCH 13/15] drm/i915: Emit a user level message when resetting the GPU (or engine) Chris Wilson
2017-07-18 0:22 ` Michel Thierry
2017-07-20 12:52 ` Chris Wilson
2017-07-17 9:11 ` [PATCH 14/15] drm/i915: Disable per-engine reset for Broxton Chris Wilson
2017-07-17 23:57 ` Michel Thierry
2017-07-17 9:11 ` [PATCH 15/15] drm/i915/selftests: Exercise independence of per-engine resets Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fudr70v5.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.