All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 08/15] drm/i915: Clear execlist port[] before updating seqno on wedging
Date: Thu, 20 Jul 2017 17:14:24 +0300	[thread overview]
Message-ID: <87tw275h6n.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <150055885940.7317.1601434056130571549@mail.alporthouse.com>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2017-07-20 14:31:31)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>> 
>> > When we wedge the device, we clear out the in-flight requests and
>> > advance the breadcrumb to indicate they are complete. However, the
>> > breadcrumb advance includes an assert that the engine is idle, so that
>> > advancement needs to be the last step to ensure we pass our own sanity
>> > checks.
>> 
>> I am confused about this one. The previous patch seems to make
>> the concern void.
>
> Yeah, I moved the assert around, but still felt the order imposed by
> the memory of that assert was better.

Agreet that the ordering is better.

If you swap these two patches around, you dont have to change the commit
msg. Otherwise change false notion that there is assert in this path.

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-07-20 14:15 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17  9:11 [PATCH 01/15] drm/i915: Report execlists irq bit in debugfs Chris Wilson
2017-07-17  9:11 ` [PATCH 02/15] drm/i915: Reset context image on engines after triggering the reset Chris Wilson
2017-07-17  9:11 ` [PATCH 03/15] drm/i915: Serialize per-engine resets against new requests Chris Wilson
2017-07-17 21:58   ` Michel Thierry
2017-07-17  9:11 ` [PATCH 04/15] drm/i915: Flush the execlist ports if idle Chris Wilson
2017-07-20 12:18   ` Mika Kuoppala
2017-07-20 12:28     ` Chris Wilson
2017-07-20 13:12   ` Mika Kuoppala
2017-07-17  9:11 ` [PATCH 05/15] drm/i915: Check execlist/ring status during hangcheck Chris Wilson
2017-07-17 23:11   ` Michel Thierry
2017-07-17  9:11 ` [PATCH 06/15] drm/i915: Check the execlist queue for pending requests before declaring idle Chris Wilson
2017-07-20 12:23   ` Mika Kuoppala
2017-07-17  9:11 ` [PATCH 07/15] drm/i915: Move idle checks before intel_engine_init_global_seqno() Chris Wilson
2017-07-20 13:16   ` Mika Kuoppala
2017-07-17  9:11 ` [PATCH 08/15] drm/i915: Clear execlist port[] before updating seqno on wedging Chris Wilson
2017-07-20 13:31   ` Mika Kuoppala
2017-07-20 13:54     ` Chris Wilson
2017-07-20 14:14       ` Mika Kuoppala [this message]
2017-07-17  9:11 ` [PATCH 09/15] drm/i915: Wake up waiters after setting the WEDGED bit Chris Wilson
2017-07-20 13:48   ` Mika Kuoppala
2017-07-17  9:11 ` [PATCH 10/15] drm/i915: Assert that machine is wedged for nop_submit_request Chris Wilson
2017-07-18  0:15   ` Michel Thierry
2017-07-20 12:51     ` Chris Wilson
2017-07-20 17:10       ` Michel Thierry
2017-07-17  9:11 ` [PATCH 11/15] drm/i915: Clear engine irq posted following a reset Chris Wilson
2017-07-17 22:05   ` Michel Thierry
2017-07-17  9:11 ` [PATCH 12/15] drm/i915: Make i915_gem_context_mark_guilty() safe for unlocked updates Chris Wilson
2017-07-17  9:11 ` [PATCH 13/15] drm/i915: Emit a user level message when resetting the GPU (or engine) Chris Wilson
2017-07-18  0:22   ` Michel Thierry
2017-07-20 12:52     ` Chris Wilson
2017-07-17  9:11 ` [PATCH 14/15] drm/i915: Disable per-engine reset for Broxton Chris Wilson
2017-07-17 23:57   ` Michel Thierry
2017-07-17  9:11 ` [PATCH 15/15] drm/i915/selftests: Exercise independence of per-engine resets Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw275h6n.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.