All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org,
	Michal Kazior <michal.kazior@tieto.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: fix wmi service bitmap debug
Date: Sat, 2 Aug 2014 11:02:08 +0300	[thread overview]
Message-ID: <87fvhf5ngf.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1406962776.1835.3.camel@joe-AO725> (Joe Perches's message of "Fri, 1 Aug 2014 23:59:36 -0700")

Joe Perches <joe@perches.com> writes:

>> This introduces a new checkpatch warning:
>> 
>> drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that ':' (ctx:VxE)
>> 
>> But I think that's just a false warning and I should ignore it. Any
>> other ideas?
>
> I don't get a warning with this patch.
>
> What's the last git commit id of the checkpatch version
> you used?

I was using a pretty old version of checkpatch (I have a local copy of
it) but now I updated it to commit ae3ccc4678. I still see the warning
plus a new fallthrough warning (see below).

> $ ./scripts/checkpatch.pl --strict ath10k.diff  
> total: 0 errors, 0 warnings, 0 checks, 471 lines checked

With that command line I don't see it either. But normally I use -f and
that's when I see it:

$ scripts/checkpatch.pl --strict --ignore NETWORKING_BLOCK_COMMENT_STYLE,PARENTHESIS_ALIGNMENT -f drivers/net/wireless/ath/ath10k/wmi.h
ERROR: spaces required around that ':' (ctx:VxE)
#214: FILE: drivers/net/wireless/ath/ath10k/wmi.h:214:
+       default:
               ^

WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#214: FILE: drivers/net/wireless/ath/ath10k/wmi.h:214:
+       default:

total: 1 errors, 1 warnings, 0 checks, 4803 lines checked

NOTE: Ignored message types: NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT

drivers/net/wireless/ath/ath10k/wmi.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
	<ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix wmi service bitmap debug
Date: Sat, 2 Aug 2014 11:02:08 +0300	[thread overview]
Message-ID: <87fvhf5ngf.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1406962776.1835.3.camel@joe-AO725> (Joe Perches's message of "Fri, 1 Aug 2014 23:59:36 -0700")

Joe Perches <joe@perches.com> writes:

>> This introduces a new checkpatch warning:
>> 
>> drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that ':' (ctx:VxE)
>> 
>> But I think that's just a false warning and I should ignore it. Any
>> other ideas?
>
> I don't get a warning with this patch.
>
> What's the last git commit id of the checkpatch version
> you used?

I was using a pretty old version of checkpatch (I have a local copy of
it) but now I updated it to commit ae3ccc4678. I still see the warning
plus a new fallthrough warning (see below).

> $ ./scripts/checkpatch.pl --strict ath10k.diff  
> total: 0 errors, 0 warnings, 0 checks, 471 lines checked

With that command line I don't see it either. But normally I use -f and
that's when I see it:

$ scripts/checkpatch.pl --strict --ignore NETWORKING_BLOCK_COMMENT_STYLE,PARENTHESIS_ALIGNMENT -f drivers/net/wireless/ath/ath10k/wmi.h
ERROR: spaces required around that ':' (ctx:VxE)
#214: FILE: drivers/net/wireless/ath/ath10k/wmi.h:214:
+       default:
               ^

WARNING: Possible switch case/default not preceeded by break or fallthrough comment
#214: FILE: drivers/net/wireless/ath/ath10k/wmi.h:214:
+       default:

total: 1 errors, 1 warnings, 0 checks, 4803 lines checked

NOTE: Ignored message types: NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT

drivers/net/wireless/ath/ath10k/wmi.h has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

-- 
Kalle Valo

  reply	other threads:[~2014-08-02  8:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 10:03 [PATCH] ath10k: fix wmi service bitmap debug Michal Kazior
2014-07-29 10:03 ` Michal Kazior
2014-08-02  6:39 ` Kalle Valo
2014-08-02  6:39   ` Kalle Valo
2014-08-02  6:59   ` Joe Perches
2014-08-02  6:59     ` Joe Perches
2014-08-02  8:02     ` Kalle Valo [this message]
2014-08-02  8:02       ` Kalle Valo
2014-08-08 10:11 ` Kalle Valo
2014-08-08 10:11   ` Kalle Valo
2014-08-08 10:24   ` Michal Kazior
2014-08-08 10:24     ` Michal Kazior
2014-08-08 11:13     ` Kalle Valo
2014-08-08 11:13       ` Kalle Valo
2014-08-12  7:44 ` Kalle Valo
2014-08-12  7:44   ` Kalle Valo
2014-08-19  7:46   ` Michal Kazior
2014-08-19  7:46     ` Michal Kazior
2014-08-19  9:49     ` Kalle Valo
2014-08-19  9:49       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvhf5ngf.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=joe@perches.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.