All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Joe Perches <joe@perches.com>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: fix wmi service bitmap debug
Date: Sat, 2 Aug 2014 09:39:33 +0300	[thread overview]
Message-ID: <87k36r5ra2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1406628239-31322-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 29 Jul 2014 12:03:59 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> The 10.x and main firmware branches have
> conflicting WMI service bitmap definitions.
>
> This also fixes WMI services parsing on big-endian
> hosts and changes debugfs output to be more human
> friendly.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> +	SVCSTR(WMI_SERVICE_TX_ENCAP)
> +	SVCSTR(WMI_SERVICE_BURST)
> +	SVCSTR(WMI_SERVICE_SMART_ANTENNA_SW_SUPPORT)
> +	SVCSTR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT)
>  	default:
> -		return "UNKNOWN SERVICE\n";
> +		return NULL;

This introduces a new checkpatch warning:

drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that ':' (ctx:VxE)

But I think that's just a false warning and I should ignore it. Any
other ideas?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	"Joe Perches" <joe@perches.com>
Subject: Re: [PATCH] ath10k: fix wmi service bitmap debug
Date: Sat, 2 Aug 2014 09:39:33 +0300	[thread overview]
Message-ID: <87k36r5ra2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1406628239-31322-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 29 Jul 2014 12:03:59 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> The 10.x and main firmware branches have
> conflicting WMI service bitmap definitions.
>
> This also fixes WMI services parsing on big-endian
> hosts and changes debugfs output to be more human
> friendly.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> +	SVCSTR(WMI_SERVICE_TX_ENCAP)
> +	SVCSTR(WMI_SERVICE_BURST)
> +	SVCSTR(WMI_SERVICE_SMART_ANTENNA_SW_SUPPORT)
> +	SVCSTR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT)
>  	default:
> -		return "UNKNOWN SERVICE\n";
> +		return NULL;

This introduces a new checkpatch warning:

drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that ':' (ctx:VxE)

But I think that's just a false warning and I should ignore it. Any
other ideas?

-- 
Kalle Valo

  reply	other threads:[~2014-08-02  6:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 10:03 [PATCH] ath10k: fix wmi service bitmap debug Michal Kazior
2014-07-29 10:03 ` Michal Kazior
2014-08-02  6:39 ` Kalle Valo [this message]
2014-08-02  6:39   ` Kalle Valo
2014-08-02  6:59   ` Joe Perches
2014-08-02  6:59     ` Joe Perches
2014-08-02  8:02     ` Kalle Valo
2014-08-02  8:02       ` Kalle Valo
2014-08-08 10:11 ` Kalle Valo
2014-08-08 10:11   ` Kalle Valo
2014-08-08 10:24   ` Michal Kazior
2014-08-08 10:24     ` Michal Kazior
2014-08-08 11:13     ` Kalle Valo
2014-08-08 11:13       ` Kalle Valo
2014-08-12  7:44 ` Kalle Valo
2014-08-12  7:44   ` Kalle Valo
2014-08-19  7:46   ` Michal Kazior
2014-08-19  7:46     ` Michal Kazior
2014-08-19  9:49     ` Kalle Valo
2014-08-19  9:49       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k36r5ra2.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=joe@perches.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.