From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: iterate return values
Date: Fri, 04 Feb 2005 21:21:41 +0000 [thread overview]
Message-ID: <87fz0c3tsq.fsf@marco.marco-g.com> (raw)
In-Reply-To: <200502042143.27144.okuji@enbug.org> (Yoshinori K. Okuji's message of "Fri, 4 Feb 2005 21:43:26 +0100")
"Yoshinori K. Okuji" <okuji@enbug.org> writes:
> On Friday 04 February 2005 21:04, Marco Gerards wrote:
>> The changelog is fine for me, but please don't send it in as a patch.
>
> For me, it is fine to include ChangeLog entries in a patch. What is
> wrong?
When you apply the patch it can not be applied when the changelog was
changed by another commit.
>> This looks like a tab, please don't use tabs. I hope you can fix it
>> if that is the case and the same for the rest of the patch, if the
>> same happened there.
>
> Hmmh, I think I use tabs, too. Should I stop using tabs inside GRUB? In
> the past, tabs were prefered, because using only spaces enlarged the
> source code and the network bandwidth was extremely narrow. Nowadays,
> these reasons are not effective any longer.
Perhaps I am just confused. I was under the impression the GCS forces
you to use spaces, but I can't find anything about it. And emacs
creates tabs too when indenting. So it seems I was just very wrong.
Sorry for the confusion.
Thanks,
Marco
next prev parent reply other threads:[~2005-02-04 22:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-04 6:11 iterate return values Hollis Blanchard
2005-02-04 8:55 ` Yoshinori K. Okuji
2005-02-04 20:04 ` Marco Gerards
2005-02-04 20:43 ` Yoshinori K. Okuji
2005-02-04 21:21 ` Marco Gerards [this message]
2005-02-04 22:24 ` Yoshinori K. Okuji
-- strict thread matches above, loose matches on Subject: below --
2005-01-23 18:23 Hollis Blanchard
2005-01-23 19:19 ` Yoshinori K. Okuji
2005-01-23 19:53 ` Hollis Blanchard
2005-01-23 20:18 ` Marco Gerards
2005-01-23 20:26 ` Yoshinori K. Okuji
2005-01-22 6:57 Hollis Blanchard
2005-01-22 11:26 ` Yoshinori K. Okuji
2005-01-22 13:01 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fz0c3tsq.fsf@marco.marco-g.com \
--to=metgerards@student.han.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.