Re: iterate return values

[Marco Gerards <metgerards@student.han.nl>]

Hollis Blanchard <hollis@penguinppc.org> writes:

> This one took waaay too long to track down. :( It is very difficult to
> debug when the problem is that grub_errno has a stale value.
>
> This fixes my partition map problems, and has been tested both with
> Apple and DOS partition maps.

That's nice!  There are a few comments.  If you fixed those minor
issues, feel free to commit the patch.

>
> -Hollis
>
> Index: ChangeLog
> ===================================================================
> RCS file: /cvsroot/grub/grub2/ChangeLog,v
> retrieving revision 1.90
> diff -u -p -r1.90 ChangeLog
> --- ChangeLog	1 Feb 2005 21:53:34 -0000	1.90
> +++ ChangeLog	4 Feb 2005 06:34:08 -0000
> @@ -1,3 +1,13 @@
> +2005-02-03  Hollis Blanchard  <hollis@penguinppc.org>

The changelog is fine for me, but please don't send it in as a patch.

> -  
> +
>    auto int part_map_probe (const grub_partition_map_t partmap);
> -  
> +

Please watch out for changes like these.

> +      if (err == GRUB_ERR_BAD_PART_TABLE)
> +	{
> +	  /* Continue to next partition map type.  */
> +	  grub_errno = GRUB_ERR_NONE;
> +	  return 0;
> +	}

This looks like a tab, please don't use tabs.  I hope you can fix it
if that is the case and the same for the rest of the patch, if the
same happened there.

Thanks,
Marco