From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH 3/3] target/arm: Set correct fp flags for FLOGB when FPCR.AH = 1
Date: Thu, 21 May 2026 16:03:04 +0100 [thread overview]
Message-ID: <87h5o0olef.fsf@draig.linaro.org> (raw)
In-Reply-To: <20260521122913.1565011-4-peter.maydell@linaro.org> (Peter Maydell's message of "Thu, 21 May 2026 13:29:13 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> Our implementation of the FLOGB insn does the operations entirely
> in the helper function, without needing to use fpu functions.
> This means it needs to handle all the fp status flags itself.
> We aren't setting float_flag_input_denormal_used when we
> use (i.e. do not flush to zero) an input denormal, which means
> that FPCR.IDC isn't set when it should be for FPCR.AH=1.
> We missed this when we added float_flag_input_denormal_used
> and made the fpu/ code set it.
>
> Add the missing float_raise().
>
> Cc: qemu-stable@nongnu.org
> Fixes: d38a57a3f ("target/arm: Enable FEAT_AFP for '-cpu max'")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2026-05-21 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 12:29 [PATCH 0/3] target/arm: Fix some FEAT_AFP corner cases Peter Maydell
2026-05-21 12:29 ` [PATCH 1/3] target/arm: SVE2 FMAXP, FMINP must honour AH=1 Peter Maydell
2026-05-21 14:45 ` Alex Bennée
2026-05-21 12:29 ` [PATCH 2/3] target/arm: Use FPST_A64_F16 for SVE FCVTLT_hs Peter Maydell
2026-05-21 14:55 ` Alex Bennée
2026-05-21 15:21 ` Peter Maydell
2026-05-21 17:50 ` Alex Bennée
2026-05-22 21:52 ` Richard Henderson
2026-05-21 12:29 ` [PATCH 3/3] target/arm: Set correct fp flags for FLOGB when FPCR.AH = 1 Peter Maydell
2026-05-21 15:03 ` Alex Bennée [this message]
2026-05-22 21:54 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5o0olef.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.