From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Deepak Rawat <drawat.floss@gmail.com>,
linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
Gerd Hoffmann <kraxel@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>, Dexuan Cui <decui@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Hu <weh@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device
Date: Wed, 17 Feb 2021 17:21:55 +0100 [thread overview]
Message-ID: <87h7mak6l8.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20aead71c4aa3f640e19660875f807deae92f8d8.camel@gmail.com>
Deepak Rawat <drawat.floss@gmail.com> writes:
> On Wed, 2021-02-17 at 13:07 +0100, Vitaly Kuznetsov wrote:
>> > +++ b/drivers/gpu/drm/hyperv/hyperv_drm.h
>> > @@ -0,0 +1,51 @@
>> > +/* SPDX-License-Identifier: GPL-2.0 */
>> > +/*
>> > + * Copyright 2012-2021 Microsoft
>>
>> Out of pure curiosity, where does '2012' come from or what does it
>> mean?
>>
>
> Thanks Vitaly for the review. Actually some of the code is derived from
> hyperv_fb, which has copyright 2012. Not sure if I should remove here
> or not?
>
I'm definitely not an expert (and couldn't quickly find a good
reference) here but I was under the impression that in such cases you
can just add a note like "based on 'hyperv_fb' driver" (if really
needed, if you just borrow a few things then it's even superfluous I
believe). Anyway, I was just a bit surprised to see '2012' in a new file
:-)
--
Vitaly
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Deepak Rawat <drawat.floss@gmail.com>,
linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Wei Hu <weh@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device
Date: Wed, 17 Feb 2021 17:21:55 +0100 [thread overview]
Message-ID: <87h7mak6l8.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20aead71c4aa3f640e19660875f807deae92f8d8.camel@gmail.com>
Deepak Rawat <drawat.floss@gmail.com> writes:
> On Wed, 2021-02-17 at 13:07 +0100, Vitaly Kuznetsov wrote:
>> > +++ b/drivers/gpu/drm/hyperv/hyperv_drm.h
>> > @@ -0,0 +1,51 @@
>> > +/* SPDX-License-Identifier: GPL-2.0 */
>> > +/*
>> > + * Copyright 2012-2021 Microsoft
>>
>> Out of pure curiosity, where does '2012' come from or what does it
>> mean?
>>
>
> Thanks Vitaly for the review. Actually some of the code is derived from
> hyperv_fb, which has copyright 2012. Not sure if I should remove here
> or not?
>
I'm definitely not an expert (and couldn't quickly find a good
reference) here but I was under the impression that in such cases you
can just add a note like "based on 'hyperv_fb' driver" (if really
needed, if you just borrow a few things then it's even superfluous I
believe). Anyway, I was just a bit surprised to see '2012' in a new file
:-)
--
Vitaly
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-17 16:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 0:39 [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device Deepak Rawat
2021-02-16 0:39 ` Deepak Rawat
2021-02-16 0:39 ` [PATCH v3 2/2] MAINTAINERS: Add maintainer for hyperv " Deepak Rawat
2021-02-16 0:39 ` Deepak Rawat
2021-02-16 8:21 ` [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic " Thomas Zimmermann
2021-02-16 8:21 ` Thomas Zimmermann
2021-02-17 16:01 ` Deepak Rawat
2021-02-17 16:01 ` Deepak Rawat
2021-02-17 12:07 ` Vitaly Kuznetsov
2021-02-17 12:07 ` Vitaly Kuznetsov
2021-02-17 16:08 ` Deepak Rawat
2021-02-17 16:08 ` Deepak Rawat
2021-02-17 16:21 ` Vitaly Kuznetsov [this message]
2021-02-17 16:21 ` Vitaly Kuznetsov
2021-02-18 8:18 ` Thomas Zimmermann
2021-02-18 8:18 ` Thomas Zimmermann
2021-02-17 13:22 ` Simon Ser
2021-02-17 13:22 ` Simon Ser
2021-02-17 16:10 ` Deepak Rawat
2021-02-17 16:10 ` Deepak Rawat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7mak6l8.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=daniel@ffwll.ch \
--cc=decui@microsoft.com \
--cc=drawat.floss@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=haiyangz@microsoft.com \
--cc=kraxel@redhat.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.