All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak Rawat <drawat.floss@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Wei Hu <weh@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Dexuan Cui <decui@microsoft.com>,
	Michael Kelley <mikelley@microsoft.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device
Date: Wed, 17 Feb 2021 08:10:08 -0800	[thread overview]
Message-ID: <68ec72635c83f5e984e19b3227ab2c5d8d2b4892.camel@gmail.com> (raw)
In-Reply-To: <RTH7ReroyaiuwV4na7jvXgaUVHZydoksEf6N1fD_5baGD33auW8TAqtfhOE9WquzDFooXhdGQLZfd5CxgIDRbq7OoM67dtutwHp1SrNRLVA=@emersion.fr>

On Wed, 2021-02-17 at 13:22 +0000, Simon Ser wrote:
> On Tuesday, February 16th, 2021 at 1:39 AM, Deepak Rawat <
> drawat.floss@gmail.com> wrote:
> 
> > +static int hyperv_conn_init(struct hyperv_drm_device *hv)
> > +{
> > +       drm_connector_helper_add(&hv->connector,
> > &hyperv_connector_helper_funcs);
> > +       return drm_connector_init(&hv->dev, &hv->connector,
> > +                                 &hyperv_connector_funcs,
> > +                                 DRM_MODE_CONNECTOR_VGA);
> > +}
> 
> Nit: shouldn't this be DRM_MODE_CONNECTOR_Virtual?

Thanks Simon for the review, I think it make sense to use
DRM_MODE_CONNECTOR_Virtual.




WARNING: multiple messages have this Message-ID (diff)
From: Deepak Rawat <drawat.floss@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: linux-hyperv@vger.kernel.org, Wei Hu <weh@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Dexuan Cui <decui@microsoft.com>,
	dri-devel@lists.freedesktop.org,
	Michael Kelley <mikelley@microsoft.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device
Date: Wed, 17 Feb 2021 08:10:08 -0800	[thread overview]
Message-ID: <68ec72635c83f5e984e19b3227ab2c5d8d2b4892.camel@gmail.com> (raw)
In-Reply-To: <RTH7ReroyaiuwV4na7jvXgaUVHZydoksEf6N1fD_5baGD33auW8TAqtfhOE9WquzDFooXhdGQLZfd5CxgIDRbq7OoM67dtutwHp1SrNRLVA=@emersion.fr>

On Wed, 2021-02-17 at 13:22 +0000, Simon Ser wrote:
> On Tuesday, February 16th, 2021 at 1:39 AM, Deepak Rawat <
> drawat.floss@gmail.com> wrote:
> 
> > +static int hyperv_conn_init(struct hyperv_drm_device *hv)
> > +{
> > +       drm_connector_helper_add(&hv->connector,
> > &hyperv_connector_helper_funcs);
> > +       return drm_connector_init(&hv->dev, &hv->connector,
> > +                                 &hyperv_connector_funcs,
> > +                                 DRM_MODE_CONNECTOR_VGA);
> > +}
> 
> Nit: shouldn't this be DRM_MODE_CONNECTOR_Virtual?

Thanks Simon for the review, I think it make sense to use
DRM_MODE_CONNECTOR_Virtual.



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-02-17 16:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  0:39 [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device Deepak Rawat
2021-02-16  0:39 ` Deepak Rawat
2021-02-16  0:39 ` [PATCH v3 2/2] MAINTAINERS: Add maintainer for hyperv " Deepak Rawat
2021-02-16  0:39   ` Deepak Rawat
2021-02-16  8:21 ` [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic " Thomas Zimmermann
2021-02-16  8:21   ` Thomas Zimmermann
2021-02-17 16:01   ` Deepak Rawat
2021-02-17 16:01     ` Deepak Rawat
2021-02-17 12:07 ` Vitaly Kuznetsov
2021-02-17 12:07   ` Vitaly Kuznetsov
2021-02-17 16:08   ` Deepak Rawat
2021-02-17 16:08     ` Deepak Rawat
2021-02-17 16:21     ` Vitaly Kuznetsov
2021-02-17 16:21       ` Vitaly Kuznetsov
2021-02-18  8:18       ` Thomas Zimmermann
2021-02-18  8:18         ` Thomas Zimmermann
2021-02-17 13:22 ` Simon Ser
2021-02-17 13:22   ` Simon Ser
2021-02-17 16:10   ` Deepak Rawat [this message]
2021-02-17 16:10     ` Deepak Rawat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68ec72635c83f5e984e19b3227ab2c5d8d2b4892.camel@gmail.com \
    --to=drawat.floss@gmail.com \
    --cc=contact@emersion.fr \
    --cc=decui@microsoft.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haiyangz@microsoft.com \
    --cc=kraxel@redhat.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    --cc=weh@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.