From: Jani Nikula <jani.nikula@linux.intel.com>
To: linux-pwm@vger.kernel.org
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org,
"Guru Das Srinagesh" <gurus@codeaurora.org>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH v9 01/11] drm/i915: Use 64-bit division macro
Date: Wed, 18 Mar 2020 21:08:45 +0200 [thread overview]
Message-ID: <87h7yleb0i.fsf@intel.com> (raw)
In-Reply-To: <19661821c8eb32291e72ec091c267f915c365c52.1584473399.git.gurus@codeaurora.org>
On Tue, 17 Mar 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote:
> Since the PWM framework is switching struct pwm_state.duty_cycle's
> datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> to handle a 64-bit dividend.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Also ack for merging this via whichever tree you prefer; please let me
know if you want me to take this via drm-intel.
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index bc14e9c..843cac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1868,7 +1868,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
>
> panel->backlight.min = 0; /* 0% */
> panel->backlight.max = 100; /* 100% */
> - panel->backlight.level = DIV_ROUND_UP(
> + panel->backlight.level = DIV_ROUND_UP_ULL(
> pwm_get_duty_cycle(panel->backlight.pwm) * 100,
> CRC_PMIC_PWM_PERIOD_NS);
> panel->backlight.enabled = panel->backlight.level != 0;
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Guru Das Srinagesh <gurus@codeaurora.org>, linux-pwm@vger.kernel.org
Cc: "Guru Das Srinagesh" <gurus@codeaurora.org>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>
Subject: Re: [PATCH v9 01/11] drm/i915: Use 64-bit division macro
Date: Wed, 18 Mar 2020 21:08:45 +0200 [thread overview]
Message-ID: <87h7yleb0i.fsf@intel.com> (raw)
In-Reply-To: <19661821c8eb32291e72ec091c267f915c365c52.1584473399.git.gurus@codeaurora.org>
On Tue, 17 Mar 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote:
> Since the PWM framework is switching struct pwm_state.duty_cycle's
> datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> to handle a 64-bit dividend.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Also ack for merging this via whichever tree you prefer; please let me
know if you want me to take this via drm-intel.
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index bc14e9c..843cac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1868,7 +1868,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
>
> panel->backlight.min = 0; /* 0% */
> panel->backlight.max = 100; /* 100% */
> - panel->backlight.level = DIV_ROUND_UP(
> + panel->backlight.level = DIV_ROUND_UP_ULL(
> pwm_get_duty_cycle(panel->backlight.pwm) * 100,
> CRC_PMIC_PWM_PERIOD_NS);
> panel->backlight.enabled = panel->backlight.level != 0;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Guru Das Srinagesh <gurus@codeaurora.org>, linux-pwm@vger.kernel.org
Cc: "Guru Das Srinagesh" <gurus@codeaurora.org>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>
Subject: Re: [Intel-gfx] [PATCH v9 01/11] drm/i915: Use 64-bit division macro
Date: Wed, 18 Mar 2020 21:08:45 +0200 [thread overview]
Message-ID: <87h7yleb0i.fsf@intel.com> (raw)
In-Reply-To: <19661821c8eb32291e72ec091c267f915c365c52.1584473399.git.gurus@codeaurora.org>
On Tue, 17 Mar 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote:
> Since the PWM framework is switching struct pwm_state.duty_cycle's
> datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> to handle a 64-bit dividend.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Also ack for merging this via whichever tree you prefer; please let me
know if you want me to take this via drm-intel.
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index bc14e9c..843cac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1868,7 +1868,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
>
> panel->backlight.min = 0; /* 0% */
> panel->backlight.max = 100; /* 100% */
> - panel->backlight.level = DIV_ROUND_UP(
> + panel->backlight.level = DIV_ROUND_UP_ULL(
> pwm_get_duty_cycle(panel->backlight.pwm) * 100,
> CRC_PMIC_PWM_PERIOD_NS);
> panel->backlight.enabled = panel->backlight.level != 0;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Guru Das Srinagesh <gurus@codeaurora.org>, linux-pwm@vger.kernel.org
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org,
"Guru Das Srinagesh" <gurus@codeaurora.org>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH v9 01/11] drm/i915: Use 64-bit division macro
Date: Wed, 18 Mar 2020 21:08:45 +0200 [thread overview]
Message-ID: <87h7yleb0i.fsf@intel.com> (raw)
In-Reply-To: <19661821c8eb32291e72ec091c267f915c365c52.1584473399.git.gurus@codeaurora.org>
On Tue, 17 Mar 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote:
> Since the PWM framework is switching struct pwm_state.duty_cycle's
> datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> to handle a 64-bit dividend.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Also ack for merging this via whichever tree you prefer; please let me
know if you want me to take this via drm-intel.
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index bc14e9c..843cac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1868,7 +1868,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
>
> panel->backlight.min = 0; /* 0% */
> panel->backlight.max = 100; /* 100% */
> - panel->backlight.level = DIV_ROUND_UP(
> + panel->backlight.level = DIV_ROUND_UP_ULL(
> pwm_get_duty_cycle(panel->backlight.pwm) * 100,
> CRC_PMIC_PWM_PERIOD_NS);
> panel->backlight.enabled = panel->backlight.level != 0;
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2020-03-18 19:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 20:05 [PATCH v9 00/11] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-03-17 20:05 ` [Intel-gfx] " Guru Das Srinagesh
2020-03-17 20:05 ` Guru Das Srinagesh
2020-03-17 20:05 ` Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 01/11] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-03-17 20:05 ` [Intel-gfx] " Guru Das Srinagesh
2020-03-17 20:05 ` Guru Das Srinagesh
2020-03-18 19:08 ` Jani Nikula [this message]
2020-03-18 19:08 ` Jani Nikula
2020-03-18 19:08 ` [Intel-gfx] " Jani Nikula
2020-03-18 19:08 ` Jani Nikula
2020-03-19 19:35 ` Guru Das Srinagesh
2020-03-19 19:35 ` [Intel-gfx] " Guru Das Srinagesh
2020-03-19 19:35 ` Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 02/11] hwmon: pwm-fan: " Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 03/11] ir-rx51: " Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 04/11] pwm: clps711x: " Guru Das Srinagesh
2020-03-17 22:22 ` Arnd Bergmann
2020-03-17 23:30 ` Guru Das Srinagesh
2020-03-18 9:49 ` Arnd Bergmann
2020-03-18 17:00 ` Guru Das Srinagesh
2020-03-18 19:38 ` Arnd Bergmann
2020-03-19 20:51 ` Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 05/11] pwm: pwm-imx-tpm: " Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 06/11] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 07/11] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-03-17 20:05 ` Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 08/11] pwm: stm32-lp: Use %llu format specifier for period Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 09/11] pwm: sun4i: Use 64-bit division function Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 10/11] backlight: pwm_bl: " Guru Das Srinagesh
2020-03-17 20:05 ` Guru Das Srinagesh
2020-03-17 20:05 ` Guru Das Srinagesh
2020-03-17 20:05 ` [PATCH v9 11/11] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
2020-03-18 18:51 ` kbuild test robot
2020-03-18 18:51 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7yleb0i.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurus@codeaurora.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=uwe@kleine-koenig.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.