All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Gleb Natapov <gleb@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump
Date: Mon, 26 Nov 2012 19:49:39 -0600	[thread overview]
Message-ID: <87haobolvw.fsf@xmission.com> (raw)
In-Reply-To: <50B41849.9040103@cn.fujitsu.com> (Zhang Yanfei's message of "Tue, 27 Nov 2012 09:32:57 +0800")

Zhang Yanfei <zhangyanfei@cn.fujitsu.com> writes:

> So in summary,
>
> 1. a specific callback function instead of a notifier?

Yes.

> 2. Instead of calling vmclear_local_loaded_vmcss, the vmclear operation
>    will just call the vmclear on every vmcss loaded on the cpu?
>
>    like below:
>
>    static void crash_vmclear_local_loaded_vmcss(void)
>    {
>         int cpu = raw_smp_processor_id();
>         struct loaded_vmcs *v, *n;
>
>         if (!crash_local_vmclear_enabled(cpu))
>                 return;
>
>         list_for_each_entry_safe(v, n, &per_cpu(loaded_vmcss_on_cpu, cpu),
>                                  loaded_vmcss_on_cpu_link)
>                 vmcs_clear(v->vmcs);
>    }
>
>    right?

Yeah that looks good.  I would do list_for_each_entry because the list
isn't changing.

Eric

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Gleb Natapov <gleb@redhat.com>,
	"x86\@kernel.org" <x86@kernel.org>,
	"kexec\@lists.infradead.org" <kexec@lists.infradead.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm\@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump
Date: Mon, 26 Nov 2012 19:49:39 -0600	[thread overview]
Message-ID: <87haobolvw.fsf@xmission.com> (raw)
In-Reply-To: <50B41849.9040103@cn.fujitsu.com> (Zhang Yanfei's message of "Tue, 27 Nov 2012 09:32:57 +0800")

Zhang Yanfei <zhangyanfei@cn.fujitsu.com> writes:

> So in summary,
>
> 1. a specific callback function instead of a notifier?

Yes.

> 2. Instead of calling vmclear_local_loaded_vmcss, the vmclear operation
>    will just call the vmclear on every vmcss loaded on the cpu?
>
>    like below:
>
>    static void crash_vmclear_local_loaded_vmcss(void)
>    {
>         int cpu = raw_smp_processor_id();
>         struct loaded_vmcs *v, *n;
>
>         if (!crash_local_vmclear_enabled(cpu))
>                 return;
>
>         list_for_each_entry_safe(v, n, &per_cpu(loaded_vmcss_on_cpu, cpu),
>                                  loaded_vmcss_on_cpu_link)
>                 vmcs_clear(v->vmcs);
>    }
>
>    right?

Yeah that looks good.  I would do list_for_each_entry because the list
isn't changing.

Eric

  reply	other threads:[~2012-11-27  1:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22  8:22 [PATCH v8 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary Zhang Yanfei
2012-11-22  8:22 ` Zhang Yanfei
2012-11-22  8:23 ` [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump Zhang Yanfei
2012-11-22  8:23   ` Zhang Yanfei
2012-11-26 15:08   ` Eric W. Biederman
2012-11-26 15:08     ` Eric W. Biederman
2012-11-26 17:20     ` Gleb Natapov
2012-11-26 17:20       ` Gleb Natapov
2012-11-26 17:20       ` Gleb Natapov
2012-11-26 17:43       ` Eric W. Biederman
2012-11-26 17:43         ` Eric W. Biederman
2012-11-26 17:43         ` Eric W. Biederman
2012-11-26 17:53         ` Gleb Natapov
2012-11-26 17:53           ` Gleb Natapov
2012-11-26 17:53           ` Gleb Natapov
2012-11-26 18:18           ` Eric W. Biederman
2012-11-26 18:18             ` Eric W. Biederman
2012-11-27  1:32             ` Zhang Yanfei
2012-11-27  1:32               ` Zhang Yanfei
2012-11-27  1:49               ` Eric W. Biederman [this message]
2012-11-27  1:49                 ` Eric W. Biederman
2012-11-27  1:53                 ` Zhang Yanfei
2012-11-27  1:53                   ` Zhang Yanfei
2012-11-22  8:25 ` [PATCH v8 2/2] KVM-INTEL: add a notifier and a bitmap to support VMCLEAR in kdump Zhang Yanfei
2012-11-22  8:25   ` Zhang Yanfei
2012-11-25 14:26 ` [PATCH v8 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary Gleb Natapov
2012-11-25 14:26   ` Gleb Natapov
2012-11-26  1:50   ` Zhang Yanfei
2012-11-26  1:50     ` Zhang Yanfei
2012-11-26  1:50     ` Zhang Yanfei
2012-11-26  1:55 ` Zhang Yanfei
2012-11-26  1:55   ` Zhang Yanfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haobolvw.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=gleb@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=x86@kernel.org \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.