From: Kevin Hilman <khilman@ti.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-omap@vger.kernel.org,
Russell King <rmk+kernel@arm.linux.org.uk>,
Felipe Balbi <balbi@ti.com>, Paul Walmsley <paul@pwsan.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] OMAP: omap_device: replace pr_* prints with dev_*
Date: Fri, 22 Jul 2011 12:51:06 -0700 [thread overview]
Message-ID: <87hb6e2ixh.fsf@ti.com> (raw)
In-Reply-To: <CANOLnOOAJMyHUjrf_cM2LVSAs6Zm2bK3RWK73ibNcVg=7vQP4w@mail.gmail.com> (Grazvydas Ignotas's message of "Fri, 22 Jul 2011 16:15:27 +0300")
Grazvydas Ignotas <notasas@gmail.com> writes:
> On Thu, Jul 21, 2011 at 8:39 PM, Kevin Hilman <khilman@ti.com> wrote:
>> if (act_lat > odpl->activate_lat) {
>> odpl->activate_lat_worst = act_lat;
>> if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
>> odpl->activate_lat = act_lat;
>> - pr_warning("omap_device: %s.%d: new worst case "
>> - "activate latency %d: %llu\n",
>> - od->pdev.name, od->pdev.id,
>> - od->pm_lat_level, act_lat);
>> + dev_warn(&od->pdev.dev,
>> + "new worst case activate latency "
>> + "%d: %llu\n",
>> + od->pm_lat_level, act_lat);
>
> I wonder why these have to be warnings, I get quite a lot of them and
> find them rather annoying. Or is my hardware broken or something?
No, your hardware is not broken.
> I know other people are disabling this in their trees too:
> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=145cf9a7d4ba7c260df7071a28ef40c6a481b6df
Patches to change that are welcome on the list.
It's not related to this patch which just changes from pr_warning to
dev_warn, so needs to be done in a separate patch.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: omap_device: replace pr_* prints with dev_*
Date: Fri, 22 Jul 2011 12:51:06 -0700 [thread overview]
Message-ID: <87hb6e2ixh.fsf@ti.com> (raw)
In-Reply-To: <CANOLnOOAJMyHUjrf_cM2LVSAs6Zm2bK3RWK73ibNcVg=7vQP4w@mail.gmail.com> (Grazvydas Ignotas's message of "Fri, 22 Jul 2011 16:15:27 +0300")
Grazvydas Ignotas <notasas@gmail.com> writes:
> On Thu, Jul 21, 2011 at 8:39 PM, Kevin Hilman <khilman@ti.com> wrote:
>> ? ? ? ? ? ? ? ?if (act_lat > odpl->activate_lat) {
>> ? ? ? ? ? ? ? ? ? ? ? ?odpl->activate_lat_worst = act_lat;
>> ? ? ? ? ? ? ? ? ? ? ? ?if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?odpl->activate_lat = act_lat;
>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? pr_warning("omap_device: %s.%d: new worst case "
>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?"activate latency %d: %llu\n",
>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?od->pdev.name, od->pdev.id,
>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?od->pm_lat_level, act_lat);
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? dev_warn(&od->pdev.dev,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?"new worst case activate latency "
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?"%d: %llu\n",
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?od->pm_lat_level, act_lat);
>
> I wonder why these have to be warnings, I get quite a lot of them and
> find them rather annoying. Or is my hardware broken or something?
No, your hardware is not broken.
> I know other people are disabling this in their trees too:
> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=145cf9a7d4ba7c260df7071a28ef40c6a481b6df
Patches to change that are welcome on the list.
It's not related to this patch which just changes from pr_warning to
dev_warn, so needs to be done in a separate patch.
Kevin
next prev parent reply other threads:[~2011-07-22 19:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 17:39 [PATCH] OMAP: omap_device: replace pr_* prints with dev_* Kevin Hilman
2011-07-21 17:39 ` Kevin Hilman
2011-07-21 17:43 ` Felipe Balbi
2011-07-21 17:43 ` Felipe Balbi
2011-07-21 18:52 ` Kevin Hilman
2011-07-21 18:52 ` Kevin Hilman
2011-07-22 13:15 ` Grazvydas Ignotas
2011-07-22 13:15 ` Grazvydas Ignotas
2011-07-22 19:51 ` Kevin Hilman [this message]
2011-07-22 19:51 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb6e2ixh.fsf@ti.com \
--to=khilman@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=paul@pwsan.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.