* [PATCH] qapi: convert intro sections fixup
@ 2026-09-29 22:30 John Snow
2026-09-30 5:39 ` Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: John Snow @ 2026-09-29 22:30 UTC (permalink / raw)
To: qemu-devel
Cc: Markus Armbruster, Eric Blake, Paolo Bonzini,
Daniel P. Berrangé, John Snow
"We" (Me, I, Myself) missed two last spots during bulk conversion of the
intro section syntax.
Some definitions are still intentionally left without an intro
section: BlockdevSnapshotSync is the only case I am presently aware
of.
The remaining two were genuinely just missed; convert them now.
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
qapi/machine-s390x.json | 4 ++--
qapi/qom.json | 14 +++++++-------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/qapi/machine-s390x.json b/qapi/machine-s390x.json
index 8d8cbe2fb75..9ae559bbc2d 100644
--- a/qapi/machine-s390x.json
+++ b/qapi/machine-s390x.json
@@ -150,8 +150,8 @@
##
# @DummyBootCertificates:
-#
-# Not used by QMP; hack to let us use BootCertificatesList internally.
+# Not used by QMP; hack to let us use BootCertificatesList
+# internally.
#
# Since: 11.2
##
diff --git a/qapi/qom.json b/qapi/qom.json
index e03ede34421..2d0d0e47fbb 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -1039,13 +1039,13 @@
##
# @SevSnpGuestProperties:
-#
-# Properties for sev-snp-guest objects. Most of these are direct
-# arguments for the KVM_SNP_* interfaces documented in the Linux
-# kernel source under
-# Documentation/arch/x86/amd-memory-encryption.rst, which are in turn
-# closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware commands
-# documented in the SEV-SNP Firmware ABI Specification (Rev 0.9).
+# Properties for sev-snp-guest objects. Most of these are direct
+# arguments for the KVM_SNP_* interfaces documented in the Linux
+# kernel source under
+# Documentation/arch/x86/amd-memory-encryption.rst, which are in
+# turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
+# commands documented in the SEV-SNP Firmware ABI Specification
+# (Rev 0.9).
#
# More usage information is also available in the QEMU source tree
# under docs/amd-memory-encryption.
--
2.55.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: convert intro sections fixup
2026-09-29 22:30 [PATCH] qapi: convert intro sections fixup John Snow
@ 2026-09-30 5:39 ` Markus Armbruster
2026-09-30 14:07 ` John Snow
2026-10-07 18:54 ` John Snow
0 siblings, 2 replies; 5+ messages in thread
From: Markus Armbruster @ 2026-09-30 5:39 UTC (permalink / raw)
To: John Snow; +Cc: qemu-devel, Eric Blake, Paolo Bonzini, Daniel P. Berrangé
John Snow <jsnow@redhat.com> writes:
> "We" (Me, I, Myself) missed two last spots during bulk conversion of the
> intro section syntax.
>
> Some definitions are still intentionally left without an intro
> section: BlockdevSnapshotSync is the only case I am presently aware
> of.
There are quite a few more, but BlockdevSnapshotSync is the only one
followed by a plain section.
> The remaining two were genuinely just missed; convert them now.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> qapi/machine-s390x.json | 4 ++--
> qapi/qom.json | 14 +++++++-------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/qapi/machine-s390x.json b/qapi/machine-s390x.json
> index 8d8cbe2fb75..9ae559bbc2d 100644
> --- a/qapi/machine-s390x.json
> +++ b/qapi/machine-s390x.json
> @@ -150,8 +150,8 @@
>
> ##
> # @DummyBootCertificates:
> -#
> -# Not used by QMP; hack to let us use BootCertificatesList internally.
> +# Not used by QMP; hack to let us use BootCertificatesList
> +# internally.
> #
> # Since: 11.2
> ##
> diff --git a/qapi/qom.json b/qapi/qom.json
> index e03ede34421..2d0d0e47fbb 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -1039,13 +1039,13 @@
>
> ##
> # @SevSnpGuestProperties:
> -#
> -# Properties for sev-snp-guest objects. Most of these are direct
> -# arguments for the KVM_SNP_* interfaces documented in the Linux
> -# kernel source under
> -# Documentation/arch/x86/amd-memory-encryption.rst, which are in turn
> -# closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware commands
> -# documented in the SEV-SNP Firmware ABI Specification (Rev 0.9).
> +# Properties for sev-snp-guest objects. Most of these are direct
> +# arguments for the KVM_SNP_* interfaces documented in the Linux
> +# kernel source under
> +# Documentation/arch/x86/amd-memory-encryption.rst, which are in
> +# turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
> +# commands documented in the SEV-SNP Firmware ABI Specification
> +# (Rev 0.9).
> #
> # More usage information is also available in the QEMU source tree
> # under docs/amd-memory-encryption.
Hmm, shouldn't we split this one?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: convert intro sections fixup
2026-09-30 5:39 ` Markus Armbruster
@ 2026-09-30 14:07 ` John Snow
2026-10-07 18:54 ` John Snow
1 sibling, 0 replies; 5+ messages in thread
From: John Snow @ 2026-09-30 14:07 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-devel, Eric Blake, Paolo Bonzini, Daniel P. Berrangé
On Wed, Sep 30, 2026 at 1:39 AM Markus Armbruster <armbru@redhat.com> wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
> > "We" (Me, I, Myself) missed two last spots during bulk conversion of the
> > intro section syntax.
> >
> > Some definitions are still intentionally left without an intro
> > section: BlockdevSnapshotSync is the only case I am presently aware
> > of.
>
> There are quite a few more, but BlockdevSnapshotSync is the only one
> followed by a plain section.
>
> > The remaining two were genuinely just missed; convert them now.
> >
> > Reported-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > qapi/machine-s390x.json | 4 ++--
> > qapi/qom.json | 14 +++++++-------
> > 2 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/qapi/machine-s390x.json b/qapi/machine-s390x.json
> > index 8d8cbe2fb75..9ae559bbc2d 100644
> > --- a/qapi/machine-s390x.json
> > +++ b/qapi/machine-s390x.json
> > @@ -150,8 +150,8 @@
> >
> > ##
> > # @DummyBootCertificates:
> > -#
> > -# Not used by QMP; hack to let us use BootCertificatesList internally.
> > +# Not used by QMP; hack to let us use BootCertificatesList
> > +# internally.
> > #
> > # Since: 11.2
> > ##
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index e03ede34421..2d0d0e47fbb 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -1039,13 +1039,13 @@
> >
> > ##
> > # @SevSnpGuestProperties:
> > -#
> > -# Properties for sev-snp-guest objects. Most of these are direct
> > -# arguments for the KVM_SNP_* interfaces documented in the Linux
> > -# kernel source under
> > -# Documentation/arch/x86/amd-memory-encryption.rst, which are in turn
> > -# closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware commands
> > -# documented in the SEV-SNP Firmware ABI Specification (Rev 0.9).
> > +# Properties for sev-snp-guest objects. Most of these are direct
> > +# arguments for the KVM_SNP_* interfaces documented in the Linux
> > +# kernel source under
> > +# Documentation/arch/x86/amd-memory-encryption.rst, which are in
> > +# turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
> > +# commands documented in the SEV-SNP Firmware ABI Specification
> > +# (Rev 0.9).
> > #
> > # More usage information is also available in the QEMU source tree
> > # under docs/amd-memory-encryption.
>
> Hmm, shouldn't we split this one?
With fresh eyes in the morning, yes. I was thinking this was dev info
at the time, but I see now it's *usage* info, so... yes. Hang on.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: convert intro sections fixup
2026-09-30 5:39 ` Markus Armbruster
2026-09-30 14:07 ` John Snow
@ 2026-10-07 18:54 ` John Snow
2026-10-08 4:31 ` Markus Armbruster
1 sibling, 1 reply; 5+ messages in thread
From: John Snow @ 2026-10-07 18:54 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-devel, Eric Blake, Paolo Bonzini, Daniel P. Berrangé
On Wed, Sep 30, 2026 at 1:39 AM Markus Armbruster <armbru@redhat.com> wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
> > "We" (Me, I, Myself) missed two last spots during bulk conversion of the
> > intro section syntax.
> >
> > Some definitions are still intentionally left without an intro
> > section: BlockdevSnapshotSync is the only case I am presently aware
> > of.
>
> There are quite a few more, but BlockdevSnapshotSync is the only one
> followed by a plain section.
>
> > The remaining two were genuinely just missed; convert them now.
> >
> > Reported-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > qapi/machine-s390x.json | 4 ++--
> > qapi/qom.json | 14 +++++++-------
> > 2 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/qapi/machine-s390x.json b/qapi/machine-s390x.json
> > index 8d8cbe2fb75..9ae559bbc2d 100644
> > --- a/qapi/machine-s390x.json
> > +++ b/qapi/machine-s390x.json
> > @@ -150,8 +150,8 @@
> >
> > ##
> > # @DummyBootCertificates:
> > -#
> > -# Not used by QMP; hack to let us use BootCertificatesList internally.
> > +# Not used by QMP; hack to let us use BootCertificatesList
> > +# internally.
> > #
> > # Since: 11.2
> > ##
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index e03ede34421..2d0d0e47fbb 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -1039,13 +1039,13 @@
> >
> > ##
> > # @SevSnpGuestProperties:
> > -#
> > -# Properties for sev-snp-guest objects. Most of these are direct
> > -# arguments for the KVM_SNP_* interfaces documented in the Linux
> > -# kernel source under
> > -# Documentation/arch/x86/amd-memory-encryption.rst, which are in turn
> > -# closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware commands
> > -# documented in the SEV-SNP Firmware ABI Specification (Rev 0.9).
> > +# Properties for sev-snp-guest objects. Most of these are direct
> > +# arguments for the KVM_SNP_* interfaces documented in the Linux
> > +# kernel source under
> > +# Documentation/arch/x86/amd-memory-encryption.rst, which are in
> > +# turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
> > +# commands documented in the SEV-SNP Firmware ABI Specification
> > +# (Rev 0.9).
> > #
> > # More usage information is also available in the QEMU source tree
> > # under docs/amd-memory-encryption.
>
> Hmm, shouldn't we split this one?
Looping back to stuff that got missed:
Split how? I think I have to rephrase this a bit, because when it gets
inlined, it (might) be lacking the context of what specifically it
refers to, i.e. "Most of these" might become ambiguous.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: convert intro sections fixup
2026-10-07 18:54 ` John Snow
@ 2026-10-08 4:31 ` Markus Armbruster
0 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2026-10-08 4:31 UTC (permalink / raw)
To: John Snow; +Cc: qemu-devel, Eric Blake, Paolo Bonzini, Daniel P. Berrangé
John Snow <jsnow@redhat.com> writes:
> On Wed, Sep 30, 2026 at 1:39 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> John Snow <jsnow@redhat.com> writes:
>>
>> > "We" (Me, I, Myself) missed two last spots during bulk conversion of the
>> > intro section syntax.
>> >
>> > Some definitions are still intentionally left without an intro
>> > section: BlockdevSnapshotSync is the only case I am presently aware
>> > of.
>>
>> There are quite a few more, but BlockdevSnapshotSync is the only one
>> followed by a plain section.
>>
>> > The remaining two were genuinely just missed; convert them now.
>> >
>> > Reported-by: Markus Armbruster <armbru@redhat.com>
>> > Signed-off-by: John Snow <jsnow@redhat.com>
>> > ---
>> > qapi/machine-s390x.json | 4 ++--
>> > qapi/qom.json | 14 +++++++-------
>> > 2 files changed, 9 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/qapi/machine-s390x.json b/qapi/machine-s390x.json
>> > index 8d8cbe2fb75..9ae559bbc2d 100644
>> > --- a/qapi/machine-s390x.json
>> > +++ b/qapi/machine-s390x.json
>> > @@ -150,8 +150,8 @@
>> >
>> > ##
>> > # @DummyBootCertificates:
>> > -#
>> > -# Not used by QMP; hack to let us use BootCertificatesList internally.
>> > +# Not used by QMP; hack to let us use BootCertificatesList
>> > +# internally.
>> > #
>> > # Since: 11.2
>> > ##
>> > diff --git a/qapi/qom.json b/qapi/qom.json
>> > index e03ede34421..2d0d0e47fbb 100644
>> > --- a/qapi/qom.json
>> > +++ b/qapi/qom.json
>> > @@ -1039,13 +1039,13 @@
>> >
>> > ##
>> > # @SevSnpGuestProperties:
>> > -#
>> > -# Properties for sev-snp-guest objects. Most of these are direct
>> > -# arguments for the KVM_SNP_* interfaces documented in the Linux
>> > -# kernel source under
>> > -# Documentation/arch/x86/amd-memory-encryption.rst, which are in turn
>> > -# closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware commands
>> > -# documented in the SEV-SNP Firmware ABI Specification (Rev 0.9).
>> > +# Properties for sev-snp-guest objects. Most of these are direct
>> > +# arguments for the KVM_SNP_* interfaces documented in the Linux
>> > +# kernel source under
>> > +# Documentation/arch/x86/amd-memory-encryption.rst, which are in
>> > +# turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
>> > +# commands documented in the SEV-SNP Firmware ABI Specification
>> > +# (Rev 0.9).
>> > #
>> > # More usage information is also available in the QEMU source tree
>> > # under docs/amd-memory-encryption.
>>
>> Hmm, shouldn't we split this one?
>
> Looping back to stuff that got missed:
>
> Split how? I think I have to rephrase this a bit, because when it gets
> inlined, it (might) be lacking the context of what specifically it
> refers to, i.e. "Most of these" might become ambiguous.
Yes.
Could s/these/the properties/ suffice for now?
##
# @SevSnpGuestProperties:
# Properties for sev-snp-guest objects.
#
# Most of the properties are direct arguments for the KVM_SNP_*
# interfaces documented in the Linux kernel source under
# Documentation/arch/x86/amd-memory-encryption.rst, which are in
# turn closely coupled with the SNP_INIT/SNP_LAUNCH_* firmware
# commands documented in the SEV-SNP Firmware ABI Specification
# (Rev 0.9).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-10-08 4:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-29 22:30 [PATCH] qapi: convert intro sections fixup John Snow
2026-09-30 5:39 ` Markus Armbruster
2026-09-30 14:07 ` John Snow
2026-10-07 18:54 ` John Snow
2026-10-08 4:31 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.