Re: [Intel-gfx] [PATCH 0/5] s/ADL/ALDERLAKE

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 30 May 2023, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> Replace all occurences of ADL -> ALDERLAKE in
> platform and subplatform defines. This way there is a
> consistent pattern to how platforms are referred. While
> the change is minor and could be combined to have lesser patches,
> splitting to per subpaltform for easier cherrypicks, if needed.

Cc: Joonas, Tvrtko

Commented on a couple of patches.

I'm not necessarily opposed to switching from acronyms to full names,
but this series alone does not improve consistency. Quite the opposite
actually.

It's a lot of churn to rename everything. Do we really want that?


BR,
Jani.


>
> Anusha Srivatsa (5):
>   drm/i915/adlp: s/ADLP/ALDERLAKE_P for display and graphics step
>   drm/i915/rplp: s/ADLP/ALDERLAKE_P for RPLP defines
>   drm/i915/rplu: s/ADLP/ALDERLAKE_P in RPLU defines
>   drm/i915/adln: s/ADLP/ALDERLAKE_P in ADLN defines
>   drm/i915/adls: s/ADLS/ALDERLAKE_S in platform and subplatform  defines
>
>  drivers/gpu/drm/i915/display/intel_cdclk.c       |  4 ++--
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c    |  2 +-
>  drivers/gpu/drm/i915/display/intel_psr.c         |  8 ++++----
>  .../gpu/drm/i915/display/skl_universal_plane.c   |  4 ++--
>  drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c  |  2 +-
>  drivers/gpu/drm/i915/gt/uc/intel_uc.c            |  2 +-
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c         |  2 +-
>  drivers/gpu/drm/i915/i915_drv.h                  | 16 ++++++++--------
>  drivers/gpu/drm/i915/intel_device_info.c         |  2 +-
>  drivers/gpu/drm/i915/intel_step.c                |  6 +++---
>  10 files changed, 24 insertions(+), 24 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center