From: Markus Armbruster <armbru@redhat.com>
To: Han Han <hhan@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
laurent@vivier.eu, dgilbert@redhat.com
Subject: Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
Date: Wed, 04 Dec 2019 13:16:08 +0100 [thread overview]
Message-ID: <87immwb81j.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20191204085628.2892-1-hhan@redhat.com> (Han Han's message of "Wed, 4 Dec 2019 16:56:28 +0800")
Han Han <hhan@redhat.com> writes:
> This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
>
> In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> accordingly.
> ---
> qemu-options.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 65c9473b73..e14d88e9b2 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
> the recommended is 320x240, 640x480, 800x640.
>
> A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
> -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> -guest will not reboot by default. Currently Seabios for X86
> +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
> +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
> system support it.
>
> Do strict boot via @option{strict=on} as far as firmware/BIOS
Reviewed-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Han Han <hhan@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
dgilbert@redhat.com, laurent@vivier.eu
Subject: Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
Date: Wed, 04 Dec 2019 13:16:08 +0100 [thread overview]
Message-ID: <87immwb81j.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20191204085628.2892-1-hhan@redhat.com> (Han Han's message of "Wed, 4 Dec 2019 16:56:28 +0800")
Han Han <hhan@redhat.com> writes:
> This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
>
> In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> accordingly.
> ---
> qemu-options.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 65c9473b73..e14d88e9b2 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
> the recommended is 320x240, 640x480, 800x640.
>
> A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
> -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> -guest will not reboot by default. Currently Seabios for X86
> +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
> +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
> system support it.
>
> Do strict boot via @option{strict=on} as far as firmware/BIOS
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2019-12-04 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 8:56 [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
2019-12-04 8:56 ` Han Han
2019-12-04 11:53 ` no-reply
2019-12-04 11:53 ` no-reply
2019-12-04 12:16 ` Markus Armbruster [this message]
2019-12-04 12:16 ` Markus Armbruster
2019-12-04 12:21 ` Dr. David Alan Gilbert
2019-12-04 12:21 ` Dr. David Alan Gilbert
2019-12-05 2:49 ` Han Han
2019-12-05 2:49 ` Han Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87immwb81j.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=hhan@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.