All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
Date: Tue, 24 Apr 2018 18:11:47 +0300	[thread overview]
Message-ID: <87in8gvdu4.fsf@intel.com> (raw)
In-Reply-To: <20180424131500.2110-1-luc.vanoostenryck@gmail.com>

On Tue, 24 Apr 2018, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote:
> All implementations of the method intel_dvo_dev_ops::mode_valid(), as
> well as the underlying struct drm_connector_helper_funcs::mode_valid()
> use 'enum drm_mode_status' for the method's return type but the
> declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' for the declaration too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>  drivers/gpu/drm/i915/dvo.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
> index 5e6a3013d..b6e143ebc 100644
> --- a/drivers/gpu/drm/i915/dvo.h
> +++ b/drivers/gpu/drm/i915/dvo.h
> @@ -74,7 +74,7 @@ struct intel_dvo_dev_ops {
>  	 *
>  	 * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
>  	 */
> -	int (*mode_valid)(struct intel_dvo_device *dvo,
> +	enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
>  			  struct drm_display_mode *mode);

Please adjust the alignment here as well. With that,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Oh, and as far as lists go, intel-gfx is sufficient.


>  
>  	/*

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	linux-kernel@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
Date: Tue, 24 Apr 2018 18:11:47 +0300	[thread overview]
Message-ID: <87in8gvdu4.fsf@intel.com> (raw)
In-Reply-To: <20180424131500.2110-1-luc.vanoostenryck@gmail.com>

On Tue, 24 Apr 2018, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote:
> All implementations of the method intel_dvo_dev_ops::mode_valid(), as
> well as the underlying struct drm_connector_helper_funcs::mode_valid()
> use 'enum drm_mode_status' for the method's return type but the
> declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' for the declaration too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>  drivers/gpu/drm/i915/dvo.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
> index 5e6a3013d..b6e143ebc 100644
> --- a/drivers/gpu/drm/i915/dvo.h
> +++ b/drivers/gpu/drm/i915/dvo.h
> @@ -74,7 +74,7 @@ struct intel_dvo_dev_ops {
>  	 *
>  	 * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
>  	 */
> -	int (*mode_valid)(struct intel_dvo_device *dvo,
> +	enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
>  			  struct drm_display_mode *mode);

Please adjust the alignment here as well. With that,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Oh, and as far as lists go, intel-gfx is sufficient.


>  
>  	/*

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2018-04-24 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
2018-04-24 15:11 ` Jani Nikula [this message]
2018-04-24 15:11   ` Jani Nikula
2018-04-24 15:50 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-04-24 16:05 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-24 20:08 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in8gvdu4.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.