All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	Kees Cook <keescook@chromium.org>, Greg KH <greg@kroah.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Peter Jones <pjones@redhat.com>, Torsten Duwe <duwe@lst.de>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec
Date: Fri, 20 Dec 2013 17:32:46 -0800	[thread overview]
Message-ID: <87ioujf0ox.fsf@xmission.com> (raw)
In-Reply-To: <52B4D0C6.2000505@zytor.com> (H. Peter Anvin's message of "Fri, 20 Dec 2013 15:20:38 -0800")

"H. Peter Anvin" <hpa@zytor.com> writes:

> On 12/20/2013 03:11 PM, Eric W. Biederman wrote:
>> 
>> In that case the chrome folks would simply have to use an ELF format
>> kernel and not a bzImage.
>> 
>
> This is starting to feel like everything is going in the direction of a
> massive feature regression.  bzImage may be weird (it has definitely
> grown organically), but the features that have been added to it have
> generally been for a reason, e.g. kernel relocation and so on.

Stuff and nonsense.  bzImage is just an ugly wrapper around an ELF
image.

I am just arguing that we expose the clean portable underpinnings and
make that work.

It absolutely does not make sense to make a solution that only works for
x86.  ELF is what ever other architecture uses so we absolutely have to
make any feature we build work with ELF.

At a very basic level for this feature ELF is good enough.  bzImage
isn't.

Given that in the worst case distro's will have to package a second
binary of the same kernel in their kernel rpm.  I don't know that there
is any point in supporting anything else except ELF in the kernel.
Given that the package and distribution are going to have to change
anyway to include signing a change in file format hardly seems scary.

But my point above was really that ELF is sufficient for the use case of
doing file based verification base on fd's in addition to the use case
of using detached signatures.  Which is really a long winded way of
saying the argument "But but but my distro only ships a bzImage today"
is a horrible techinical argument.

I am not fundamentally opposed to supporting other file formats but
given that ELF wins on both practical and techincal grounds ELF should
be the primary file format for kexec_file_load.  We can worry about
other file formats once ELF is shown to work.

Eric

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Vivek Goyal <vgoyal@redhat.com>, Torsten Duwe <duwe@lst.de>,
	Matthew Garrett <mjg59@srcf.ucam.org>, Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	Peter Jones <pjones@redhat.com>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec
Date: Fri, 20 Dec 2013 17:32:46 -0800	[thread overview]
Message-ID: <87ioujf0ox.fsf@xmission.com> (raw)
In-Reply-To: <52B4D0C6.2000505@zytor.com> (H. Peter Anvin's message of "Fri, 20 Dec 2013 15:20:38 -0800")

"H. Peter Anvin" <hpa@zytor.com> writes:

> On 12/20/2013 03:11 PM, Eric W. Biederman wrote:
>> 
>> In that case the chrome folks would simply have to use an ELF format
>> kernel and not a bzImage.
>> 
>
> This is starting to feel like everything is going in the direction of a
> massive feature regression.  bzImage may be weird (it has definitely
> grown organically), but the features that have been added to it have
> generally been for a reason, e.g. kernel relocation and so on.

Stuff and nonsense.  bzImage is just an ugly wrapper around an ELF
image.

I am just arguing that we expose the clean portable underpinnings and
make that work.

It absolutely does not make sense to make a solution that only works for
x86.  ELF is what ever other architecture uses so we absolutely have to
make any feature we build work with ELF.

At a very basic level for this feature ELF is good enough.  bzImage
isn't.

Given that in the worst case distro's will have to package a second
binary of the same kernel in their kernel rpm.  I don't know that there
is any point in supporting anything else except ELF in the kernel.
Given that the package and distribution are going to have to change
anyway to include signing a change in file format hardly seems scary.

But my point above was really that ELF is sufficient for the use case of
doing file based verification base on fd's in addition to the use case
of using detached signatures.  Which is really a long winded way of
saying the argument "But but but my distro only ships a bzImage today"
is a horrible techinical argument.

I am not fundamentally opposed to supporting other file formats but
given that ELF wins on both practical and techincal grounds ELF should
be the primary file format for kexec_file_load.  We can worry about
other file formats once ELF is shown to work.

Eric

  reply	other threads:[~2013-12-21  1:33 UTC|newest]

Thread overview: 180+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 17:50 [PATCH 0/6] kexec: A new system call to allow in kernel loading Vivek Goyal
2013-11-20 17:50 ` Vivek Goyal
2013-11-20 17:50 ` [PATCH 1/6] kexec: Export vmcoreinfo note size properly Vivek Goyal
2013-11-20 17:50   ` Vivek Goyal
2013-11-21 18:59   ` Greg KH
2013-11-21 18:59     ` Greg KH
2013-11-21 19:08     ` Vivek Goyal
2013-11-21 19:08       ` Vivek Goyal
2013-11-20 17:50 ` [PATCH 2/6] kexec: Move segment verification code in a separate function Vivek Goyal
2013-11-20 17:50   ` Vivek Goyal
2013-11-20 17:50 ` [PATCH 3/6] resource: Provide new functions to walk through resources Vivek Goyal
2013-11-20 17:50   ` Vivek Goyal
2013-11-20 17:50 ` [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec Vivek Goyal
2013-11-20 17:50   ` Vivek Goyal
2013-11-21 19:03   ` Greg KH
2013-11-21 19:03     ` Greg KH
2013-11-21 19:06     ` Matthew Garrett
2013-11-21 19:06       ` Matthew Garrett
2013-11-21 19:13       ` Vivek Goyal
2013-11-21 19:13         ` Vivek Goyal
2013-11-21 19:19         ` Matthew Garrett
2013-11-21 19:19           ` Matthew Garrett
2013-11-21 19:24           ` Vivek Goyal
2013-11-21 19:24             ` Vivek Goyal
2013-11-22 18:57           ` Vivek Goyal
2013-11-22 18:57             ` Vivek Goyal
2013-11-23  3:39             ` Eric W. Biederman
2013-11-23  3:39               ` Eric W. Biederman
2013-11-25 16:39               ` Vivek Goyal
2013-11-25 16:39                 ` Vivek Goyal
2013-11-26 12:23                 ` Eric W. Biederman
2013-11-26 12:23                   ` Eric W. Biederman
2013-11-26 14:27                   ` Vivek Goyal
2013-11-26 14:27                     ` Vivek Goyal
2013-12-19 12:54                     ` Torsten Duwe
2013-12-19 12:54                       ` Torsten Duwe
2013-12-20 14:19                       ` Vivek Goyal
2013-12-20 14:19                         ` Vivek Goyal
2013-12-20 23:11                         ` Eric W. Biederman
2013-12-20 23:11                           ` Eric W. Biederman
2013-12-20 23:20                           ` Kees Cook
2013-12-20 23:20                             ` Kees Cook
2013-12-21 11:38                             ` Torsten Duwe
2013-12-21 11:38                               ` Torsten Duwe
2014-01-02 20:39                             ` Vivek Goyal
2014-01-02 20:39                               ` Vivek Goyal
2014-01-02 20:56                               ` H. Peter Anvin
2014-01-02 20:56                                 ` H. Peter Anvin
2014-01-06 21:33                                 ` Josh Boyer
2014-01-06 21:33                                   ` Josh Boyer
2014-01-07  4:22                                   ` H. Peter Anvin
2014-01-07  4:22                                     ` H. Peter Anvin
2013-12-20 23:20                           ` H. Peter Anvin
2013-12-20 23:20                             ` H. Peter Anvin
2013-12-21  1:32                             ` Eric W. Biederman [this message]
2013-12-21  1:32                               ` Eric W. Biederman
2013-12-21  3:32                               ` H. Peter Anvin
2013-12-21  3:32                                 ` H. Peter Anvin
2013-12-21 12:15                                 ` Torsten Duwe
2013-12-21 12:15                                   ` Torsten Duwe
2013-11-21 19:16     ` Vivek Goyal
2013-11-21 19:16       ` Vivek Goyal
2013-11-22  1:03     ` Kees Cook
2013-11-22  1:03       ` Kees Cook
2013-11-22  2:13       ` Vivek Goyal
2013-11-22  2:13         ` Vivek Goyal
2013-11-22 20:42   ` Jiri Kosina
2013-11-22 20:42     ` Jiri Kosina
2014-01-17 19:17     ` Vivek Goyal
2014-01-17 19:17       ` Vivek Goyal
2013-11-29  3:10   ` Baoquan He
2013-11-29  3:10     ` Baoquan He
2013-12-02 15:27     ` WANG Chao
2013-12-02 15:27       ` WANG Chao
2013-12-02 15:44     ` Vivek Goyal
2013-12-02 15:44       ` Vivek Goyal
2013-12-04  1:35       ` Baoquan He
2013-12-04  1:35         ` Baoquan He
2013-12-04 17:19         ` Vivek Goyal
2013-12-04 17:19           ` Vivek Goyal
2013-12-04  1:56   ` Baoquan He
2013-12-04  1:56     ` Baoquan He
2013-12-04  8:19     ` Baoquan He
2013-12-04  8:19       ` Baoquan He
2013-12-04 17:32     ` Vivek Goyal
2013-12-04 17:32       ` Vivek Goyal
2013-11-20 17:50 ` [PATCH 5/6] kexec-bzImage: Support for loading bzImage using 64bit entry Vivek Goyal
2013-11-20 17:50   ` Vivek Goyal
2013-11-21 19:07   ` Greg KH
2013-11-21 19:07     ` Greg KH
2013-11-21 19:21     ` Vivek Goyal
2013-11-21 19:21       ` Vivek Goyal
2013-11-22 15:24       ` H. Peter Anvin
2013-11-22 15:24         ` H. Peter Anvin
2013-11-28 11:35   ` Baoquan He
2013-11-28 11:35     ` Baoquan He
2013-12-02 15:36     ` Vivek Goyal
2013-12-02 15:36       ` Vivek Goyal
2013-11-20 17:50 ` [PATCH 6/6] kexec: Support for Kexec on panic using new system call Vivek Goyal
2013-11-20 17:50   ` Vivek Goyal
2013-11-28 11:28   ` Baoquan He
2013-11-28 11:28     ` Baoquan He
2013-12-02 15:30     ` Vivek Goyal
2013-12-02 15:30       ` Vivek Goyal
2013-12-04  1:51       ` Baoquan He
2013-12-04  1:51         ` Baoquan He
2013-12-04 17:20         ` Vivek Goyal
2013-12-04 17:20           ` Vivek Goyal
2013-12-04  1:41   ` Baoquan He
2013-12-04  1:41     ` Baoquan He
2013-12-04 17:19     ` Vivek Goyal
2013-12-04 17:19       ` Vivek Goyal
2013-11-21 18:58 ` [PATCH 0/6] kexec: A new system call to allow in kernel loading Greg KH
2013-11-21 18:58   ` Greg KH
2013-11-21 19:07   ` Vivek Goyal
2013-11-21 19:07     ` Vivek Goyal
2013-11-21 19:46     ` Vivek Goyal
2013-11-21 19:46       ` Vivek Goyal
2013-11-21 19:06 ` Geert Uytterhoeven
2013-11-21 19:06   ` Geert Uytterhoeven
2013-11-21 19:14   ` Vivek Goyal
2013-11-21 19:14     ` Vivek Goyal
2013-11-21 23:07 ` Eric W. Biederman
2013-11-21 23:07   ` Eric W. Biederman
2013-11-22  1:28   ` H. Peter Anvin
2013-11-22  1:28     ` H. Peter Anvin
2013-11-22  2:35     ` Vivek Goyal
2013-11-22  2:35       ` Vivek Goyal
2013-11-22  2:40       ` H. Peter Anvin
2013-11-22  2:40         ` H. Peter Anvin
2013-11-22  1:55   ` Vivek Goyal
2013-11-22  1:55     ` Vivek Goyal
2013-11-22  9:09     ` Geert Uytterhoeven
2013-11-22  9:09       ` Geert Uytterhoeven
2013-11-22 13:30       ` Jiri Kosina
2013-11-22 13:30         ` Jiri Kosina
2013-11-22 13:46         ` Vivek Goyal
2013-11-22 13:46           ` Vivek Goyal
2013-11-22 13:50           ` Jiri Kosina
2013-11-22 13:50             ` Jiri Kosina
2013-11-22 15:33             ` Vivek Goyal
2013-11-22 15:33               ` Vivek Goyal
2013-11-22 17:45               ` Kees Cook
2013-11-22 17:45                 ` Kees Cook
2013-11-22 13:43       ` Vivek Goyal
2013-11-22 13:43         ` Vivek Goyal
2013-11-22 15:25         ` Geert Uytterhoeven
2013-11-22 15:25           ` Geert Uytterhoeven
2013-11-22 15:33           ` Jiri Kosina
2013-11-22 15:33             ` Jiri Kosina
2013-11-22 15:57             ` Eric Paris
2013-11-22 15:57               ` Eric Paris
2013-11-22 16:04               ` Jiri Kosina
2013-11-22 16:04                 ` Jiri Kosina
2013-11-22 16:08                 ` Vivek Goyal
2013-11-22 16:08                   ` Vivek Goyal
2013-11-22 13:34     ` Eric W. Biederman
2013-11-22 13:34       ` Eric W. Biederman
2013-11-22 14:19       ` Vivek Goyal
2013-11-22 14:19         ` Vivek Goyal
2013-11-22 19:48         ` Greg KH
2013-11-22 19:48           ` Greg KH
2013-11-23  3:23         ` Eric W. Biederman
2013-11-23  3:23           ` Eric W. Biederman
2013-12-04 19:34           ` Vivek Goyal
2013-12-04 19:34             ` Vivek Goyal
2013-12-05  4:10             ` Eric W. Biederman
2013-12-05  4:10               ` Eric W. Biederman
2013-11-25 10:04       ` Michael Holzheu
2013-11-25 10:04         ` Michael Holzheu
2013-11-25 15:36         ` Vivek Goyal
2013-11-25 15:36           ` Vivek Goyal
2013-11-25 16:15           ` Michael Holzheu
2013-11-25 16:15             ` Michael Holzheu
2013-11-22  0:55 ` HATAYAMA Daisuke
2013-11-22  0:55   ` HATAYAMA Daisuke
2013-11-22  2:03   ` Vivek Goyal
2013-11-22  2:03     ` Vivek Goyal
2013-12-03 13:23 ` Baoquan He
2013-12-03 13:23   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioujf0ox.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=duwe@lst.de \
    --cc=greg@kroah.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=pjones@redhat.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.