From: Nam Cao <namcao@linutronix.de>
To: Charlie Jenkins via B4 Relay
<devnull+thecharlesjenkins.gmail.com@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Conor Dooley <conor@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-kselftest@vger.kernel.org,
Charlie Jenkins <thecharlesjenkins@gmail.com>
Subject: Re: [PATCH 04/16] riscv: kprobes: Use generated instruction headers
Date: Thu, 11 Jun 2026 08:22:41 +0200 [thread overview]
Message-ID: <87jys5egum.fsf@yellow.woof> (raw)
In-Reply-To: <20260407-riscv_insn_table-v1-4-54b4736a1e77@gmail.com>
Charlie Jenkins via B4 Relay
<devnull+thecharlesjenkins.gmail.com@kernel.org> writes:
> This was again verified by checking all 32-bit values for each of these
> functions and checking that the two version have the same behavior.
Your checking is missing some cases. branch instructions and c.jr are
broken.
Btw, any chance that check can be added as a new kunit test case? I
wrote the CONFIG_RISCV_KPROBES_KUNIT, but that only tests some values.
Nam
WARNING: multiple messages have this Message-ID (diff)
From: Nam Cao <namcao@linutronix.de>
To: Charlie Jenkins via B4 Relay
<devnull+thecharlesjenkins.gmail.com@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Conor Dooley <conor@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-kselftest@vger.kernel.org,
Charlie Jenkins <thecharlesjenkins@gmail.com>
Subject: Re: [PATCH 04/16] riscv: kprobes: Use generated instruction headers
Date: Thu, 11 Jun 2026 08:22:41 +0200 [thread overview]
Message-ID: <87jys5egum.fsf@yellow.woof> (raw)
In-Reply-To: <20260407-riscv_insn_table-v1-4-54b4736a1e77@gmail.com>
Charlie Jenkins via B4 Relay
<devnull+thecharlesjenkins.gmail.com@kernel.org> writes:
> This was again verified by checking all 32-bit values for each of these
> functions and checking that the two version have the same behavior.
Your checking is missing some cases. branch instructions and c.jr are
broken.
Btw, any chance that check can be added as a new kunit test case? I
wrote the CONFIG_RISCV_KPROBES_KUNIT, but that only tests some values.
Nam
--
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Nam Cao <namcao@linutronix.de>
To: Charlie Jenkins via B4 Relay
<devnull+thecharlesjenkins.gmail.com@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Conor Dooley <conor@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-kselftest@vger.kernel.org,
Charlie Jenkins <thecharlesjenkins@gmail.com>
Subject: Re: [PATCH 04/16] riscv: kprobes: Use generated instruction headers
Date: Thu, 11 Jun 2026 08:22:41 +0200 [thread overview]
Message-ID: <87jys5egum.fsf@yellow.woof> (raw)
In-Reply-To: <20260407-riscv_insn_table-v1-4-54b4736a1e77@gmail.com>
Charlie Jenkins via B4 Relay
<devnull+thecharlesjenkins.gmail.com@kernel.org> writes:
> This was again verified by checking all 32-bit values for each of these
> functions and checking that the two version have the same behavior.
Your checking is missing some cases. branch instructions and c.jr are
broken.
Btw, any chance that check can be added as a new kunit test case? I
wrote the CONFIG_RISCV_KPROBES_KUNIT, but that only tests some values.
Nam
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-06-11 6:22 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 4:45 [PATCH 00/16] riscv: Generate riscv instruction functions Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 01/16] riscv: Introduce instruction table generation Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-06-10 15:56 ` Nam Cao
2026-06-10 15:56 ` Nam Cao
2026-06-10 15:56 ` Nam Cao
2026-06-11 1:06 ` Charlie Jenkins
2026-06-11 1:06 ` Charlie Jenkins
2026-06-11 1:06 ` Charlie Jenkins
2026-06-11 5:21 ` Nam Cao
2026-06-11 5:21 ` Nam Cao
2026-06-11 5:21 ` Nam Cao
2026-04-08 4:45 ` [PATCH 02/16] riscv: alternatives: Use generated instruction headers for patching code Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 03/16] riscv: kgdb: Use generated instruction headers Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-06-11 6:08 ` Nam Cao
2026-06-11 6:08 ` Nam Cao
2026-06-11 6:08 ` Nam Cao
2026-04-08 4:45 ` [PATCH 04/16] riscv: kprobes: " Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-06-11 6:14 ` Nam Cao
2026-06-11 6:14 ` Nam Cao
2026-06-11 6:14 ` Nam Cao
2026-06-11 6:22 ` Nam Cao [this message]
2026-06-11 6:22 ` Nam Cao
2026-06-11 6:22 ` Nam Cao
2026-04-08 4:45 ` [PATCH 05/16] riscv: cfi: " Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 06/16] riscv: Use generated instruction headers for misaligned loads/stores Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 07/16] riscv: kvm: Use generated instruction headers for csr code Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 08/16] riscv: kvm: Fix MMIO emulation for sign-extended insns Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 09/16] KVM: device: Add test device Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 10/16] KVM: riscv: selftests: Add mmio test Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` [PATCH 11/16] riscv: kvm: Use generated instruction headers for mmio emulation Charlie Jenkins
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:45 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` [PATCH 12/16] riscv: kvm: Add emulated test csr Charlie Jenkins
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` [PATCH 13/16] KVM: riscv: selftests: Add csr emulation test Charlie Jenkins
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` [PATCH 14/16] riscv: kvm: Use generated instruction headers for csr emulation Charlie Jenkins
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` [PATCH 15/16] riscv: kexec: Use generated instruction headers for kexec relocations Charlie Jenkins
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` [PATCH 16/16] riscv: Remove unused instruction headers Charlie Jenkins
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 4:46 ` Charlie Jenkins via B4 Relay
2026-04-08 17:58 ` [PATCH 1/16] riscv: Introduce instruction table generation Charlie Jenkins
2026-04-08 17:58 ` Charlie Jenkins
2026-04-08 17:58 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jys5egum.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=atish.patra@linux.dev \
--cc=conor@kernel.org \
--cc=devnull+thecharlesjenkins.gmail.com@kernel.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=pjw@kernel.org \
--cc=shuah@kernel.org \
--cc=thecharlesjenkins@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.