All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Adam Lackorzynski <adam@l4re.org>, maz@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linusw@kernel.org,
	kaloz@openwrt.org, khalasa@piap.pl, andrew@lunn.ch,
	gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
	linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com
Subject: Re: [PATCH 6/6] x86/ioapic: Fix return check of __irq_domain_alloc_irqs
Date: Wed, 27 Jan 2021 13:03:46 +0100	[thread overview]
Message-ID: <87k0ryfuxp.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210102175859.335447-6-adam@l4re.org>

On Sat, Jan 02 2021 at 18:58, Adam Lackorzynski wrote:
> 0 is not a proper IRQ number and also indicates failure.
> Also check for this case in upwards functions.

0 is a valid irq number for historical reasons on x86. So no.

Thanks,

        tglx


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Adam Lackorzynski <adam@l4re.org>, maz@kernel.org
Cc: andrew@lunn.ch, bgolaszewski@baylibre.com, linusw@kernel.org,
	linux-gpio@vger.kernel.org, khalasa@piap.pl, kaloz@openwrt.org,
	gregory.clement@bootlin.com,
	linux-arm-kernel@lists.infradead.org,
	sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH 6/6] x86/ioapic: Fix return check of __irq_domain_alloc_irqs
Date: Wed, 27 Jan 2021 13:03:46 +0100	[thread overview]
Message-ID: <87k0ryfuxp.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210102175859.335447-6-adam@l4re.org>

On Sat, Jan 02 2021 at 18:58, Adam Lackorzynski wrote:
> 0 is not a proper IRQ number and also indicates failure.
> Also check for this case in upwards functions.

0 is a valid irq number for historical reasons on x86. So no.

Thanks,

        tglx


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-27 12:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02 17:58 [PATCH 1/6] irqchip/bcm2836: Fix return check in IPI alloc Adam Lackorzynski
2021-01-02 17:58 ` Adam Lackorzynski
2021-01-02 17:58 ` [PATCH 2/6] irqchip/armada-370-xp: " Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-02 18:24   ` Andrew Lunn
2021-01-02 18:24     ` Andrew Lunn
2021-01-02 17:58 ` [PATCH 3/6] irqdomain/msi: Fix return check of __irq_domain_alloc_irqs Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-02 17:58 ` [PATCH 4/6] irqchip/ixp4xx: " Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-02 17:58 ` [PATCH 5/6] gpiolib: " Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-04 13:57   ` Bartosz Golaszewski
2021-01-04 13:57     ` Bartosz Golaszewski
2021-01-04 14:43     ` Adam Lackorzynski
2021-01-04 14:43       ` Adam Lackorzynski
2021-01-04 15:00   ` Andy Shevchenko
2021-01-04 15:00     ` Andy Shevchenko
2021-01-02 17:58 ` [PATCH 6/6] x86/ioapic: " Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-27 12:03   ` Thomas Gleixner [this message]
2021-01-27 12:03     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0ryfuxp.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=adam@l4re.org \
    --cc=andrew@lunn.ch \
    --cc=bgolaszewski@baylibre.com \
    --cc=gregory.clement@bootlin.com \
    --cc=kaloz@openwrt.org \
    --cc=khalasa@piap.pl \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.