* [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
@ 2020-02-21 10:54 Jani Nikula
2020-02-21 15:59 ` Randy Dunlap
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Jani Nikula @ 2020-02-21 10:54 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Masahiro Yamada, Randy Dunlap
$(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
appended is writable. This is not the case when the output filename is
/dev/null:
HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
/dev/null:1:0: error: cannot open /dev/null.gcno
HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
/dev/null:1:0: error: cannot open /dev/null.gcno
make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
make sense here anyway.
References: http://lore.kernel.org/r/d8112767-4089-4c58-d7d3-2ce03139858a@infradead.org
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index b314d44ded5e..bc28c31c4f78 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -301,7 +301,7 @@ extra-$(CONFIG_DRM_I915_WERROR) += \
$(shell cd $(srctree)/$(src) && find * -name '*.h')))
quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
- cmd_hdrtest = $(CC) $(c_flags) -S -o /dev/null -x c /dev/null -include $<; touch $@
+ cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
$(obj)/%.hdrtest: $(src)/%.h FORCE
$(call if_changed_dep,hdrtest)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-21 10:54 [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV Jani Nikula
@ 2020-02-21 15:59 ` Randy Dunlap
2020-02-24 12:22 ` Jani Nikula
2020-02-21 18:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Randy Dunlap @ 2020-02-21 15:59 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Masahiro Yamada
On 2/21/20 2:54 AM, Jani Nikula wrote:
> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
> appended is writable. This is not the case when the output filename is
> /dev/null:
>
> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
> /dev/null:1:0: error: cannot open /dev/null.gcno
> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
> /dev/null:1:0: error: cannot open /dev/null.gcno
> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
> make[5]: *** Waiting for unfinished jobs....
> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
>
> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
> make sense here anyway.
>
> References: http://lore.kernel.org/r/d8112767-4089-4c58-d7d3-2ce03139858a@infradead.org
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/gpu/drm/i915/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index b314d44ded5e..bc28c31c4f78 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -301,7 +301,7 @@ extra-$(CONFIG_DRM_I915_WERROR) += \
> $(shell cd $(srctree)/$(src) && find * -name '*.h')))
>
> quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
> - cmd_hdrtest = $(CC) $(c_flags) -S -o /dev/null -x c /dev/null -include $<; touch $@
> + cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
>
> $(obj)/%.hdrtest: $(src)/%.h FORCE
> $(call if_changed_dep,hdrtest)
>
--
~Randy
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix header test with GCOV
2020-02-21 10:54 [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV Jani Nikula
2020-02-21 15:59 ` Randy Dunlap
@ 2020-02-21 18:03 ` Patchwork
2020-02-21 18:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-21 18:03 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix header test with GCOV
URL : https://patchwork.freedesktop.org/series/73757/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
218e84549dfe drm/i915: fix header test with GCOV
-:23: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#23:
References: http://lore.kernel.org/r/d8112767-4089-4c58-d7d3-2ce03139858a@infradead.org
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix header test with GCOV
2020-02-21 10:54 [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV Jani Nikula
2020-02-21 15:59 ` Randy Dunlap
2020-02-21 18:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-02-21 18:28 ` Patchwork
2020-02-22 4:43 ` [Intel-gfx] [PATCH] " Masahiro Yamada
2020-02-24 11:54 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-21 18:28 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix header test with GCOV
URL : https://patchwork.freedesktop.org/series/73757/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7982 -> Patchwork_16658
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/index.html
Known issues
------------
Here are the changes found in Patchwork_16658 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@flink-lifetime:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([CI#94] / [i915#402]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([fdo#109635] / [i915#262])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
- fi-cml-u2: [PASS][5] -> [FAIL][6] ([i915#262])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-skl-6600u: [INCOMPLETE][7] ([i915#146] / [i915#69]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][9] ([CI#94]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_addfb_basic@addfb25-modifier-no-flag:
- fi-tgl-y: [DMESG-WARN][11] ([CI#94] / [i915#402]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-tgl-y/igt@kms_addfb_basic@addfb25-modifier-no-flag.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/fi-tgl-y/igt@kms_addfb_basic@addfb25-modifier-no-flag.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
Participating hosts (51 -> 43)
------------------------------
Additional (1): fi-hsw-peppy
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-n2820 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7982 -> Patchwork_16658
CI-20190529: 20190529
CI_DRM_7982: f02659605b48dcabb562bbb96db2996b334e57fd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5457: 3e686098d928aa928f668e00fa01e92234e173ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16658: 218e84549dfe633027963f0945b1af9772ef164f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
218e84549dfe drm/i915: fix header test with GCOV
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-21 10:54 [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV Jani Nikula
` (2 preceding siblings ...)
2020-02-21 18:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-02-22 4:43 ` Masahiro Yamada
2020-02-22 4:53 ` Masahiro Yamada
2020-02-24 11:54 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
4 siblings, 1 reply; 12+ messages in thread
From: Masahiro Yamada @ 2020-02-22 4:43 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Randy Dunlap
Hi Jani,
On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
> appended is writable. This is not the case when the output filename is
> /dev/null:
>
> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
> /dev/null:1:0: error: cannot open /dev/null.gcno
> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
> /dev/null:1:0: error: cannot open /dev/null.gcno
> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
> make[5]: *** Waiting for unfinished jobs....
> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
>
> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
> make sense here anyway.
Is GCOV the only case that produces a separate file?
Could you also test CONFIG_DEBUG_INFO_SPLIT, please ?
The GCC manual says this:
-gsplit-dwarf
Separate as much DWARF debugging information as possible into a
separate output
file with the extension .dwo. This option allows the build system
to avoid linking
files with debug information. To be useful, this option requires a debugger
capable of reading .dwo files.
If this does not work, filtering flags
does not seem to be a maintainable way.
>
> References: http://lore.kernel.org/r/d8112767-4089-4c58-d7d3-2ce03139858a@infradead.org
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index b314d44ded5e..bc28c31c4f78 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -301,7 +301,7 @@ extra-$(CONFIG_DRM_I915_WERROR) += \
> $(shell cd $(srctree)/$(src) && find * -name '*.h')))
>
> quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
> - cmd_hdrtest = $(CC) $(c_flags) -S -o /dev/null -x c /dev/null -include $<; touch $@
> + cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
>
> $(obj)/%.hdrtest: $(src)/%.h FORCE
> $(call if_changed_dep,hdrtest)
> --
> 2.20.1
>
--
Best Regards
Masahiro Yamada
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-22 4:43 ` [Intel-gfx] [PATCH] " Masahiro Yamada
@ 2020-02-22 4:53 ` Masahiro Yamada
2020-02-22 5:25 ` Randy Dunlap
0 siblings, 1 reply; 12+ messages in thread
From: Masahiro Yamada @ 2020-02-22 4:53 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Randy Dunlap
On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Hi Jani,
>
> On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula <jani.nikula@intel.com> wrote:
> >
> > $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
> > appended is writable. This is not the case when the output filename is
> > /dev/null:
> >
> > HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
> > /dev/null:1:0: error: cannot open /dev/null.gcno
> > HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
> > /dev/null:1:0: error: cannot open /dev/null.gcno
> > make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> > drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
> > make[5]: *** Waiting for unfinished jobs....
> > make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> > drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
> >
> > Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
> > make sense here anyway.
>
>
>
> Is GCOV the only case that produces a separate file?
>
> Could you also test CONFIG_DEBUG_INFO_SPLIT, please ?
>
>
> The GCC manual says this:
>
> -gsplit-dwarf
>
> Separate as much DWARF debugging information as possible into a
> separate output
> file with the extension .dwo. This option allows the build system
> to avoid linking
> files with debug information. To be useful, this option requires a debugger
> capable of reading .dwo files.
>
I just tested it.
This is not a problem for header test
because cmd_hdrtest uses '-S' instead of '-c'.
If '-c' were used, we would see a similar error.
So, gsplit-dwarf is OK.
>
>
> If this does not work, filtering flags
> does not seem to be a maintainable way.
>
>
>
>
> >
> > References: http://lore.kernel.org/r/d8112767-4089-4c58-d7d3-2ce03139858a@infradead.org
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > ---
> > drivers/gpu/drm/i915/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> > index b314d44ded5e..bc28c31c4f78 100644
> > --- a/drivers/gpu/drm/i915/Makefile
> > +++ b/drivers/gpu/drm/i915/Makefile
> > @@ -301,7 +301,7 @@ extra-$(CONFIG_DRM_I915_WERROR) += \
> > $(shell cd $(srctree)/$(src) && find * -name '*.h')))
> >
> > quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
> > - cmd_hdrtest = $(CC) $(c_flags) -S -o /dev/null -x c /dev/null -include $<; touch $@
> > + cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
> >
> > $(obj)/%.hdrtest: $(src)/%.h FORCE
> > $(call if_changed_dep,hdrtest)
> > --
> > 2.20.1
> >
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-22 4:53 ` Masahiro Yamada
@ 2020-02-22 5:25 ` Randy Dunlap
2020-02-22 5:49 ` Masahiro Yamada
0 siblings, 1 reply; 12+ messages in thread
From: Randy Dunlap @ 2020-02-22 5:25 UTC (permalink / raw)
To: Masahiro Yamada, Jani Nikula; +Cc: intel-gfx
On 2/21/20 8:53 PM, Masahiro Yamada wrote:
> On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>
>> Hi Jani,
>>
>> On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula <jani.nikula@intel.com> wrote:
>>>
>>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
>>> appended is writable. This is not the case when the output filename is
>>> /dev/null:
>>>
>>> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
>>> /dev/null:1:0: error: cannot open /dev/null.gcno
>>> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
>>> /dev/null:1:0: error: cannot open /dev/null.gcno
>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>>> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
>>> make[5]: *** Waiting for unfinished jobs....
>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>>> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
>>>
>>> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
>>> make sense here anyway.
>>
>>
>>
>> Is GCOV the only case that produces a separate file?
>>
>> Could you also test CONFIG_DEBUG_INFO_SPLIT, please ?
>>
>>
>> The GCC manual says this:
>>
>> -gsplit-dwarf
>>
>> Separate as much DWARF debugging information as possible into a
>> separate output
>> file with the extension .dwo. This option allows the build system
>> to avoid linking
>> files with debug information. To be useful, this option requires a debugger
>> capable of reading .dwo files.
>>
>
>
> I just tested it.
>
> This is not a problem for header test
> because cmd_hdrtest uses '-S' instead of '-c'.
>
> If '-c' were used, we would see a similar error.
>
>
> So, gsplit-dwarf is OK.
Yes, works for me also.
(I think you have a faster build machine that I do. I began the build
almost immediately after reading your email. :)
--
~Randy
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-22 5:25 ` Randy Dunlap
@ 2020-02-22 5:49 ` Masahiro Yamada
2020-02-22 5:53 ` Randy Dunlap
0 siblings, 1 reply; 12+ messages in thread
From: Masahiro Yamada @ 2020-02-22 5:49 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Jani Nikula, intel-gfx
On Sat, Feb 22, 2020 at 2:25 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 2/21/20 8:53 PM, Masahiro Yamada wrote:
> > On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >>
> >> Hi Jani,
> >>
> >> On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula <jani.nikula@intel.com> wrote:
> >>>
> >>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
> >>> appended is writable. This is not the case when the output filename is
> >>> /dev/null:
> >>>
> >>> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
> >>> /dev/null:1:0: error: cannot open /dev/null.gcno
> >>> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
> >>> /dev/null:1:0: error: cannot open /dev/null.gcno
> >>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> >>> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
> >>> make[5]: *** Waiting for unfinished jobs....
> >>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
> >>> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
> >>>
> >>> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
> >>> make sense here anyway.
> >>
> >>
> >>
> >> Is GCOV the only case that produces a separate file?
> >>
> >> Could you also test CONFIG_DEBUG_INFO_SPLIT, please ?
> >>
> >>
> >> The GCC manual says this:
> >>
> >> -gsplit-dwarf
> >>
> >> Separate as much DWARF debugging information as possible into a
> >> separate output
> >> file with the extension .dwo. This option allows the build system
> >> to avoid linking
> >> files with debug information. To be useful, this option requires a debugger
> >> capable of reading .dwo files.
> >>
> >
> >
> > I just tested it.
> >
> > This is not a problem for header test
> > because cmd_hdrtest uses '-S' instead of '-c'.
> >
> > If '-c' were used, we would see a similar error.
> >
> >
> > So, gsplit-dwarf is OK.
>
> Yes, works for me also.
>
> (I think you have a faster build machine that I do. I began the build
> almost immediately after reading your email. :)
I use a reasonable PC for my development.
(core-i9 with 4 physical cores)
I just compiled under i915/ with this command:
make drivers/gpu/drm/i915/
--
Best Regards
Masahiro Yamada
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-22 5:49 ` Masahiro Yamada
@ 2020-02-22 5:53 ` Randy Dunlap
2020-02-24 12:29 ` Jani Nikula
0 siblings, 1 reply; 12+ messages in thread
From: Randy Dunlap @ 2020-02-22 5:53 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Jani Nikula, intel-gfx
On 2/21/20 9:49 PM, Masahiro Yamada wrote:
> On Sat, Feb 22, 2020 at 2:25 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 2/21/20 8:53 PM, Masahiro Yamada wrote:
>>> On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>>
>>>> Hi Jani,
>>>>
>>>> On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula <jani.nikula@intel.com> wrote:
>>>>>
>>>>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
>>>>> appended is writable. This is not the case when the output filename is
>>>>> /dev/null:
>>>>>
>>>>> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
>>>>> /dev/null:1:0: error: cannot open /dev/null.gcno
>>>>> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
>>>>> /dev/null:1:0: error: cannot open /dev/null.gcno
>>>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>>>>> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
>>>>> make[5]: *** Waiting for unfinished jobs....
>>>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>>>>> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
>>>>>
>>>>> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
>>>>> make sense here anyway.
>>>>
>>>>
>>>>
>>>> Is GCOV the only case that produces a separate file?
>>>>
>>>> Could you also test CONFIG_DEBUG_INFO_SPLIT, please ?
>>>>
>>>>
>>>> The GCC manual says this:
>>>>
>>>> -gsplit-dwarf
>>>>
>>>> Separate as much DWARF debugging information as possible into a
>>>> separate output
>>>> file with the extension .dwo. This option allows the build system
>>>> to avoid linking
>>>> files with debug information. To be useful, this option requires a debugger
>>>> capable of reading .dwo files.
>>>>
>>>
>>>
>>> I just tested it.
>>>
>>> This is not a problem for header test
>>> because cmd_hdrtest uses '-S' instead of '-c'.
>>>
>>> If '-c' were used, we would see a similar error.
>>>
>>>
>>> So, gsplit-dwarf is OK.
>>
>> Yes, works for me also.
>>
>> (I think you have a faster build machine that I do. I began the build
>> almost immediately after reading your email. :)
>
>
> I use a reasonable PC for my development.
> (core-i9 with 4 physical cores)
>
>
> I just compiled under i915/ with this command:
>
> make drivers/gpu/drm/i915/
Good trick. I did a full build.
--
~Randy
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix header test with GCOV
2020-02-21 10:54 [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV Jani Nikula
` (3 preceding siblings ...)
2020-02-22 4:43 ` [Intel-gfx] [PATCH] " Masahiro Yamada
@ 2020-02-24 11:54 ` Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-02-24 11:54 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix header test with GCOV
URL : https://patchwork.freedesktop.org/series/73757/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7982_full -> Patchwork_16658_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16658_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +14 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb4/igt@gem_busy@busy-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb7/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +18 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb3/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb7/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb5/igt@gem_exec_schedule@reorder-wide-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_tiled_fence_blits@normal:
- shard-apl: [PASS][11] -> [TIMEOUT][12] ([fdo#112271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-apl2/igt@gem_tiled_fence_blits@normal.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-apl8/igt@gem_tiled_fence_blits@normal.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#716])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-skl1/igt@gen9_exec_parse@allowed-single.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-skl1/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-iclb: [PASS][17] -> [TIMEOUT][18] ([fdo#112271]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [PASS][19] -> [SKIP][20] ([i915#668]) +5 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-tglb8/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-tglb2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#123] / [i915#69])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-skl9/igt@kms_frontbuffer_tracking@psr-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-skl2/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][23] -> [INCOMPLETE][24] ([fdo#103665])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-skl: [PASS][25] -> [DMESG-WARN][26] ([IGT#6])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-skl10/igt@kms_plane_multiple@atomic-pipe-a-tiling-y.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-skl5/igt@kms_plane_multiple@atomic-pipe-a-tiling-y.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109642] / [fdo#111068])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb2/igt@kms_psr2_su@page_flip.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb7/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][29] -> [FAIL][30] ([i915#173])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb8/igt@kms_psr@no_drrs.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb2/igt@kms_psr@psr2_dpms.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb5/igt@kms_psr@psr2_dpms.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [DMESG-WARN][33] ([i915#180]) -> [PASS][34] +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-apl6/igt@gem_ctx_isolation@bcs0-s3.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-apl6/igt@gem_ctx_isolation@bcs0-s3.html
* {igt@gem_ctx_persistence@close-replace-race}:
- shard-kbl: [INCOMPLETE][35] ([fdo#103665] / [i915#1291]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-kbl4/igt@gem_ctx_persistence@close-replace-race.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-kbl1/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][37] ([fdo#112080]) -> [PASS][38] +14 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb7/igt@gem_exec_parallel@vcs1-fds.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* {igt@gem_exec_schedule@implicit-both-bsd2}:
- shard-iclb: [SKIP][39] ([fdo#109276] / [i915#677]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb3/igt@gem_exec_schedule@implicit-both-bsd2.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd2.html
* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][41] ([i915#677]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb3/igt@gem_exec_schedule@pi-common-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][43] ([fdo#109276]) -> [PASS][44] +24 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-self-bsd:
- shard-iclb: [SKIP][45] ([fdo#112146]) -> [PASS][46] +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb5/igt@gem_exec_schedule@preempt-self-bsd.html
* {igt@gem_exec_whisper@basic-queues-forked}:
- shard-glk: [INCOMPLETE][47] ([i915#58] / [k.org#198133]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-glk4/igt@gem_exec_whisper@basic-queues-forked.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][49] ([i915#413]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb1/igt@i915_pm_rps@waitboost.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb5/igt@i915_pm_rps@waitboost.html
* igt@i915_selftest@live_gtt:
- shard-kbl: [TIMEOUT][51] ([fdo#112271]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-kbl3/igt@i915_selftest@live_gtt.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-kbl6/igt@i915_selftest@live_gtt.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-kbl2/igt@i915_suspend@sysfs-reader.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-kbl6/igt@i915_suspend@sysfs-reader.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][55] ([i915#79]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][57] ([fdo#108145]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@sw_sync@sync_multi_producer_single_consumer:
- shard-snb: [TIMEOUT][61] ([fdo#112271]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-snb2/igt@sw_sync@sync_multi_producer_single_consumer.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-snb6/igt@sw_sync@sync_multi_producer_single_consumer.html
- shard-glk: [TIMEOUT][63] ([fdo#112271]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-glk8/igt@sw_sync@sync_multi_producer_single_consumer.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-glk9/igt@sw_sync@sync_multi_producer_single_consumer.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][65] ([fdo#112080]) -> [FAIL][66] ([IGT#28]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][67] ([i915#69]) -> [TIMEOUT][68] ([fdo#112271])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-skl8/igt@gem_softpin@noreloc-s3.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-skl2/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][69] ([i915#454]) -> [SKIP][70] ([i915#468])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-tglb8/igt@i915_pm_dc@dc6-psr.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-tglb2/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@legacy-planes-dpms:
- shard-snb: [INCOMPLETE][71] ([i915#82]) -> [SKIP][72] ([fdo#109271])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-snb2/igt@i915_pm_rpm@legacy-planes-dpms.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-snb5/igt@i915_pm_rpm@legacy-planes-dpms.html
* igt@i915_selftest@live_gt_lrc:
- shard-tglb: [DMESG-FAIL][73] ([i915#1233]) -> [INCOMPLETE][74] ([i915#1233])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/shard-tglb5/igt@i915_selftest@live_gt_lrc.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/shard-tglb1/igt@i915_selftest@live_gt_lrc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
[i915#1291]: https://gitlab.freedesktop.org/drm/intel/issues/1291
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7982 -> Patchwork_16658
CI-20190529: 20190529
CI_DRM_7982: f02659605b48dcabb562bbb96db2996b334e57fd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5457: 3e686098d928aa928f668e00fa01e92234e173ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16658: 218e84549dfe633027963f0945b1af9772ef164f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16658/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-21 15:59 ` Randy Dunlap
@ 2020-02-24 12:22 ` Jani Nikula
0 siblings, 0 replies; 12+ messages in thread
From: Jani Nikula @ 2020-02-24 12:22 UTC (permalink / raw)
To: Randy Dunlap, intel-gfx; +Cc: Masahiro Yamada
On Fri, 21 Feb 2020, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 2/21/20 2:54 AM, Jani Nikula wrote:
>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
>> appended is writable. This is not the case when the output filename is
>> /dev/null:
>>
>> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
>> /dev/null:1:0: error: cannot open /dev/null.gcno
>> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
>> /dev/null:1:0: error: cannot open /dev/null.gcno
>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
>> make[5]: *** Waiting for unfinished jobs....
>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
>>
>> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
>> make sense here anyway.
>>
>> References: http://lore.kernel.org/r/d8112767-4089-4c58-d7d3-2ce03139858a@infradead.org
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
And pushed, thanks for the ack.
BR,
Jani.
>
> Thanks.
>
>> ---
>> drivers/gpu/drm/i915/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>> index b314d44ded5e..bc28c31c4f78 100644
>> --- a/drivers/gpu/drm/i915/Makefile
>> +++ b/drivers/gpu/drm/i915/Makefile
>> @@ -301,7 +301,7 @@ extra-$(CONFIG_DRM_I915_WERROR) += \
>> $(shell cd $(srctree)/$(src) && find * -name '*.h')))
>>
>> quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
>> - cmd_hdrtest = $(CC) $(c_flags) -S -o /dev/null -x c /dev/null -include $<; touch $@
>> + cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
>>
>> $(obj)/%.hdrtest: $(src)/%.h FORCE
>> $(call if_changed_dep,hdrtest)
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV
2020-02-22 5:53 ` Randy Dunlap
@ 2020-02-24 12:29 ` Jani Nikula
0 siblings, 0 replies; 12+ messages in thread
From: Jani Nikula @ 2020-02-24 12:29 UTC (permalink / raw)
To: Randy Dunlap, Masahiro Yamada; +Cc: intel-gfx
On Fri, 21 Feb 2020, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 2/21/20 9:49 PM, Masahiro Yamada wrote:
>> On Sat, Feb 22, 2020 at 2:25 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> On 2/21/20 8:53 PM, Masahiro Yamada wrote:
>>>> On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>>>
>>>>> Hi Jani,
>>>>>
>>>>> On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula <jani.nikula@intel.com> wrote:
>>>>>>
>>>>>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix
>>>>>> appended is writable. This is not the case when the output filename is
>>>>>> /dev/null:
>>>>>>
>>>>>> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h
>>>>>> /dev/null:1:0: error: cannot open /dev/null.gcno
>>>>>> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h
>>>>>> /dev/null:1:0: error: cannot open /dev/null.gcno
>>>>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>>>>>> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1
>>>>>> make[5]: *** Waiting for unfinished jobs....
>>>>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307:
>>>>>> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1
>>>>>>
>>>>>> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't
>>>>>> make sense here anyway.
>>>>>
>>>>>
>>>>>
>>>>> Is GCOV the only case that produces a separate file?
>>>>>
>>>>> Could you also test CONFIG_DEBUG_INFO_SPLIT, please ?
>>>>>
>>>>>
>>>>> The GCC manual says this:
>>>>>
>>>>> -gsplit-dwarf
>>>>>
>>>>> Separate as much DWARF debugging information as possible into a
>>>>> separate output
>>>>> file with the extension .dwo. This option allows the build system
>>>>> to avoid linking
>>>>> files with debug information. To be useful, this option requires a debugger
>>>>> capable of reading .dwo files.
>>>>>
>>>>
>>>>
>>>> I just tested it.
>>>>
>>>> This is not a problem for header test
>>>> because cmd_hdrtest uses '-S' instead of '-c'.
>>>>
>>>> If '-c' were used, we would see a similar error.
>>>>
>>>>
>>>> So, gsplit-dwarf is OK.
>>>
>>> Yes, works for me also.
>>>
>>> (I think you have a faster build machine that I do. I began the build
>>> almost immediately after reading your email. :)
>>
>>
>> I use a reasonable PC for my development.
>> (core-i9 with 4 physical cores)
>>
>>
>> I just compiled under i915/ with this command:
>>
>> make drivers/gpu/drm/i915/
>
> Good trick. I did a full build.
Thanks for the testing.
I also checked with some other options, did not see any failures. I'll
go with this for now, let's revisit as needed.
Another related thing is we try to hide this a bit from build testing
outside of our CI with "depends on !COMPILE_TEST" but I guess there's no
way to ensure something is not enabled on a randconfig build...
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-02-24 18:13 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-21 10:54 [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV Jani Nikula
2020-02-21 15:59 ` Randy Dunlap
2020-02-24 12:22 ` Jani Nikula
2020-02-21 18:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-21 18:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-22 4:43 ` [Intel-gfx] [PATCH] " Masahiro Yamada
2020-02-22 4:53 ` Masahiro Yamada
2020-02-22 5:25 ` Randy Dunlap
2020-02-22 5:49 ` Masahiro Yamada
2020-02-22 5:53 ` Randy Dunlap
2020-02-24 12:29 ` Jani Nikula
2020-02-24 11:54 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.