From: Jani Nikula <jani.nikula@linux.intel.com>
To: daniel.vetter@intel.com, airlied@linux.ie,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: yeongjin.jang@gatech.edu, taesoo@gatech.edu, insu@gatech.edu,
Insu Yun <wuninsu@gmail.com>,
changwoo@gatech.edu
Subject: Re: [PATCH] i915: correctly handling failed allocation
Date: Wed, 30 Dec 2015 11:16:15 +0200 [thread overview]
Message-ID: <87k2nwe1pc.fsf@intel.com> (raw)
In-Reply-To: <1451415713-9508-1-git-send-email-wuninsu@gmail.com>
On Tue, 29 Dec 2015, Insu Yun <wuninsu@gmail.com> wrote:
> Signed-off-by: Insu Yun <wuninsu@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> index a5e99ac..4e279dd 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> @@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id)
>
> /* This is cheating a bit with the cleanup. */
> vbt_panel = devm_kzalloc(dev->dev, sizeof(*vbt_panel), GFP_KERNEL);
> + if (!vbt_pannel)
> + return NULL;
We have build bots and CI, but the least you must do is build the code
you change before submitting patches.
BR,
Jani.
>
> vbt_panel->intel_dsi = intel_dsi;
> drm_panel_init(&vbt_panel->panel);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Insu Yun <wuninsu@gmail.com>,
daniel.vetter@intel.com, airlied@linux.ie,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
changwoo@gatech.edu, Insu Yun <wuninsu@gmail.com>
Subject: Re: [PATCH] i915: correctly handling failed allocation
Date: Wed, 30 Dec 2015 11:16:15 +0200 [thread overview]
Message-ID: <87k2nwe1pc.fsf@intel.com> (raw)
In-Reply-To: <1451415713-9508-1-git-send-email-wuninsu@gmail.com>
On Tue, 29 Dec 2015, Insu Yun <wuninsu@gmail.com> wrote:
> Signed-off-by: Insu Yun <wuninsu@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> index a5e99ac..4e279dd 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> @@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id)
>
> /* This is cheating a bit with the cleanup. */
> vbt_panel = devm_kzalloc(dev->dev, sizeof(*vbt_panel), GFP_KERNEL);
> + if (!vbt_pannel)
> + return NULL;
We have build bots and CI, but the least you must do is build the code
you change before submitting patches.
BR,
Jani.
>
> vbt_panel->intel_dsi = intel_dsi;
> drm_panel_init(&vbt_panel->panel);
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-12-30 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 19:01 [PATCH] i915: correctly handling failed allocation Insu Yun
2015-12-29 19:07 ` kbuild test robot
2015-12-29 19:07 ` kbuild test robot
2015-12-30 9:16 ` Jani Nikula [this message]
2015-12-30 9:16 ` Jani Nikula
2015-12-30 15:56 ` Insu Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2nwe1pc.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=changwoo@gatech.edu \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=insu@gatech.edu \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=taesoo@gatech.edu \
--cc=wuninsu@gmail.com \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.