From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and CPUilde support.
Date: Fri, 11 Mar 2011 09:50:22 -0800 [thread overview]
Message-ID: <87k4g5a6n5.fsf@ti.com> (raw)
In-Reply-To: <f1ee9adb49c6dbc49205c5ba70007e9a@mail.gmail.com> (Santosh Shilimkar's message of "Fri, 11 Mar 2011 22:56:41 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> Kevin,
>
>> -----Original Message-----
>> From: linux-arm-kernel-bounces@lists.infradead.org [mailto:linux-
>> arm-kernel-bounces@lists.infradead.org] On Behalf Of Kevin Hilman
>> Sent: Friday, March 11, 2011 9:22 PM
>> To: Santosh Shilimkar
>> Cc: linux-omap@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; Rajendra Nayak
>> Subject: Re: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and
>> CPUilde support.
>>
>
> [....]
>
>> >
>> > So just to summaries, on OMAP$ 'enable_off_mode' flag is
>> > used __only__ in Suspend. CPUx power domain always hit OFF
>> > mode no matter what is state of this flag because CSWR isn't
>> > supported on these PD's.
>>
>> If it's useful only in suspend, then it's redundant with the
>> <debugfs>/pm_debug/*_pwrdm/suspend controls which allow per-pwrdm
>> control over next states.
>>
>> > We could remove this flag as well but thought that this might be
>> > useful especially when we add CORE RET, DEVICE OFF support.
>>
>> I'd rather see working off-mode be a requirement for getting OMAP4
>> drivers supported.
>>
>> Also, we can still test suspend/resume with off-mode disabled by
>> using the above debugfs controls.
>>
>> > May be we keep this till the constraint frameworks comes in and
>> > then drop it once for all. I am ok with whatever direction you
>> > decide here.
>>
>> I prefer to drop it completely for OMAP4.
>>
> OK. Lets do that.
>
> Just to not miss your point here, what I understood here
> is default suspend state on OMAP$B will be off mode.
>
> We still keep "enable_off_mode" flag for testing so that we
> can disable off mode to debug regressions.
>
> Is that right?
No, I want to drop "enable_off_mode" all together for OMAP4.
If you want to change any powerdomain's default next_state, you can use
the <debugfs>/pm_debug/*_pwrdm/suspend controls.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.
Date: Fri, 11 Mar 2011 09:50:22 -0800 [thread overview]
Message-ID: <87k4g5a6n5.fsf@ti.com> (raw)
In-Reply-To: <f1ee9adb49c6dbc49205c5ba70007e9a@mail.gmail.com> (Santosh Shilimkar's message of "Fri, 11 Mar 2011 22:56:41 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> Kevin,
>
>> -----Original Message-----
>> From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-
>> arm-kernel-bounces at lists.infradead.org] On Behalf Of Kevin Hilman
>> Sent: Friday, March 11, 2011 9:22 PM
>> To: Santosh Shilimkar
>> Cc: linux-omap at vger.kernel.org; linux-arm-
>> kernel at lists.infradead.org; Rajendra Nayak
>> Subject: Re: [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug and
>> CPUilde support.
>>
>
> [....]
>
>> >
>> > So just to summaries, on OMAP$ 'enable_off_mode' flag is
>> > used __only__ in Suspend. CPUx power domain always hit OFF
>> > mode no matter what is state of this flag because CSWR isn't
>> > supported on these PD's.
>>
>> If it's useful only in suspend, then it's redundant with the
>> <debugfs>/pm_debug/*_pwrdm/suspend controls which allow per-pwrdm
>> control over next states.
>>
>> > We could remove this flag as well but thought that this might be
>> > useful especially when we add CORE RET, DEVICE OFF support.
>>
>> I'd rather see working off-mode be a requirement for getting OMAP4
>> drivers supported.
>>
>> Also, we can still test suspend/resume with off-mode disabled by
>> using the above debugfs controls.
>>
>> > May be we keep this till the constraint frameworks comes in and
>> > then drop it once for all. I am ok with whatever direction you
>> > decide here.
>>
>> I prefer to drop it completely for OMAP4.
>>
> OK. Lets do that.
>
> Just to not miss your point here, what I understood here
> is default suspend state on OMAP$B will be off mode.
>
> We still keep "enable_off_mode" flag for testing so that we
> can disable off mode to debug regressions.
>
> Is that right?
No, I want to drop "enable_off_mode" all together for OMAP4.
If you want to change any powerdomain's default next_state, you can use
the <debugfs>/pm_debug/*_pwrdm/suspend controls.
Kevin
next prev parent reply other threads:[~2011-03-11 17:50 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 14:07 [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support Santosh Shilimkar
2011-03-10 14:07 ` Santosh Shilimkar
2011-03-10 14:07 ` [PATCH v2 01/19] OMAP4: PM: Add omap WakeupGen module support Santosh Shilimkar
2011-03-10 14:07 ` Santosh Shilimkar
2011-03-10 14:07 ` [PATCH v2 02/19] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit Santosh Shilimkar
2011-03-10 14:07 ` Santosh Shilimkar
2011-03-10 14:07 ` [PATCH v2 03/19] OMAP4: PM: Export omap4_get_base*() rather than global address pointers Santosh Shilimkar
2011-03-10 14:07 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 04/19] OMAP4: PM: Add SAR RAM support Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 05/19] OMAP4: PM: Add CPUX OFF mode support Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 06/19] OMAP4: PM: Initialise all the clockdomains to supported states Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 07/19] OMAP4: PM: Program CPU1 to hit OFF when off-lined Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 08/19] OMAP4: PM: CPU1 wakeup workaround from Low power modes Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 09/19] OMAP4: PM: Add GIC distributor and interface enable/disable accessory API Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 10/19] OMAP4: PM: Add GIC save/restore support Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 11/19] OMAP4: PM: Add WakeupGen " Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 12/19] OMAP4: PM: Add L2 cache lowpower support Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 13/19] OMAP4: suspend: Add MPUSS RET and OFF support Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 14/19] OMAP4: pm-debug: Add wakeup timer and debug counters Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 15/19] OMAP4: cpuidle: Basic CPUidle support Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 16/19] OMAP4: cpuidle: Add MPUSS RET OFF states Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 17/19] OMAP4: cpuidle: Switch to gptimer from twd in deeper C-states Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 18/19] OMAP4: cpuidle: Add CPU hotplug notifier and prepare() hook Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 19/19] OMAP4: Remove un-used do_wfi() macro Santosh Shilimkar
2011-03-10 14:08 ` Santosh Shilimkar
2011-03-10 19:11 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support Kevin Hilman
2011-03-10 19:11 ` Kevin Hilman
2011-03-11 1:42 ` Kevin Hilman
2011-03-11 1:42 ` Kevin Hilman
2011-03-11 5:52 ` Santosh Shilimkar
2011-03-11 5:52 ` Santosh Shilimkar
2011-03-11 15:52 ` Kevin Hilman
2011-03-11 15:52 ` Kevin Hilman
2011-03-11 17:26 ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 17:26 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 17:50 ` Kevin Hilman [this message]
2011-03-11 17:50 ` Kevin Hilman
2011-03-11 17:58 ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 17:58 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 18:03 ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Kevin Hilman
2011-03-11 18:03 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Kevin Hilman
2011-03-11 18:13 ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 18:13 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 19:53 ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 19:53 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 12:31 ` Santosh Shilimkar
2011-03-11 12:31 ` Santosh Shilimkar
2011-03-11 15:56 ` Kevin Hilman
2011-03-11 15:56 ` Kevin Hilman
2011-03-11 17:06 ` Santosh Shilimkar
2011-03-11 17:06 ` Santosh Shilimkar
2011-03-24 15:09 ` Kevin Hilman
2011-03-24 15:09 ` Kevin Hilman
2011-03-25 7:05 ` Santosh Shilimkar
2011-03-25 7:05 ` Santosh Shilimkar
2011-03-25 15:24 ` Kevin Hilman
2011-03-25 15:24 ` Kevin Hilman
2011-03-25 15:30 ` Santosh Shilimkar
2011-03-25 15:30 ` Santosh Shilimkar
2011-03-28 10:47 ` Santosh Shilimkar
2011-03-28 10:47 ` Santosh Shilimkar
2011-03-28 11:02 ` Santosh Shilimkar
2011-03-28 11:02 ` Santosh Shilimkar
2011-03-28 15:56 ` Kevin Hilman
2011-03-28 15:56 ` Kevin Hilman
2011-03-28 16:02 ` Santosh Shilimkar
2011-03-28 16:02 ` Santosh Shilimkar
2011-03-28 16:10 ` Kevin Hilman
2011-03-28 16:10 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4g5a6n5.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.