All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.
Date: Thu, 24 Mar 2011 08:09:53 -0700	[thread overview]
Message-ID: <87mxkk1rni.fsf@ti.com> (raw)
In-Reply-To: <87pqpxbqho.fsf@ti.com> (Kevin Hilman's message of "Fri, 11 Mar 2011 07:56:19 -0800")

Kevin Hilman <khilman@ti.com> writes:

> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>
> [...]
>
>>> >
>>> > This series doesn't boot on ES1 (boot log below.)  Do we need to
>>> > totally prevent WFI on ES1?
>>> >
>> Nope. WFI is ok.
>> The ES1.0 boot issue on pm-core branch doesn't seems to
>> be related to this series. Without this series as well
>> OMAP4 ES1.0 is not booting for me. When I disable
>> CONFIG_PM + WATCHDOG fix, it booted ok. I will
>> git-bisect this later on pm-core branch.
>>
>>> > Also, if we want a CPUidle enabled kernel to boot on all silicon,
>>> > it will need a omap_rev() check during init to ensure it doesn't
>>> > override the default idle path.
>>> >
>> OMAP4 PM series already takes care of not overriding
>> the default idle path for ES1.0. The omap4_mpuss_init()
>> fails on ES1.0 and hence the CPUidle init is skipped in
>> that case.
>>
>> Just to further check, I pulled the latest omap-for-linus
>> branch and merged Paul's pull-request into it. Then
>> applied OMAP4 PM series and I got a boot crash, a different
>> one. This was again related to clock-domain initialization
>> and static deps. I fixed this issue by avoiding omap4_pm_init()
>> code running on ES1.0. With this boot on ES1.0 works fine now
>> with OMAP4 PM series.
>
> Thanks for finding this.  I just tested your v3 branch together with my
> pm-core and it's now booting fine on ES1.
>

Hi Santosh,

Can you rebase and repost your v3 series, I'd like to get this queued
up early in the 2.6.40 dev cycle.

You can base on my current pm-core branch, which also has Russell's 
devel-stable branch merged in.

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support.
Date: Thu, 24 Mar 2011 08:09:53 -0700	[thread overview]
Message-ID: <87mxkk1rni.fsf@ti.com> (raw)
In-Reply-To: <87pqpxbqho.fsf@ti.com> (Kevin Hilman's message of "Fri, 11 Mar 2011 07:56:19 -0800")

Kevin Hilman <khilman@ti.com> writes:

> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>
> [...]
>
>>> >
>>> > This series doesn't boot on ES1 (boot log below.)  Do we need to
>>> > totally prevent WFI on ES1?
>>> >
>> Nope. WFI is ok.
>> The ES1.0 boot issue on pm-core branch doesn't seems to
>> be related to this series. Without this series as well
>> OMAP4 ES1.0 is not booting for me. When I disable
>> CONFIG_PM + WATCHDOG fix, it booted ok. I will
>> git-bisect this later on pm-core branch.
>>
>>> > Also, if we want a CPUidle enabled kernel to boot on all silicon,
>>> > it will need a omap_rev() check during init to ensure it doesn't
>>> > override the default idle path.
>>> >
>> OMAP4 PM series already takes care of not overriding
>> the default idle path for ES1.0. The omap4_mpuss_init()
>> fails on ES1.0 and hence the CPUidle init is skipped in
>> that case.
>>
>> Just to further check, I pulled the latest omap-for-linus
>> branch and merged Paul's pull-request into it. Then
>> applied OMAP4 PM series and I got a boot crash, a different
>> one. This was again related to clock-domain initialization
>> and static deps. I fixed this issue by avoiding omap4_pm_init()
>> code running on ES1.0. With this boot on ES1.0 works fine now
>> with OMAP4 PM series.
>
> Thanks for finding this.  I just tested your v3 branch together with my
> pm-core and it's now booting fine on ES1.
>

Hi Santosh,

Can you rebase and repost your v3 series, I'd like to get this queued
up early in the 2.6.40 dev cycle.

You can base on my current pm-core branch, which also has Russell's 
devel-stable branch merged in.

Thanks,

Kevin

  parent reply	other threads:[~2011-03-24 15:09 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 14:07 [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support Santosh Shilimkar
2011-03-10 14:07 ` Santosh Shilimkar
2011-03-10 14:07 ` [PATCH v2 01/19] OMAP4: PM: Add omap WakeupGen module support Santosh Shilimkar
2011-03-10 14:07   ` Santosh Shilimkar
2011-03-10 14:07 ` [PATCH v2 02/19] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit Santosh Shilimkar
2011-03-10 14:07   ` Santosh Shilimkar
2011-03-10 14:07 ` [PATCH v2 03/19] OMAP4: PM: Export omap4_get_base*() rather than global address pointers Santosh Shilimkar
2011-03-10 14:07   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 04/19] OMAP4: PM: Add SAR RAM support Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 05/19] OMAP4: PM: Add CPUX OFF mode support Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 06/19] OMAP4: PM: Initialise all the clockdomains to supported states Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 07/19] OMAP4: PM: Program CPU1 to hit OFF when off-lined Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 08/19] OMAP4: PM: CPU1 wakeup workaround from Low power modes Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 09/19] OMAP4: PM: Add GIC distributor and interface enable/disable accessory API Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 10/19] OMAP4: PM: Add GIC save/restore support Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 11/19] OMAP4: PM: Add WakeupGen " Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 12/19] OMAP4: PM: Add L2 cache lowpower support Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 13/19] OMAP4: suspend: Add MPUSS RET and OFF support Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 14/19] OMAP4: pm-debug: Add wakeup timer and debug counters Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 15/19] OMAP4: cpuidle: Basic CPUidle support Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 16/19] OMAP4: cpuidle: Add MPUSS RET OFF states Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 17/19] OMAP4: cpuidle: Switch to gptimer from twd in deeper C-states Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 18/19] OMAP4: cpuidle: Add CPU hotplug notifier and prepare() hook Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 14:08 ` [PATCH v2 19/19] OMAP4: Remove un-used do_wfi() macro Santosh Shilimkar
2011-03-10 14:08   ` Santosh Shilimkar
2011-03-10 19:11 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug and CPUilde support Kevin Hilman
2011-03-10 19:11   ` Kevin Hilman
2011-03-11  1:42 ` Kevin Hilman
2011-03-11  1:42   ` Kevin Hilman
2011-03-11  5:52   ` Santosh Shilimkar
2011-03-11  5:52     ` Santosh Shilimkar
2011-03-11 15:52     ` Kevin Hilman
2011-03-11 15:52       ` Kevin Hilman
2011-03-11 17:26       ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 17:26         ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 17:50         ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Kevin Hilman
2011-03-11 17:50           ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Kevin Hilman
2011-03-11 17:58           ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 17:58             ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 18:03             ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Kevin Hilman
2011-03-11 18:03               ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Kevin Hilman
2011-03-11 18:13               ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 18:13                 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 19:53               ` [PATCH v2 00/19] OMAP4: PM: Suspend,CPU-hotplug " Santosh Shilimkar
2011-03-11 19:53                 ` [PATCH v2 00/19] OMAP4: PM: Suspend, CPU-hotplug " Santosh Shilimkar
2011-03-11 12:31   ` Santosh Shilimkar
2011-03-11 12:31     ` Santosh Shilimkar
2011-03-11 15:56     ` Kevin Hilman
2011-03-11 15:56       ` Kevin Hilman
2011-03-11 17:06       ` Santosh Shilimkar
2011-03-11 17:06         ` Santosh Shilimkar
2011-03-24 15:09       ` Kevin Hilman [this message]
2011-03-24 15:09         ` Kevin Hilman
2011-03-25  7:05         ` Santosh Shilimkar
2011-03-25  7:05           ` Santosh Shilimkar
2011-03-25 15:24           ` Kevin Hilman
2011-03-25 15:24             ` Kevin Hilman
2011-03-25 15:30             ` Santosh Shilimkar
2011-03-25 15:30               ` Santosh Shilimkar
2011-03-28 10:47             ` Santosh Shilimkar
2011-03-28 10:47               ` Santosh Shilimkar
2011-03-28 11:02             ` Santosh Shilimkar
2011-03-28 11:02               ` Santosh Shilimkar
2011-03-28 15:56               ` Kevin Hilman
2011-03-28 15:56                 ` Kevin Hilman
2011-03-28 16:02                 ` Santosh Shilimkar
2011-03-28 16:02                   ` Santosh Shilimkar
2011-03-28 16:10                 ` Kevin Hilman
2011-03-28 16:10                   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxkk1rni.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.