All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Peter Collingbourne <pcc@google.com>
Cc: kvm@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Steven Price <steven.price@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Will Deacon <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu,
	Evgenii Stepanov <eugenis@google.com>
Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag
Date: Fri, 22 Jul 2022 15:16:34 +0100	[thread overview]
Message-ID: <87leslxmf1.wl-maz@kernel.org> (raw)
In-Reply-To: <20220722015034.809663-4-pcc@google.com>

On Fri, 22 Jul 2022 02:50:29 +0100,
Peter Collingbourne <pcc@google.com> wrote:
> 
> As with PG_arch_2, this flag is only allowed on 64-bit architectures due
> to the shortage of bits available. It will be used by the arm64 MTE code
> in subsequent patches.
> 
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Steven Price <steven.price@arm.com>
> [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()]
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
>  fs/proc/page.c                 | 1 +
>  include/linux/page-flags.h     | 1 +
>  include/trace/events/mmflags.h | 7 ++++---
>  mm/huge_memory.c               | 1 +
>  4 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index a2873a617ae8..438b8aa7249d 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page)
>  	u |= kpf_copy_bit(k, KPF_ARCH,		PG_arch_1);
>  #ifdef CONFIG_64BIT
>  	u |= kpf_copy_bit(k, KPF_ARCH_2,	PG_arch_2);
> +	u |= kpf_copy_bit(k, KPF_ARCH_2,	PG_arch_3);

Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in
/proc/kpageflags? This seems odd.

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Peter Collingbourne <pcc@google.com>
Cc: linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, Cornelia Huck <cohuck@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Evgenii Stepanov <eugenis@google.com>,
	kvm@vger.kernel.org, Steven Price <steven.price@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>
Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag
Date: Fri, 22 Jul 2022 15:16:34 +0100	[thread overview]
Message-ID: <87leslxmf1.wl-maz@kernel.org> (raw)
In-Reply-To: <20220722015034.809663-4-pcc@google.com>

On Fri, 22 Jul 2022 02:50:29 +0100,
Peter Collingbourne <pcc@google.com> wrote:
> 
> As with PG_arch_2, this flag is only allowed on 64-bit architectures due
> to the shortage of bits available. It will be used by the arm64 MTE code
> in subsequent patches.
> 
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Steven Price <steven.price@arm.com>
> [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()]
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
>  fs/proc/page.c                 | 1 +
>  include/linux/page-flags.h     | 1 +
>  include/trace/events/mmflags.h | 7 ++++---
>  mm/huge_memory.c               | 1 +
>  4 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index a2873a617ae8..438b8aa7249d 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page)
>  	u |= kpf_copy_bit(k, KPF_ARCH,		PG_arch_1);
>  #ifdef CONFIG_64BIT
>  	u |= kpf_copy_bit(k, KPF_ARCH_2,	PG_arch_2);
> +	u |= kpf_copy_bit(k, KPF_ARCH_2,	PG_arch_3);

Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in
/proc/kpageflags? This seems odd.

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Peter Collingbourne <pcc@google.com>
Cc: linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, Cornelia Huck <cohuck@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Evgenii Stepanov <eugenis@google.com>,
	kvm@vger.kernel.org, Steven Price <steven.price@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>
Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag
Date: Fri, 22 Jul 2022 15:16:34 +0100	[thread overview]
Message-ID: <87leslxmf1.wl-maz@kernel.org> (raw)
In-Reply-To: <20220722015034.809663-4-pcc@google.com>

On Fri, 22 Jul 2022 02:50:29 +0100,
Peter Collingbourne <pcc@google.com> wrote:
> 
> As with PG_arch_2, this flag is only allowed on 64-bit architectures due
> to the shortage of bits available. It will be used by the arm64 MTE code
> in subsequent patches.
> 
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Steven Price <steven.price@arm.com>
> [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()]
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
>  fs/proc/page.c                 | 1 +
>  include/linux/page-flags.h     | 1 +
>  include/trace/events/mmflags.h | 7 ++++---
>  mm/huge_memory.c               | 1 +
>  4 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index a2873a617ae8..438b8aa7249d 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page)
>  	u |= kpf_copy_bit(k, KPF_ARCH,		PG_arch_1);
>  #ifdef CONFIG_64BIT
>  	u |= kpf_copy_bit(k, KPF_ARCH_2,	PG_arch_2);
> +	u |= kpf_copy_bit(k, KPF_ARCH_2,	PG_arch_3);

Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in
/proc/kpageflags? This seems odd.

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2022-07-22 14:16 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22  1:50 [PATCH v2 0/7] KVM: arm64: permit MAP_SHARED mappings with MTE enabled Peter Collingbourne
2022-07-22  1:50 ` Peter Collingbourne
2022-07-22  1:50 ` Peter Collingbourne
2022-07-22  1:50 ` [PATCH v2 1/7] arm64: mte: Fix/clarify the PG_mte_tagged semantics Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-23  1:53   ` kernel test robot
2022-07-23  1:53     ` kernel test robot
2022-07-23  1:53     ` kernel test robot
2022-07-24  1:54   ` kernel test robot
2022-07-24  1:54     ` kernel test robot
2022-07-24  1:54     ` kernel test robot
2022-07-22  1:50 ` [PATCH v2 2/7] KVM: arm64: Simplify the sanitise_mte_tags() logic Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50 ` [PATCH v2 3/7] mm: Add PG_arch_3 page flag Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22 14:16   ` Marc Zyngier [this message]
2022-07-22 14:16     ` Marc Zyngier
2022-07-22 14:16     ` Marc Zyngier
2022-07-22 17:04     ` Peter Collingbourne
2022-07-22 17:04       ` Peter Collingbourne
2022-07-22 17:04       ` Peter Collingbourne
2022-07-22  1:50 ` [PATCH v2 4/7] arm64: mte: Lock a page for MTE tag initialisation Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50 ` [PATCH v2 5/7] KVM: arm64: unify the tests for VMAs in memslots when MTE is enabled Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50 ` [PATCH v2 6/7] KVM: arm64: permit all VM_MTE_ALLOWED mappings with MTE enabled Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50 ` [PATCH v2 7/7] Documentation: document the ABI changes for KVM_CAP_ARM_MTE Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne
2022-07-22  1:50   ` Peter Collingbourne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leslxmf1.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cohuck@redhat.com \
    --cc=eugenis@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=pcc@google.com \
    --cc=steven.price@arm.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.