From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_busy: Prevent context ban with right ctx id
Date: Mon, 24 Jan 2022 11:07:07 -0800 [thread overview]
Message-ID: <87lez5osv8.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220124023833.13535-1-chuansheng.liu@intel.com>
On Sun, 23 Jan 2022 18:38:33 -0800, Chuansheng Liu wrote:
>
> When running multiple hang tests, the code is intended to
> disallow context ban at first, but it is always with fix
> ctx id 0. It will cause below test failures when running
> the test gem_busy:
>
> --
> tarting dynamic subtest: vcs0
> (gem_busy:18571) ioctl_wrappers-CRITICAL: Test assertion failure
> function gem_execbuf_wr, file ../lib/ioctl_wrappers.c:706:
> (gem_busy:18571) ioctl_wrappers-CRITICAL: Failed assertion:
> __gem_execbuf_wr(fd, execbuf) == 0
> (gem_busy:18571) ioctl_wrappers-CRITICAL: error: -5 != 0
> --
>
> -5 (EIO) means the context is banned and can not be used for
> execution.
>
> This patch corrects the ctx id accordindly. Furthermore,
> there are other code places with similar mistakes, will
> try to send out the fixes further.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
The SOB I think should be with the top description otherwise SOB is dropped
when we apply the patch. Anyway I've fixed it up and merged it this
time. Thanks for the patch.
prev parent reply other threads:[~2022-01-24 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 2:38 [igt-dev] [PATCH i-g-t] i915/gem_busy: Prevent context ban with right ctx id Chuansheng Liu
2022-01-24 3:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-01-24 4:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-01-24 16:29 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2022-01-25 0:45 ` Liu, Chuansheng
2022-01-24 19:07 ` Dixit, Ashutosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lez5osv8.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.