All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] i915/gem_busy: Prevent context ban with right ctx id
@ 2022-01-24  2:38 Chuansheng Liu
  2022-01-24  3:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Chuansheng Liu @ 2022-01-24  2:38 UTC (permalink / raw)
  To: igt-dev; +Cc: chuansheng.liu

When running multiple hang tests, the code is intended to
disallow context ban at first, but it is always with fix
ctx id 0. It will cause below test failures when running
the test gem_busy:

--
tarting dynamic subtest: vcs0
(gem_busy:18571) ioctl_wrappers-CRITICAL: Test assertion failure
function gem_execbuf_wr, file ../lib/ioctl_wrappers.c:706:
(gem_busy:18571) ioctl_wrappers-CRITICAL: Failed assertion:
__gem_execbuf_wr(fd, execbuf) == 0
(gem_busy:18571) ioctl_wrappers-CRITICAL: error: -5 != 0
--

-5 (EIO) means the context is banned and can not be used for
execution.

This patch corrects the ctx id accordindly. Furthermore,
there are other code places with similar mistakes, will
try to send out the fixes further.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
---
 tests/i915/gem_busy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index b4757736..b8a61084 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -517,7 +517,7 @@ igt_main
 		igt_hang_t hang;
 
 		igt_fixture {
-			hang = igt_allow_hang(fd, 0, 0);
+			hang = igt_allow_hang(fd, ctx->id, 0);
 		}
 
 		test_each_engine("hang", fd, ctx, e) {
-- 
2.25.0.rc2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-01-25  0:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-24  2:38 [igt-dev] [PATCH i-g-t] i915/gem_busy: Prevent context ban with right ctx id Chuansheng Liu
2022-01-24  3:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-01-24  4:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-01-24 16:29 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2022-01-25  0:45   ` Liu, Chuansheng
2022-01-24 19:07 ` Dixit, Ashutosh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.