All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"Shajakhan,
	Mohammed Shafi (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
Subject: Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails
Date: Fri, 10 Feb 2017 09:47:28 +0000	[thread overview]
Message-ID: <87lgteidii.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170206100448.GA13894@atheros-ThinkPad-T61> (Mohammed Shafi Shajakhan's message of "Mon, 6 Feb 2017 15:34:48 +0530")

Mohammed Shafi Shajakhan <mohammed@codeaurora.org> writes:

> the change suggested by you helps, and the device probe, scan
> is successful as well. Still good to have this change part of your
> basic sanity and regression testing !

Sure. I was sort of expecting that you would send v4 but I haven't seen
one so I guess you assumed I send that? :) I'll then submit v4.

BTW, just curious but why do you have "during rmmod" in the title? I
think I was able to reproduce this crash by removing all firmware files
and didn't use rmmod at all.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Cc: "Shajakhan,
	Mohammed Shafi (Mohammed Shafi)" <mohammed@qti.qualcomm.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails
Date: Fri, 10 Feb 2017 09:47:28 +0000	[thread overview]
Message-ID: <87lgteidii.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170206100448.GA13894@atheros-ThinkPad-T61> (Mohammed Shafi Shajakhan's message of "Mon, 6 Feb 2017 15:34:48 +0530")

Mohammed Shafi Shajakhan <mohammed@codeaurora.org> writes:

> the change suggested by you helps, and the device probe, scan
> is successful as well. Still good to have this change part of your
> basic sanity and regression testing !

Sure. I was sort of expecting that you would send v4 but I haven't seen
one so I guess you assumed I send that? :) I'll then submit v4.

BTW, just curious but why do you have "during rmmod" in the title? I
think I was able to reproduce this crash by removing all firmware files
and didn't use rmmod at all.

--=20
Kalle Valo=

  parent reply	other threads:[~2017-02-10  9:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20  8:09 [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails Mohammed Shafi Shajakhan
2016-12-20  8:09 ` Mohammed Shafi Shajakhan
2017-01-25 13:29 ` Valo, Kalle
2017-01-25 13:29   ` Valo, Kalle
2017-01-25 13:46   ` Valo, Kalle
2017-01-25 13:46     ` Valo, Kalle
2017-02-06  6:02     ` Mohammed Shafi Shajakhan
2017-02-06  6:02       ` Mohammed Shafi Shajakhan
2017-02-06 10:04     ` Mohammed Shafi Shajakhan
2017-02-06 10:04       ` Mohammed Shafi Shajakhan
2017-02-06 12:16       ` Michael Ney
2017-02-06 12:16         ` Michael Ney
2017-02-06 12:21         ` Shajakhan, Mohammed Shafi (Mohammed Shafi)
2017-02-06 12:21           ` Shajakhan, Mohammed Shafi (Mohammed Shafi)
2017-02-10  9:47       ` Valo, Kalle [this message]
2017-02-10  9:47         ` Valo, Kalle
2017-02-10 11:36         ` Valo, Kalle
2017-02-10 11:36           ` Valo, Kalle
2017-02-10 12:16         ` Shajakhan, Mohammed Shafi (Mohammed Shafi)
2017-02-10 12:16           ` Shajakhan, Mohammed Shafi (Mohammed Shafi)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgteidii.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mohammed@codeaurora.org \
    --cc=mohammed@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.