From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: setup peer UAPSD flag correctly
Date: Wed, 7 Aug 2013 09:59:28 +0300 [thread overview]
Message-ID: <87li4e6l67.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1375853036-2418-1-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Wed, 7 Aug 2013 07:23:56 +0200")
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Setup UAPSD peer rate control (FW flag)
> correctly.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
This doesn't answer the question "Why?". I have now added a section in
the wiki about what the commit log should contain. Hopefully that helps.
Submitting patches
Send patches to the mailing lists below. Kalle Valo reviews the patches
within the next few days and, if they are ok, commits them to ath.git.
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Preferably use ath.git master as the baseline for patches. Other trees
can be used as well, but then the chances of conflicts are higher.
Guidelines for patches:
* MUST be compiler warning free.
* MUST be sparse warning free.
* Commit log MUST not be empty.
* The commit log MUST answer the question "Why?":
* Describe the motivation behind the bug.
* How does it change the functionality from user's point of view?
* Does it fix a bug? If it does, please describe the bug (doesn't need
to be long). Also if there's a public bug report add a link to the
bug report.
* If others have reported the issue commit log SHOULD use Reported-by:
and Tested-by: tags.
* SHOULD be checkpatch clean:
* FIXME: add checkpatch example with correct arguments
* Patches SHOULD be sent with git send-email tool.
* Patchsets SHOULD contain no more than 12 patches.
The terminology is from http://www.ietf.org/rfc/rfc2119.txt
http://wireless.kernel.org/en/users/Drivers/ath10k#Submitting_patches
Please comment.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: setup peer UAPSD flag correctly
Date: Wed, 7 Aug 2013 09:59:28 +0300 [thread overview]
Message-ID: <87li4e6l67.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1375853036-2418-1-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Wed, 7 Aug 2013 07:23:56 +0200")
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Setup UAPSD peer rate control (FW flag)
> correctly.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
This doesn't answer the question "Why?". I have now added a section in
the wiki about what the commit log should contain. Hopefully that helps.
Submitting patches
Send patches to the mailing lists below. Kalle Valo reviews the patches
within the next few days and, if they are ok, commits them to ath.git.
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Preferably use ath.git master as the baseline for patches. Other trees
can be used as well, but then the chances of conflicts are higher.
Guidelines for patches:
* MUST be compiler warning free.
* MUST be sparse warning free.
* Commit log MUST not be empty.
* The commit log MUST answer the question "Why?":
* Describe the motivation behind the bug.
* How does it change the functionality from user's point of view?
* Does it fix a bug? If it does, please describe the bug (doesn't need
to be long). Also if there's a public bug report add a link to the
bug report.
* If others have reported the issue commit log SHOULD use Reported-by:
and Tested-by: tags.
* SHOULD be checkpatch clean:
* FIXME: add checkpatch example with correct arguments
* Patches SHOULD be sent with git send-email tool.
* Patchsets SHOULD contain no more than 12 patches.
The terminology is from http://www.ietf.org/rfc/rfc2119.txt
http://wireless.kernel.org/en/users/Drivers/ath10k#Submitting_patches
Please comment.
--
Kalle Valo
next prev parent reply other threads:[~2013-08-07 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 5:23 [PATCH] ath10k: setup peer UAPSD flag correctly Janusz Dziedzic
2013-08-07 5:23 ` Janusz Dziedzic
2013-08-07 6:59 ` Kalle Valo [this message]
2013-08-07 6:59 ` Kalle Valo
2013-08-07 7:42 ` Janusz Dziedzic
2013-08-07 7:42 ` Janusz Dziedzic
2013-08-07 8:04 ` Kalle Valo
2013-08-07 8:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li4e6l67.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.