All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: setup peer UAPSD flag correctly
Date: Wed, 7 Aug 2013 11:04:19 +0300	[thread overview]
Message-ID: <87siym53lo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CALhHN=pP32Vw6UMvS93cReWr6WHz3p_3d8mn0FNJtSQGvuGJ9w@mail.gmail.com> (Janusz Dziedzic's message of "Wed, 7 Aug 2013 09:42:22 +0200")

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Setup UAPSD peer/peer rate flags correctly.
> WMI_RC_UAPSD_FLAG is a peer rate capabilities flag
> and should not be set as a peer flag.
>
> BTW this don't fix any known bug yet, just found during UAPSD check.

OK. If a bug has been during a code review and doesn't fix a known
issue, please mention that in the commit log as well.

I added this also to the wiki.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: setup peer UAPSD flag correctly
Date: Wed, 7 Aug 2013 11:04:19 +0300	[thread overview]
Message-ID: <87siym53lo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CALhHN=pP32Vw6UMvS93cReWr6WHz3p_3d8mn0FNJtSQGvuGJ9w@mail.gmail.com> (Janusz Dziedzic's message of "Wed, 7 Aug 2013 09:42:22 +0200")

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Setup UAPSD peer/peer rate flags correctly.
> WMI_RC_UAPSD_FLAG is a peer rate capabilities flag
> and should not be set as a peer flag.
>
> BTW this don't fix any known bug yet, just found during UAPSD check.

OK. If a bug has been during a code review and doesn't fix a known
issue, please mention that in the commit log as well.

I added this also to the wiki.

-- 
Kalle Valo

  reply	other threads:[~2013-08-07  8:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07  5:23 [PATCH] ath10k: setup peer UAPSD flag correctly Janusz Dziedzic
2013-08-07  5:23 ` Janusz Dziedzic
2013-08-07  6:59 ` Kalle Valo
2013-08-07  6:59   ` Kalle Valo
2013-08-07  7:42   ` Janusz Dziedzic
2013-08-07  7:42     ` Janusz Dziedzic
2013-08-07  8:04     ` Kalle Valo [this message]
2013-08-07  8:04       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87siym53lo.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=janusz.dziedzic@tieto.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.