[PATCH] ath10k: setup peer UAPSD flag correctly

[PATCH] ath10k: setup peer UAPSD flag correctly

[Janusz Dziedzic]

Setup UAPSD peer rate control (FW flag)
correctly.

Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
 drivers/net/wireless/ath/ath10k/mac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index cf2ba4d..505be82 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -973,7 +973,7 @@ static void ath10k_peer_assoc_h_qos_ap(struct ath10k *ar,
 			   sta->uapsd_queues, sta->max_sp);
 
 		arg->peer_flags |= WMI_PEER_APSD;
-		arg->peer_flags |= WMI_RC_UAPSD_FLAG;
+		arg->peer_rate_caps |= WMI_RC_UAPSD_FLAG;
 
 		if (sta->uapsd_queues & IEEE80211_WMM_IE_STA_QOSINFO_AC_VO)
 			uapsd |= WMI_AP_PS_UAPSD_AC3_DELIVERY_EN |
-- 
1.7.9.5


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH] ath10k: setup peer UAPSD flag correctly

[Janusz Dziedzic]

Setup UAPSD peer rate control (FW flag)
correctly.

Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
 drivers/net/wireless/ath/ath10k/mac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index cf2ba4d..505be82 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -973,7 +973,7 @@ static void ath10k_peer_assoc_h_qos_ap(struct ath10k *ar,
 			   sta->uapsd_queues, sta->max_sp);
 
 		arg->peer_flags |= WMI_PEER_APSD;
-		arg->peer_flags |= WMI_RC_UAPSD_FLAG;
+		arg->peer_rate_caps |= WMI_RC_UAPSD_FLAG;
 
 		if (sta->uapsd_queues & IEEE80211_WMM_IE_STA_QOSINFO_AC_VO)
 			uapsd |= WMI_AP_PS_UAPSD_AC3_DELIVERY_EN |
-- 
1.7.9.5

Re: [PATCH] ath10k: setup peer UAPSD flag correctly

[Kalle Valo]

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Setup UAPSD peer rate control (FW flag)
> correctly.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>

This doesn't answer the question "Why?". I have now added a section in
the wiki about what the commit log should contain. Hopefully that helps.

Submitting patches

Send patches to the mailing lists below. Kalle Valo reviews the patches
within the next few days and, if they are ok, commits them to ath.git.

To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org

Preferably use ath.git master as the baseline for patches. Other trees
can be used as well, but then the chances of conflicts are higher.

Guidelines for patches:

* MUST be compiler warning free.

* MUST be sparse warning free.

* Commit log MUST not be empty.

* The commit log MUST answer the question "Why?":

  * Describe the motivation behind the bug.

  * How does it change the functionality from user's point of view?

  * Does it fix a bug? If it does, please describe the bug (doesn't need
    to be long). Also if there's a public bug report add a link to the
    bug report.

* If others have reported the issue commit log SHOULD use Reported-by:
  and Tested-by: tags.

* SHOULD be checkpatch clean:

  * FIXME: add checkpatch example with correct arguments

* Patches SHOULD be sent with git send-email tool.

* Patchsets SHOULD contain no more than 12 patches.

The terminology is from http://www.ietf.org/rfc/rfc2119.txt

http://wireless.kernel.org/en/users/Drivers/ath10k#Submitting_patches

Please comment.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: setup peer UAPSD flag correctly

[Kalle Valo]

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Setup UAPSD peer rate control (FW flag)
> correctly.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>

This doesn't answer the question "Why?". I have now added a section in
the wiki about what the commit log should contain. Hopefully that helps.

Submitting patches

Send patches to the mailing lists below. Kalle Valo reviews the patches
within the next few days and, if they are ok, commits them to ath.git.

To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org

Preferably use ath.git master as the baseline for patches. Other trees
can be used as well, but then the chances of conflicts are higher.

Guidelines for patches:

* MUST be compiler warning free.

* MUST be sparse warning free.

* Commit log MUST not be empty.

* The commit log MUST answer the question "Why?":

  * Describe the motivation behind the bug.

  * How does it change the functionality from user's point of view?

  * Does it fix a bug? If it does, please describe the bug (doesn't need
    to be long). Also if there's a public bug report add a link to the
    bug report.

* If others have reported the issue commit log SHOULD use Reported-by:
  and Tested-by: tags.

* SHOULD be checkpatch clean:

  * FIXME: add checkpatch example with correct arguments

* Patches SHOULD be sent with git send-email tool.

* Patchsets SHOULD contain no more than 12 patches.

The terminology is from http://www.ietf.org/rfc/rfc2119.txt

http://wireless.kernel.org/en/users/Drivers/ath10k#Submitting_patches

Please comment.

-- 
Kalle Valo

Re: [PATCH] ath10k: setup peer UAPSD flag correctly

[Janusz Dziedzic]

On 7 August 2013 08:59, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Setup UAPSD peer rate control (FW flag)
>> correctly.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> This doesn't answer the question "Why?". I have now added a section in
> the wiki about what the commit log should contain. Hopefully that helps.
>
> Submitting patches
>
> Send patches to the mailing lists below. Kalle Valo reviews the patches
> within the next few days and, if they are ok, commits them to ath.git.
>
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
>
> Preferably use ath.git master as the baseline for patches. Other trees
> can be used as well, but then the chances of conflicts are higher.
>
> Guidelines for patches:
>
> * MUST be compiler warning free.
>
> * MUST be sparse warning free.
>
> * Commit log MUST not be empty.
>
> * The commit log MUST answer the question "Why?":
>
>   * Describe the motivation behind the bug.
>
>   * How does it change the functionality from user's point of view?
>
>   * Does it fix a bug? If it does, please describe the bug (doesn't need
>     to be long). Also if there's a public bug report add a link to the
>     bug report.
>
> * If others have reported the issue commit log SHOULD use Reported-by:
>   and Tested-by: tags.
>
> * SHOULD be checkpatch clean:
>
>   * FIXME: add checkpatch example with correct arguments
>
> * Patches SHOULD be sent with git send-email tool.
>
> * Patchsets SHOULD contain no more than 12 patches.
>
> The terminology is from http://www.ietf.org/rfc/rfc2119.txt
>
> http://wireless.kernel.org/en/users/Drivers/ath10k#Submitting_patches
>
> Please comment.
>

Setup UAPSD peer/peer rate flags correctly.
WMI_RC_UAPSD_FLAG is a peer rate capabilities flag
and should not be set as a peer flag.

BTW this don't fix any known bug yet, just found during UAPSD check.


BR
Janusz

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: setup peer UAPSD flag correctly

[Janusz Dziedzic]

On 7 August 2013 08:59, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Setup UAPSD peer rate control (FW flag)
>> correctly.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> This doesn't answer the question "Why?". I have now added a section in
> the wiki about what the commit log should contain. Hopefully that helps.
>
> Submitting patches
>
> Send patches to the mailing lists below. Kalle Valo reviews the patches
> within the next few days and, if they are ok, commits them to ath.git.
>
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
>
> Preferably use ath.git master as the baseline for patches. Other trees
> can be used as well, but then the chances of conflicts are higher.
>
> Guidelines for patches:
>
> * MUST be compiler warning free.
>
> * MUST be sparse warning free.
>
> * Commit log MUST not be empty.
>
> * The commit log MUST answer the question "Why?":
>
>   * Describe the motivation behind the bug.
>
>   * How does it change the functionality from user's point of view?
>
>   * Does it fix a bug? If it does, please describe the bug (doesn't need
>     to be long). Also if there's a public bug report add a link to the
>     bug report.
>
> * If others have reported the issue commit log SHOULD use Reported-by:
>   and Tested-by: tags.
>
> * SHOULD be checkpatch clean:
>
>   * FIXME: add checkpatch example with correct arguments
>
> * Patches SHOULD be sent with git send-email tool.
>
> * Patchsets SHOULD contain no more than 12 patches.
>
> The terminology is from http://www.ietf.org/rfc/rfc2119.txt
>
> http://wireless.kernel.org/en/users/Drivers/ath10k#Submitting_patches
>
> Please comment.
>

Setup UAPSD peer/peer rate flags correctly.
WMI_RC_UAPSD_FLAG is a peer rate capabilities flag
and should not be set as a peer flag.

BTW this don't fix any known bug yet, just found during UAPSD check.


BR
Janusz

Re: [PATCH] ath10k: setup peer UAPSD flag correctly

[Kalle Valo]

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Setup UAPSD peer/peer rate flags correctly.
> WMI_RC_UAPSD_FLAG is a peer rate capabilities flag
> and should not be set as a peer flag.
>
> BTW this don't fix any known bug yet, just found during UAPSD check.

OK. If a bug has been during a code review and doesn't fix a known
issue, please mention that in the commit log as well.

I added this also to the wiki.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: setup peer UAPSD flag correctly

[Kalle Valo]

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Setup UAPSD peer/peer rate flags correctly.
> WMI_RC_UAPSD_FLAG is a peer rate capabilities flag
> and should not be set as a peer flag.
>
> BTW this don't fix any known bug yet, just found during UAPSD check.

OK. If a bug has been during a code review and doesn't fix a known
issue, please mention that in the commit log as well.

I added this also to the wiki.

-- 
Kalle Valo