From: Kevin Hilman <khilman@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>, Charulatha V <charu@ti.com>
Subject: Re: [PATCH v8 16/24] gpio/omap: use pm-runtime framework
Date: Fri, 04 Nov 2011 10:13:29 -0700 [thread overview]
Message-ID: <87lirvbykm.fsf@ti.com> (raw)
In-Reply-To: <1317803593-12259-17-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 5 Oct 2011 14:03:05 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync()
> for enabling/disabling clocks appropriately. Remove syscore_ops and
> instead use SET_RUNTIME_PM_OPS macro.
>
> Signed-off-by: Charulatha V <charu@ti.com>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mach-omap2/gpio.c | 2 -
> drivers/gpio/gpio-omap.c | 67 +++++++++++++++++++++++++++++---------------
> 2 files changed, 44 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c
> index 5ae1cf3..a992802 100644
> --- a/arch/arm/mach-omap2/gpio.c
> +++ b/arch/arm/mach-omap2/gpio.c
> @@ -146,8 +146,6 @@ static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
> return PTR_ERR(od);
> }
>
> - omap_device_disable_idle_on_suspend(od);
> -
No description in the changelog about this change. (Yes, I understand
why it's removed, but it needs to be described in the changelog so when
I forget, I'll have a way to remember.)
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 16/24] gpio/omap: use pm-runtime framework
Date: Fri, 04 Nov 2011 10:13:29 -0700 [thread overview]
Message-ID: <87lirvbykm.fsf@ti.com> (raw)
In-Reply-To: <1317803593-12259-17-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 5 Oct 2011 14:03:05 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync()
> for enabling/disabling clocks appropriately. Remove syscore_ops and
> instead use SET_RUNTIME_PM_OPS macro.
>
> Signed-off-by: Charulatha V <charu@ti.com>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mach-omap2/gpio.c | 2 -
> drivers/gpio/gpio-omap.c | 67 +++++++++++++++++++++++++++++---------------
> 2 files changed, 44 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c
> index 5ae1cf3..a992802 100644
> --- a/arch/arm/mach-omap2/gpio.c
> +++ b/arch/arm/mach-omap2/gpio.c
> @@ -146,8 +146,6 @@ static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
> return PTR_ERR(od);
> }
>
> - omap_device_disable_idle_on_suspend(od);
> -
No description in the changelog about this change. (Yes, I understand
why it's removed, but it needs to be described in the changelog so when
I forget, I'll have a way to remember.)
Kevin
next prev parent reply other threads:[~2011-11-04 17:13 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 8:32 [PATCH v8 00/24] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 01/24] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 02/24] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 03/24] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 04/24] gpio/omap: handle save/restore context in GPIO driver Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 05/24] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 06/24] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 07/24] gpio/omap: further cleanup using wkup_en register Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 08/24] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 09/24] gpio/omap: remove hardcoded offsets in context save/restore Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:32 ` [PATCH v8 10/24] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma
2011-10-05 8:32 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 11/24] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 12/24] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 13/24] gpio/omap: remove unnecessary bit-masking for read access Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 14/24] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 15/24] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 16/24] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-11-04 17:13 ` Kevin Hilman [this message]
2011-11-04 17:13 ` Kevin Hilman
2011-11-07 10:09 ` DebBarma, Tarun Kanti
2011-11-07 10:09 ` DebBarma, Tarun Kanti
2011-10-05 8:33 ` [PATCH v8 17/24] gpio/omap: fix debounce clock handling Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 18/24] gpio/omap: optimize suspend and resume functions Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 19/24] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 20/24] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 21/24] gpio/omap: save and restore debounce registers Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 22/24] gpio/omap: enable irq at the end of all configuration in restore Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 23/24] gpio/omap: restore OE only after setting the output level Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-10-05 8:33 ` [PATCH v8 24/24] gpio/omap: handle set_dataout reg capable IP on restore Tarun Kanti DebBarma
2011-10-05 8:33 ` Tarun Kanti DebBarma
2011-11-04 16:53 ` Kevin Hilman
2011-11-04 16:53 ` Kevin Hilman
2011-11-07 12:05 ` DebBarma, Tarun Kanti
2011-11-07 12:05 ` DebBarma, Tarun Kanti
2011-11-23 12:31 ` DebBarma, Tarun Kanti
2011-11-23 12:31 ` DebBarma, Tarun Kanti
2011-11-23 19:54 ` Kevin Hilman
2011-11-23 19:54 ` Kevin Hilman
2011-11-24 5:31 ` DebBarma, Tarun Kanti
2011-11-24 5:31 ` DebBarma, Tarun Kanti
2011-11-03 21:44 ` [PATCH v8 00/24] gpio/omap: driver cleanup and fixes Kevin Hilman
2011-11-03 21:44 ` Kevin Hilman
2011-11-04 9:27 ` DebBarma, Tarun Kanti
2011-11-04 9:27 ` DebBarma, Tarun Kanti
2011-11-25 10:30 ` DebBarma, Tarun Kanti
2011-11-25 10:30 ` DebBarma, Tarun Kanti
2011-11-29 15:15 ` Kevin Hilman
2011-11-29 15:15 ` Kevin Hilman
2011-11-30 14:39 ` T Krishnamoorthy, Balaji
2011-11-30 14:39 ` T Krishnamoorthy, Balaji
2011-11-28 8:23 ` DebBarma, Tarun Kanti
2011-11-28 8:23 ` DebBarma, Tarun Kanti
2011-11-29 15:17 ` Kevin Hilman
2011-11-29 15:17 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lirvbykm.fsf@ti.com \
--to=khilman@ti.com \
--cc=charu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.