* CxlCorErrorType member @retry-threshold is undocumented
@ 2024-08-08 17:51 Markus Armbruster
2024-08-09 10:04 ` Jonathan Cameron via
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2024-08-08 17:51 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: qemu-devel
Hi Jonathan,
You added the type in commit 415442a1b4a (hw/mem/cxl_type3: Add CXL RAS
Error Injection Support.) The doc comment is missing a description of
@retry-threshold. Can you supply me one? I'm happy to do the actual
patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: CxlCorErrorType member @retry-threshold is undocumented
2024-08-08 17:51 CxlCorErrorType member @retry-threshold is undocumented Markus Armbruster
@ 2024-08-09 10:04 ` Jonathan Cameron via
2024-08-09 10:11 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron via @ 2024-08-09 10:04 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Thu, 08 Aug 2024 19:51:26 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Hi Jonathan,
>
> You added the type in commit 415442a1b4a (hw/mem/cxl_type3: Add CXL RAS
> Error Injection Support.) The doc comment is missing a description of
> @retry-threshold. Can you supply me one? I'm happy to do the actual
> patch.
>
Sorry!
The CXL spec text is
Retry Threshold Hit. (NUM_RETRY >= MAX_NUM_RETRY). Applicable only to 68B Flit Mode.
+ a reference to the local retry state machine (LRSM)
So maybe
"Retry threshold hit in the Local Retry State Machine, 68B Flits only."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: CxlCorErrorType member @retry-threshold is undocumented
2024-08-09 10:04 ` Jonathan Cameron via
@ 2024-08-09 10:11 ` Markus Armbruster
0 siblings, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2024-08-09 10:11 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Markus Armbruster, qemu-devel
Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:
> On Thu, 08 Aug 2024 19:51:26 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Hi Jonathan,
>>
>> You added the type in commit 415442a1b4a (hw/mem/cxl_type3: Add CXL RAS
>> Error Injection Support.) The doc comment is missing a description of
>> @retry-threshold. Can you supply me one? I'm happy to do the actual
>> patch.
>>
> Sorry!
>
> The CXL spec text is
>
> Retry Threshold Hit. (NUM_RETRY >= MAX_NUM_RETRY). Applicable only to 68B Flit Mode.
> + a reference to the local retry state machine (LRSM)
>
> So maybe
>
> "Retry threshold hit in the Local Retry State Machine, 68B Flits only."
Is "Local Retry State Machine" a name or a description? The former may
be capitalized, the latter not.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-09 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-08 17:51 CxlCorErrorType member @retry-threshold is undocumented Markus Armbruster
2024-08-09 10:04 ` Jonathan Cameron via
2024-08-09 10:11 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.