From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
Date: Mon, 12 Nov 2018 11:13:44 +0000 [thread overview]
Message-ID: <87muqeeefr.fsf@linaro.org> (raw)
In-Reply-To: <20181110121711.15257-1-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> This would cause an infinite recursion or loop.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
I feel the title undersells the importance of the fix ;-)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
Date: Mon, 12 Nov 2018 11:13:44 +0000 [thread overview]
Message-ID: <87muqeeefr.fsf@linaro.org> (raw)
In-Reply-To: <20181110121711.15257-1-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> This would cause an infinite recursion or loop.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
I feel the title undersells the importance of the fix ;-)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
--
Alex Bennée
next prev parent reply other threads:[~2018-11-12 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 12:17 [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write Richard Henderson
2018-11-10 12:17 ` [Qemu-devel] " Richard Henderson
2018-11-10 19:20 ` [Qemu-arm] " Philippe Mathieu-Daudé
2018-11-10 19:20 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-11-12 11:13 ` Alex Bennée [this message]
2018-11-12 11:13 ` Alex Bennée
2018-11-12 11:27 ` Peter Maydell
2018-11-12 11:27 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muqeeefr.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.