* [Qemu-devel] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
@ 2018-11-10 12:17 ` Richard Henderson
0 siblings, 0 replies; 8+ messages in thread
From: Richard Henderson @ 2018-11-10 12:17 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, qemu-arm
This would cause an infinite recursion or loop.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 96301930cc..a327988c66 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
CPUState *cs = ENV_GET_CPU(env);
if (tlb_force_broadcast(env)) {
- tlbi_aa64_vmalle1_write(env, NULL, value);
+ tlbi_aa64_vmalle1is_write(env, NULL, value);
return;
}
--
2.17.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
2018-11-10 12:17 ` [Qemu-devel] " Richard Henderson
@ 2018-11-10 19:20 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-10 19:20 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: peter.maydell, qemu-arm
On 11/10/18 1:17 PM, Richard Henderson wrote:
> This would cause an infinite recursion or loop.
Hehe :)
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
@ 2018-11-10 19:20 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-10 19:20 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: peter.maydell, qemu-arm
On 11/10/18 1:17 PM, Richard Henderson wrote:
> This would cause an infinite recursion or loop.
Hehe :)
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
2018-11-10 12:17 ` [Qemu-devel] " Richard Henderson
@ 2018-11-12 11:13 ` Alex Bennée
-1 siblings, 0 replies; 8+ messages in thread
From: Alex Bennée @ 2018-11-12 11:13 UTC (permalink / raw)
To: qemu-arm; +Cc: qemu-devel, peter.maydell
Richard Henderson <richard.henderson@linaro.org> writes:
> This would cause an infinite recursion or loop.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
I feel the title undersells the importance of the fix ;-)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
@ 2018-11-12 11:13 ` Alex Bennée
0 siblings, 0 replies; 8+ messages in thread
From: Alex Bennée @ 2018-11-12 11:13 UTC (permalink / raw)
To: qemu-arm; +Cc: qemu-devel, peter.maydell
Richard Henderson <richard.henderson@linaro.org> writes:
> This would cause an infinite recursion or loop.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
I feel the title undersells the importance of the fix ;-)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
2018-11-10 12:17 ` [Qemu-devel] " Richard Henderson
@ 2018-11-12 11:27 ` Peter Maydell
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2018-11-12 11:27 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-arm, QEMU Developers
On 10 November 2018 at 12:17, Richard Henderson
<richard.henderson@linaro.org> wrote:
> This would cause an infinite recursion or loop.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write
@ 2018-11-12 11:27 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2018-11-12 11:27 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Developers, qemu-arm
On 10 November 2018 at 12:17, Richard Henderson
<richard.henderson@linaro.org> wrote:
> This would cause an infinite recursion or loop.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 96301930cc..a327988c66 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri,
> CPUState *cs = ENV_GET_CPU(env);
>
> if (tlb_force_broadcast(env)) {
> - tlbi_aa64_vmalle1_write(env, NULL, value);
> + tlbi_aa64_vmalle1is_write(env, NULL, value);
> return;
> }
>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread