From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
rtc-linux@googlegroups.com, Haim Boot <hayim@marvell.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: [rtc-linux] Re: [PATCH v2 0/3] Extend rtc-armada38x support for Armada 7K/8K
Date: Mon, 20 Feb 2017 18:36:33 +0100 [thread overview]
Message-ID: <87mvdgahni.fsf@free-electrons.com> (raw)
In-Reply-To: <20170220172739.GN21222@n2100.armlinux.org.uk> (Russell King's message of "Mon, 20 Feb 2017 17:27:39 +0000")
Hi Russell King,
=20
On lun., f=C3=A9vr. 20 2017, Russell King - ARM Linux <linux@armlinux.org.=
uk> wrote:
> On Mon, Feb 20, 2017 at 06:06:11PM +0100, Gregory CLEMENT wrote:
>> I saw on IRC than Russell managed to have a more coherent date with this
>> series on his 8040 based board. For the record, as the U-Boot on this
>> board didn't provide a "date reset" command for the RTC located on CP
>> slave, then Russell needed to do the following:
>>=20
>> devmem2 0xf428401c w 0
>> devmem2 0xf4284018 w 0x2000
>> followed by:
>> date 021612342017; ntpdate ...; hwclock -uw
>>=20
>> But this issue was related to the bootloader not to the kernel. The
>> other potential issue seen by Russell was about the GIC mapping for the
>> interrupt, but here again this mapping was done by the 1st stage
>> bootloader.
>>=20
>> Given this information would it be OK to applied this series?
>
> No it is not. As I already pointed out, the interrupt for the 8040 is
> GIC_SPI 71 _not_ GIC_SPI 77 as you have it in this series.
>
> Both CP110's on Armada 8040 have a default mapping of ICU 77 to GIC
> 71.
OK so I am sending a v2 with this fix.
Thanks,
Gregory
>
> --=20
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
--=20
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] Extend rtc-armada38x support for Armada 7K/8K
Date: Mon, 20 Feb 2017 18:36:33 +0100 [thread overview]
Message-ID: <87mvdgahni.fsf@free-electrons.com> (raw)
In-Reply-To: <20170220172739.GN21222@n2100.armlinux.org.uk> (Russell King's message of "Mon, 20 Feb 2017 17:27:39 +0000")
Hi Russell King,
On lun., f?vr. 20 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> On Mon, Feb 20, 2017 at 06:06:11PM +0100, Gregory CLEMENT wrote:
>> I saw on IRC than Russell managed to have a more coherent date with this
>> series on his 8040 based board. For the record, as the U-Boot on this
>> board didn't provide a "date reset" command for the RTC located on CP
>> slave, then Russell needed to do the following:
>>
>> devmem2 0xf428401c w 0
>> devmem2 0xf4284018 w 0x2000
>> followed by:
>> date 021612342017; ntpdate ...; hwclock -uw
>>
>> But this issue was related to the bootloader not to the kernel. The
>> other potential issue seen by Russell was about the GIC mapping for the
>> interrupt, but here again this mapping was done by the 1st stage
>> bootloader.
>>
>> Given this information would it be OK to applied this series?
>
> No it is not. As I already pointed out, the interrupt for the 8040 is
> GIC_SPI 71 _not_ GIC_SPI 77 as you have it in this series.
>
> Both CP110's on Armada 8040 have a default mapping of ICU 77 to GIC
> 71.
OK so I am sending a v2 with this fix.
Thanks,
Gregory
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-02-20 17:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 10:19 [rtc-linux] [PATCH v2 0/3] Extend rtc-armada38x support for Armada 7K/8K Gregory CLEMENT
2017-02-17 10:19 ` Gregory CLEMENT
2017-02-17 10:19 ` [rtc-linux] [PATCH v2 1/3] rtc: armada38x: Prepare driver to manage different versions Gregory CLEMENT
2017-02-17 10:19 ` Gregory CLEMENT
2017-02-17 10:19 ` [rtc-linux] [PATCH v2 2/3] rtc: armada38x: Add support for Armada 7K/8K Gregory CLEMENT
2017-02-17 10:19 ` Gregory CLEMENT
2017-02-17 10:19 ` [rtc-linux] [PATCH v2 3/3] arm64: dts: marvell: add RTC description " Gregory CLEMENT
2017-02-17 10:19 ` Gregory CLEMENT
2017-02-20 17:06 ` [rtc-linux] Re: [PATCH v2 0/3] Extend rtc-armada38x support " Gregory CLEMENT
2017-02-20 17:06 ` Gregory CLEMENT
2017-02-20 17:27 ` [rtc-linux] " Russell King - ARM Linux
2017-02-20 17:27 ` Russell King - ARM Linux
2017-02-20 17:36 ` Gregory CLEMENT [this message]
2017-02-20 17:36 ` Gregory CLEMENT
2017-02-20 17:42 ` [rtc-linux] " Russell King - ARM Linux
2017-02-20 17:42 ` Russell King - ARM Linux
2017-02-20 17:36 ` [rtc-linux] " Alexandre Belloni
2017-02-20 17:36 ` Alexandre Belloni
2017-02-20 17:43 ` [rtc-linux] " Gregory CLEMENT
2017-02-20 17:43 ` Gregory CLEMENT
2017-02-20 17:50 ` [rtc-linux] " Russell King - ARM Linux
2017-02-20 17:50 ` Russell King - ARM Linux
2017-02-20 18:17 ` [rtc-linux] " Alexandre Belloni
2017-02-20 18:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvdgahni.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=hayim@marvell.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=rtc-linux@googlegroups.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.