From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"David Airlie" <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Adrien Vergé" <adrienverge@gmail.com>
Subject: Re: [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
Date: Tue, 13 Sep 2016 12:34:08 +0300 [thread overview]
Message-ID: <87mvjcta7j.fsf@intel.com> (raw)
In-Reply-To: <1473602239-15855-1-git-send-email-adrienverge@gmail.com>
On Sun, 11 Sep 2016, Adrien Vergé <adrienverge@gmail.com> wrote:
> On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166),
> the screen is tiled in many 480×320 screens (like a mosaic) since v4.7.
> This laptop is simply unusable.
>
> I have bisected the cause to commit a05628195a0d ("drm/i915: Get
> panel_type from OpRegion panel details").
>
> Like for Skylake, it seems that using the OpRegion panel type (here, 0)
> causes the problem, whereas the VBT panel type (here, 7) gives a normal
> display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from
> OpRegion on SKL") for background on this Skylake fix.
>
> This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips.
Please try this patch [1] instead, and reply to it if it works for you.
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com
>
> Tested-by: Adrien Vergé <adrienverge@gmail.com>
> Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index adca262..94e2db7 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
> return -ENODEV;
> }
>
> + /*
> + * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the
> + * OpRegion panel type (0) results in tiled ("mosaic") display bug,
> + * whereas the VBT panel type (7) gives a normal display.
> + * Let's ignore the OpRegion panel type for this chip.
> + */
> + if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
> + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> + return -ENODEV;
> + }
> +
> return ret - 1;
> }
--
Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Adrien Vergé" <adrienverge@gmail.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"David Airlie" <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Adrien Vergé" <adrienverge@gmail.com>
Subject: Re: [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
Date: Tue, 13 Sep 2016 12:34:08 +0300 [thread overview]
Message-ID: <87mvjcta7j.fsf@intel.com> (raw)
In-Reply-To: <1473602239-15855-1-git-send-email-adrienverge@gmail.com>
On Sun, 11 Sep 2016, Adrien Vergé <adrienverge@gmail.com> wrote:
> On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166),
> the screen is tiled in many 480×320 screens (like a mosaic) since v4.7.
> This laptop is simply unusable.
>
> I have bisected the cause to commit a05628195a0d ("drm/i915: Get
> panel_type from OpRegion panel details").
>
> Like for Skylake, it seems that using the OpRegion panel type (here, 0)
> causes the problem, whereas the VBT panel type (here, 7) gives a normal
> display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from
> OpRegion on SKL") for background on this Skylake fix.
>
> This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips.
Please try this patch [1] instead, and reply to it if it works for you.
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com
>
> Tested-by: Adrien Vergé <adrienverge@gmail.com>
> Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index adca262..94e2db7 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
> return -ENODEV;
> }
>
> + /*
> + * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the
> + * OpRegion panel type (0) results in tiled ("mosaic") display bug,
> + * whereas the VBT panel type (7) gives a normal display.
> + * Let's ignore the OpRegion panel type for this chip.
> + */
> + if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
> + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> + return -ENODEV;
> + }
> +
> return ret - 1;
> }
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2016-09-13 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 13:57 [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile Adrien Vergé
2016-09-12 9:54 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-09-13 9:34 ` Jani Nikula [this message]
2016-09-13 9:34 ` [PATCH] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvjcta7j.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=adrienverge@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.