From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi
Date: Sat, 22 Nov 2014 00:13:27 +0100 [thread overview]
Message-ID: <87mw7kb10o.fsf@natisbad.org> (raw)
In-Reply-To: <20141121201844.GD20238@lunn.ch> (Andrew Lunn's message of "Fri, 21 Nov 2014 21:18:44 +0100")
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
>> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
>> index 2be9723bcdf3..8e65abf46fba 100644
>> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
>> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
>> @@ -103,6 +103,10 @@
>> #size-cells = <1>;
>> ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
>>
>> + pinctrl: pin-ctrl at 18000 {
>> + reg = <0x18000 0x38>;
>> + };
>> +
>> rtc at 10300 {
>> compatible = "marvell,orion-rtc";
>> reg = <0x10300 0x20>;
>
> We try to keep entries in these files in numeric address order.
> So this should go after serial at 12100
I should have remembered that. I had this comment a long time ago on an
unrelated series.
a+
WARNING: multiple messages have this Message-ID (diff)
From: arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org (Arnaud Ebalard)
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv5 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi
Date: Sat, 22 Nov 2014 00:13:27 +0100 [thread overview]
Message-ID: <87mw7kb10o.fsf@natisbad.org> (raw)
In-Reply-To: <20141121201844.GD20238-g2DYL2Zd6BY@public.gmane.org> (Andrew Lunn's message of "Fri, 21 Nov 2014 21:18:44 +0100")
Hi Andrew,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> writes:
>> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
>> index 2be9723bcdf3..8e65abf46fba 100644
>> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
>> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
>> @@ -103,6 +103,10 @@
>> #size-cells = <1>;
>> ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
>>
>> + pinctrl: pin-ctrl@18000 {
>> + reg = <0x18000 0x38>;
>> + };
>> +
>> rtc@10300 {
>> compatible = "marvell,orion-rtc";
>> reg = <0x10300 0x20>;
>
> We try to keep entries in these files in numeric address order.
> So this should go after serial@12100
I should have remembered that. I had this comment a long time ago on an
unrelated series.
a+
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-21 23:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 19:45 [PATCHv5 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:44 ` [PATCHv5 01/10] arm: mvebu: fix vendor prefix typo in kirkwood-synology.dtsi Arnaud Ebalard
2014-11-21 19:44 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 02/10] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 03/10] arm: mvebu: use recently introduced uart label for stdout-path Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 20:18 ` Andrew Lunn
2014-11-21 20:18 ` Andrew Lunn
2014-11-21 23:13 ` Arnaud Ebalard [this message]
2014-11-21 23:13 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 05/10] arm: mvebu: define and use common Armada 370 SPI pinctrl settings Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 20:22 ` Andrew Lunn
2014-11-21 20:22 ` Andrew Lunn
2014-11-21 19:45 ` [PATCHv5 06/10] arm: mvebu: define and use common Armada 370 UART " Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 20:26 ` Andrew Lunn
2014-11-21 20:26 ` Andrew Lunn
2014-11-21 19:45 ` [PATCHv5 07/10] arm: mvebu: define and use common Armada XP UART2/3 " Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:46 ` [PATCHv5 08/10] arm: mvebu: define and use common Armada XP SPI pinctrl setting Arnaud Ebalard
2014-11-21 19:46 ` Arnaud Ebalard
2014-11-21 20:28 ` Andrew Lunn
2014-11-21 20:28 ` Andrew Lunn
2014-11-21 19:46 ` [PATCHv5 09/10] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-21 19:46 ` Arnaud Ebalard
2014-11-21 20:34 ` Andrew Lunn
2014-11-21 20:34 ` Andrew Lunn
2014-11-21 19:46 ` [PATCHv5 10/10] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard
2014-11-21 19:46 ` Arnaud Ebalard
2014-11-21 20:38 ` [PATCHv5 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Andrew Lunn
2014-11-21 20:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw7kb10o.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.