From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 05/10] arm: mvebu: define and use common Armada 370 SPI pinctrl settings
Date: Fri, 21 Nov 2014 21:22:53 +0100 [thread overview]
Message-ID: <20141121202253.GE20238@lunn.ch> (raw)
In-Reply-To: <a0eb580b7cc0f7cf39f1a69f0cc5747bded66300.1416598537.git.arno@natisbad.org>
Hi Arnaud
> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> index 90e1286d414f..f1284ae0cddd 100644
> --- a/arch/arm/boot/dts/armada-370.dtsi
> +++ b/arch/arm/boot/dts/armada-370.dtsi
> @@ -197,6 +197,20 @@
> status = "disabled";
> };
>
> + /*
> + * Default SPI pinctrl setting, can be overwritten on
> + * board level if a different configuration is used.
> + */
> + spi0: spi at 10600 {
> + pinctrl-0 = <&spi0_pins1>;
> + pinctrl-names = "default";
> + };
> +
> + spi1: spi at 10680 {
> + pinctrl-0 = <&spi1_pins>;
> + pinctrl-names = "default";
> + };
> +
Again, ordering. It looks like these should be between l2-cache and i2c0.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv5 05/10] arm: mvebu: define and use common Armada 370 SPI pinctrl settings
Date: Fri, 21 Nov 2014 21:22:53 +0100 [thread overview]
Message-ID: <20141121202253.GE20238@lunn.ch> (raw)
In-Reply-To: <a0eb580b7cc0f7cf39f1a69f0cc5747bded66300.1416598537.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Hi Arnaud
> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> index 90e1286d414f..f1284ae0cddd 100644
> --- a/arch/arm/boot/dts/armada-370.dtsi
> +++ b/arch/arm/boot/dts/armada-370.dtsi
> @@ -197,6 +197,20 @@
> status = "disabled";
> };
>
> + /*
> + * Default SPI pinctrl setting, can be overwritten on
> + * board level if a different configuration is used.
> + */
> + spi0: spi@10600 {
> + pinctrl-0 = <&spi0_pins1>;
> + pinctrl-names = "default";
> + };
> +
> + spi1: spi@10680 {
> + pinctrl-0 = <&spi1_pins>;
> + pinctrl-names = "default";
> + };
> +
Again, ordering. It looks like these should be between l2-cache and i2c0.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-21 20:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 19:45 [PATCHv5 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:44 ` [PATCHv5 01/10] arm: mvebu: fix vendor prefix typo in kirkwood-synology.dtsi Arnaud Ebalard
2014-11-21 19:44 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 02/10] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 03/10] arm: mvebu: use recently introduced uart label for stdout-path Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 20:18 ` Andrew Lunn
2014-11-21 20:18 ` Andrew Lunn
2014-11-21 23:13 ` Arnaud Ebalard
2014-11-21 23:13 ` Arnaud Ebalard
2014-11-21 19:45 ` [PATCHv5 05/10] arm: mvebu: define and use common Armada 370 SPI pinctrl settings Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 20:22 ` Andrew Lunn [this message]
2014-11-21 20:22 ` Andrew Lunn
2014-11-21 19:45 ` [PATCHv5 06/10] arm: mvebu: define and use common Armada 370 UART " Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 20:26 ` Andrew Lunn
2014-11-21 20:26 ` Andrew Lunn
2014-11-21 19:45 ` [PATCHv5 07/10] arm: mvebu: define and use common Armada XP UART2/3 " Arnaud Ebalard
2014-11-21 19:45 ` Arnaud Ebalard
2014-11-21 19:46 ` [PATCHv5 08/10] arm: mvebu: define and use common Armada XP SPI pinctrl setting Arnaud Ebalard
2014-11-21 19:46 ` Arnaud Ebalard
2014-11-21 20:28 ` Andrew Lunn
2014-11-21 20:28 ` Andrew Lunn
2014-11-21 19:46 ` [PATCHv5 09/10] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-21 19:46 ` Arnaud Ebalard
2014-11-21 20:34 ` Andrew Lunn
2014-11-21 20:34 ` Andrew Lunn
2014-11-21 19:46 ` [PATCHv5 10/10] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard
2014-11-21 19:46 ` Arnaud Ebalard
2014-11-21 20:38 ` [PATCHv5 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Andrew Lunn
2014-11-21 20:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121202253.GE20238@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.