All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: gregkh@linuxfoundation.org, tony@atomide.com,
	rmk+kernel@arm.linux.org.uk, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Felipe Balbi <balbi@ti.com>, Rajendra nayak <rnayak@ti.com>
Subject: Re: [PATCHv3] driver: serial: prevent UART console idle on suspend while using "no_console_suspend"
Date: Fri, 05 Apr 2013 10:40:29 -0700	[thread overview]
Message-ID: <87mwtclvua.fsf@linaro.org> (raw)
In-Reply-To: <1365167733-28083-1-git-send-email-sourav.poddar@ti.com> (Sourav Poddar's message of "Fri, 5 Apr 2013 18:45:33 +0530")

Sourav Poddar <sourav.poddar@ti.com> writes:

> With dt boot, uart wakeup after suspend is non functional while using
> "no_console_suspend" in the bootargs. With "no_console_suspend" used, we
> should prevent the runtime suspend of the uart port which is getting used
> as an console.
>
> Cc: Santosh Shilimkar<santosh.shilimkar@ti.com>
> Cc: Felipe Balbi<balbi@ti.com>
> Cc: Rajendra nayak<rnayak@ti.com>
> Tested on omap5430evm, omap4430sdp.
>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>

Rather than make these special checks inside the driver's runtime PM
callbacks, you should just disable runtime PM (pm_runtime_disable())

Then, this should be broken into 2 patches.

1) serial core: add the '->is_console' flag.  (nit on naming: don't call
   it port_is_console, since the struct is already a uart_port)

2) In the OMAP UART driver's ->prepare callback, check the is_console flag
   and pm_runtime_disable() accordingly  (then pm_runtime_enable() in
   the drivers's ->complete callback.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: <gregkh@linuxfoundation.org>, <tony@atomide.com>,
	<rmk+kernel@arm.linux.org.uk>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Felipe Balbi <balbi@ti.com>, Rajendra nayak <rnayak@ti.com>
Subject: Re: [PATCHv3] driver: serial: prevent UART console idle on suspend while using "no_console_suspend"
Date: Fri, 05 Apr 2013 10:40:29 -0700	[thread overview]
Message-ID: <87mwtclvua.fsf@linaro.org> (raw)
In-Reply-To: <1365167733-28083-1-git-send-email-sourav.poddar@ti.com> (Sourav Poddar's message of "Fri, 5 Apr 2013 18:45:33 +0530")

Sourav Poddar <sourav.poddar@ti.com> writes:

> With dt boot, uart wakeup after suspend is non functional while using
> "no_console_suspend" in the bootargs. With "no_console_suspend" used, we
> should prevent the runtime suspend of the uart port which is getting used
> as an console.
>
> Cc: Santosh Shilimkar<santosh.shilimkar@ti.com>
> Cc: Felipe Balbi<balbi@ti.com>
> Cc: Rajendra nayak<rnayak@ti.com>
> Tested on omap5430evm, omap4430sdp.
>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>

Rather than make these special checks inside the driver's runtime PM
callbacks, you should just disable runtime PM (pm_runtime_disable())

Then, this should be broken into 2 patches.

1) serial core: add the '->is_console' flag.  (nit on naming: don't call
   it port_is_console, since the struct is already a uart_port)

2) In the OMAP UART driver's ->prepare callback, check the is_console flag
   and pm_runtime_disable() accordingly  (then pm_runtime_enable() in
   the drivers's ->complete callback.

Kevin

  reply	other threads:[~2013-04-05 17:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 13:15 [PATCHv3] driver: serial: prevent UART console idle on suspend while using "no_console_suspend" Sourav Poddar
2013-04-05 13:15 ` Sourav Poddar
2013-04-05 17:40 ` Kevin Hilman [this message]
2013-04-05 17:40   ` Kevin Hilman
2013-04-09 18:54   ` Sourav Poddar
2013-04-09 18:54     ` Sourav Poddar
2013-04-09 19:07     ` Kevin Hilman
2013-04-09 19:07       ` Kevin Hilman
2013-04-10  6:07       ` Sourav Poddar
2013-04-10  6:07         ` Sourav Poddar
2013-04-10  6:19         ` Bedia, Vaibhav
2013-04-10  9:43           ` Sourav Poddar
2013-04-10 11:26             ` Bedia, Vaibhav
2013-04-10 21:26               ` Kevin Hilman
2013-04-10 21:26                 ` Kevin Hilman
2013-04-11 14:15                 ` Kevin Hilman
2013-04-11 14:15                   ` Kevin Hilman
2013-04-15 11:50                   ` Bedia, Vaibhav
2013-04-15 21:33                     ` Kevin Hilman
2013-04-15 21:33                       ` Kevin Hilman
2013-04-15 11:55                   ` Sourav Poddar
2013-04-08 17:14 ` Russell King - ARM Linux
2013-04-10  5:27   ` Sourav Poddar
2013-04-10  5:27     ` Sourav Poddar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwtclvua.fsf@linaro.org \
    --to=khilman@linaro.org \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=sourav.poddar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.