From: Rusty Russell <rusty@rustcorp.com.au>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: Christian Dietrich
<christian.dietrich@informatik.uni-erlangen.de>,
"Venkatesh Pallipadi \(Venki\)" <venki@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Fengzhe Zhang <fengzhe.zhang@intel.com>,
John Stultz <johnstul@us.ibm.com>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
lguest@lists.ozlabs.org, trivial@kernel.org
Subject: Re: [PATCH 8/8] arch/x86: use printk_ratelimited instead of printk_ratelimit
Date: Tue, 07 Jun 2011 12:41:02 +0930 [thread overview]
Message-ID: <87mxhugwu1.fsf@rustcorp.com.au> (raw)
In-Reply-To: <BANLkTinS67qH-pm2=Z9G1UXk4OOuZNsN9g@mail.gmail.com>
On Mon, 6 Jun 2011 10:11:53 +0200, richard -rw- weinberger <richard.weinberger@gmail.com> wrote:
> On Mon, Jun 6, 2011 at 8:35 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > On Sat, 4 Jun 2011 17:37:04 +0200, Christian Dietrich <christian.dietrich@informatik.uni-erlangen.de> wrote:
> >> Since printk_ratelimit() shouldn't be used anymore (see comment in
> >> include/linux/printk.h), replace it with printk_ratelimited.
> >
> > Acked-by: Rusty Russell <rusty@rustcorp.com.au> (lguest part)
> >
> >> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> >> index db832fd..23a6eff 100644
> >> --- a/arch/x86/lguest/boot.c
> >> +++ b/arch/x86/lguest/boot.c
> >> @@ -56,6 +56,7 @@
> >> #include <linux/lguest_launcher.h>
> >> #include <linux/virtio_console.h>
> >> #include <linux/pm.h>
> >> +#include <linux/ratelimit.h>
> >> #include <asm/apic.h>
> >> #include <asm/lguest.h>
> >> #include <asm/paravirt.h>
> >
> > Is this new include really needed? The printk_ratelimited() definition
> > is in printk.h...
>
> Yes.
> printk_ratelimited() needs DEFINE_RATELIMIT_STATE() which is defined
> in ratelimit.h.
Yech. I'm assuming that making printk.h include ratelimit.h makes a
nasty mess?
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: richard -rw- weinberger
<richard.weinberger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: lguest-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
"Venkatesh Pallipadi \(Venki\)"
<venki-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Kevin Tian <kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Marcelo Tosatti
<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lucas De Marchi
<lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org>,
John Stultz <johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Fengzhe Zhang
<fengzhe.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Christian Dietrich
<christian.dietrich-jNDFPZUTrfT6U6xlzOR6HsSSVFg4/55HhC4ANOJQIlc@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: Re: [PATCH 8/8] arch/x86: use printk_ratelimited instead of printk_ratelimit
Date: Tue, 07 Jun 2011 12:41:02 +0930 [thread overview]
Message-ID: <87mxhugwu1.fsf@rustcorp.com.au> (raw)
In-Reply-To: <BANLkTinS67qH-pm2=Z9G1UXk4OOuZNsN9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, 6 Jun 2011 10:11:53 +0200, richard -rw- weinberger <richard.weinberger@gmail.com> wrote:
> On Mon, Jun 6, 2011 at 8:35 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > On Sat, 4 Jun 2011 17:37:04 +0200, Christian Dietrich <christian.dietrich@informatik.uni-erlangen.de> wrote:
> >> Since printk_ratelimit() shouldn't be used anymore (see comment in
> >> include/linux/printk.h), replace it with printk_ratelimited.
> >
> > Acked-by: Rusty Russell <rusty@rustcorp.com.au> (lguest part)
> >
> >> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> >> index db832fd..23a6eff 100644
> >> --- a/arch/x86/lguest/boot.c
> >> +++ b/arch/x86/lguest/boot.c
> >> @@ -56,6 +56,7 @@
> >> #include <linux/lguest_launcher.h>
> >> #include <linux/virtio_console.h>
> >> #include <linux/pm.h>
> >> +#include <linux/ratelimit.h>
> >> #include <asm/apic.h>
> >> #include <asm/lguest.h>
> >> #include <asm/paravirt.h>
> >
> > Is this new include really needed? The printk_ratelimited() definition
> > is in printk.h...
>
> Yes.
> printk_ratelimited() needs DEFINE_RATELIMIT_STATE() which is defined
> in ratelimit.h.
Yech. I'm assuming that making printk.h include ratelimit.h makes a
nasty mess?
Thanks,
Rusty.
_______________________________________________
Lguest mailing list
Lguest@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/lguest
next prev parent reply other threads:[~2011-06-07 3:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 15:35 [PATCH 0/8] Use printk_ratelimited instead of printk_ratelimit Christian Dietrich
2011-06-04 15:35 ` [PATCH 1/8] powerpc/rtas-rtc: remove sideeffects " Christian Dietrich
2011-06-04 15:35 ` [PATCH 2/8] drivers/octeon: use printk_ratelimited instead " Christian Dietrich
2011-06-04 15:36 ` [PATCH 3/8] scsi/sg: " Christian Dietrich
2011-06-04 15:36 ` [PATCH 4/8] md/raid: " Christian Dietrich
2011-06-28 6:45 ` NeilBrown
2011-06-04 15:36 ` [PATCH 5/8] drivers/char/rtc: " Christian Dietrich
2011-06-04 15:36 ` [PATCH 6/8] drivers/gpu/drm: " Christian Dietrich
2011-06-04 15:36 ` [PATCH 7/8] arch/powerpc: " Christian Dietrich
2011-06-04 15:37 ` [PATCH 8/8] arch/x86: " Christian Dietrich
2011-06-04 15:37 ` Christian Dietrich
2011-06-06 6:35 ` Rusty Russell
2011-06-06 6:35 ` Rusty Russell
2011-06-06 8:11 ` richard -rw- weinberger
2011-06-07 3:11 ` Rusty Russell [this message]
2011-06-07 3:11 ` Rusty Russell
2011-06-07 3:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxhugwu1.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=avi@redhat.com \
--cc=christian.dietrich@informatik.uni-erlangen.de \
--cc=fengzhe.zhang@intel.com \
--cc=hpa@zytor.com \
--cc=johnstul@us.ibm.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lguest@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=richard.weinberger@gmail.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=venki@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.