* Re: [PATCH] target/s390x: Prefer MO_128 definition over magic value
2026-04-15 22:03 [PATCH] target/s390x: Prefer MO_128 definition over magic value Philippe Mathieu-Daudé
@ 2026-04-15 22:06 ` Pierrick Bouvier
2026-04-16 0:19 ` Richard Henderson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Pierrick Bouvier @ 2026-04-15 22:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Ilya Leoshkevich, Eric Farman, David Hildenbrand, qemu-s390x,
Richard Henderson, Matthew Rosato, Cornelia Huck
On 4/15/2026 3:03 PM, Philippe Mathieu-Daudé wrote:
> The MO_128 definition was not existing when commit 6d841663be8
> ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the
> ES_128 definition. It was added 2 years later in commit 4b473e0c60d
> ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available,
> replace the magic '4' by the more explicit 'MO_128'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/s390x/tcg/translate_vx.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] target/s390x: Prefer MO_128 definition over magic value
2026-04-15 22:03 [PATCH] target/s390x: Prefer MO_128 definition over magic value Philippe Mathieu-Daudé
2026-04-15 22:06 ` Pierrick Bouvier
@ 2026-04-16 0:19 ` Richard Henderson
2026-04-16 2:22 ` Matthew Rosato
2026-04-17 15:16 ` Cornelia Huck
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2026-04-16 0:19 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Ilya Leoshkevich, Eric Farman, David Hildenbrand, qemu-s390x,
Matthew Rosato, Cornelia Huck
On 4/16/26 08:03, Philippe Mathieu-Daudé wrote:
> The MO_128 definition was not existing when commit 6d841663be8
> ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the
> ES_128 definition. It was added 2 years later in commit 4b473e0c60d
> ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available,
> replace the magic '4' by the more explicit 'MO_128'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/s390x/tcg/translate_vx.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/tcg/translate_vx.c.inc b/target/s390x/tcg/translate_vx.c.inc
> index b53e9e52639..447641df25c 100644
> --- a/target/s390x/tcg/translate_vx.c.inc
> +++ b/target/s390x/tcg/translate_vx.c.inc
> @@ -50,7 +50,7 @@
> #define ES_16 MO_16
> #define ES_32 MO_32
> #define ES_64 MO_64
> -#define ES_128 4
> +#define ES_128 MO_128
>
> /* Floating-Point Format */
> #define FPF_SHORT 2
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] target/s390x: Prefer MO_128 definition over magic value
2026-04-15 22:03 [PATCH] target/s390x: Prefer MO_128 definition over magic value Philippe Mathieu-Daudé
2026-04-15 22:06 ` Pierrick Bouvier
2026-04-16 0:19 ` Richard Henderson
@ 2026-04-16 2:22 ` Matthew Rosato
2026-04-17 15:16 ` Cornelia Huck
3 siblings, 0 replies; 5+ messages in thread
From: Matthew Rosato @ 2026-04-16 2:22 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Ilya Leoshkevich, Eric Farman, David Hildenbrand, qemu-s390x,
Richard Henderson, Cornelia Huck
On 4/15/26 6:03 PM, Philippe Mathieu-Daudé wrote:
> The MO_128 definition was not existing when commit 6d841663be8
> ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the
> ES_128 definition. It was added 2 years later in commit 4b473e0c60d
> ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available,
> replace the magic '4' by the more explicit 'MO_128'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] target/s390x: Prefer MO_128 definition over magic value
2026-04-15 22:03 [PATCH] target/s390x: Prefer MO_128 definition over magic value Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2026-04-16 2:22 ` Matthew Rosato
@ 2026-04-17 15:16 ` Cornelia Huck
3 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2026-04-17 15:16 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Ilya Leoshkevich, Eric Farman, David Hildenbrand, qemu-s390x,
Richard Henderson, Matthew Rosato, Philippe Mathieu-Daudé
On Thu, Apr 16 2026, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> The MO_128 definition was not existing when commit 6d841663be8
> ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the
> ES_128 definition. It was added 2 years later in commit 4b473e0c60d
> ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available,
> replace the magic '4' by the more explicit 'MO_128'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/s390x/tcg/translate_vx.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, queued to s390-next.
^ permalink raw reply [flat|nested] 5+ messages in thread