From: Kalle Valo <kvalo@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org
Subject: Re: [PATCH 07/13] wcn36xx: Flag WIPHY_WOWLAN_MAGIC_PKT
Date: Mon, 11 Jan 2021 13:38:14 +0200 [thread overview]
Message-ID: <87o8hvk8k9.fsf@codeaurora.org> (raw)
In-Reply-To: <20201228162839.369156-8-bryan.odonoghue@linaro.org> (Bryan O'Donoghue's message of "Mon, 28 Dec 2020 16:28:33 +0000")
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:
> Set a flag to indicate magic packet wakeup support on wcn36xx.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c
> b/drivers/net/wireless/ath/wcn36xx/main.c
> index 579bb7f4db9c..cfa2e2d20a20 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -173,7 +173,7 @@ static struct ieee80211_supported_band wcn_band_5ghz = {
> #ifdef CONFIG_PM
>
> static const struct wiphy_wowlan_support wowlan_support = {
> - .flags = WIPHY_WOWLAN_ANY
> + .flags = WIPHY_WOWLAN_ANY | WIPHY_WOWLAN_MAGIC_PKT
> };
Shouldn't this be the last patch so that we don't enable the feature
until it's fully implemented? This makes a difference when doing a
bisect, for example.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-01-11 11:39 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 16:28 [PATCH 00/13] wcn36xx: Enable downstream consistent Wake on Lan Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 01/13] wcn36xx: Return result of set_power_params in suspend Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 02/13] wcn36xx: Run suspend for the first ieee80211_vif Bryan O'Donoghue
2020-12-28 20:48 ` kernel test robot
2020-12-28 20:48 ` kernel test robot
2020-12-28 16:28 ` [PATCH 03/13] wcn36xx: Add ipv4 ARP offload support in suspend Bryan O'Donoghue
2021-01-11 11:18 ` Kalle Valo
2020-12-28 16:28 ` [PATCH 04/13] wcn36xx: Do not flush indication queue on suspend/resume Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 05/13] wcn36xx: Add ipv6 address tracking Bryan O'Donoghue
2020-12-28 22:44 ` kernel test robot
2020-12-28 22:44 ` kernel test robot
2020-12-28 16:28 ` [PATCH 06/13] wcn36xx: Add ipv6 namespace offload in suspend Bryan O'Donoghue
2020-12-28 21:49 ` kernel test robot
2020-12-28 21:49 ` kernel test robot
2020-12-29 2:15 ` Bryan O'Donoghue
2020-12-29 2:15 ` Bryan O'Donoghue
2021-01-11 11:27 ` Kalle Valo
2021-01-11 11:27 ` Kalle Valo
2021-01-12 10:51 ` Chen, Rong A
2021-01-12 10:51 ` [kbuild-all] " Chen, Rong A
2021-01-12 11:18 ` Kalle Valo
2021-01-12 11:18 ` [kbuild-all] " Kalle Valo
2021-01-13 1:57 ` Rong Chen
2021-01-13 1:57 ` [kbuild-all] " Rong Chen
2021-01-13 7:11 ` Kalle Valo
2021-01-13 7:11 ` [kbuild-all] " Kalle Valo
2020-12-28 16:28 ` [PATCH 07/13] wcn36xx: Flag WIPHY_WOWLAN_MAGIC_PKT Bryan O'Donoghue
2021-01-11 11:38 ` Kalle Valo [this message]
2021-01-11 11:49 ` Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 08/13] wcn36xx: Add set_rekey_data callback Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 09/13] wcn36xx: Add GTK offload to WoWLAN path Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 10/13] wcn36xx: Add GTK offload info to WoWLAN resume Bryan O'Donoghue
2021-01-11 11:28 ` Kalle Valo
2021-01-11 11:47 ` Bryan O'Donoghue
2021-01-11 11:39 ` Kalle Valo
2020-12-28 16:28 ` [PATCH 11/13] wcn36xx: Do not suspend if scan in progress Bryan O'Donoghue
2020-12-28 21:47 ` Benjamin Li
2021-01-11 11:31 ` Kalle Valo
2021-01-11 11:46 ` Bryan O'Donoghue
2021-01-11 12:26 ` Kalle Valo
2021-01-11 12:40 ` Bryan O'Donoghue
2021-01-11 11:34 ` Kalle Valo
2020-12-28 16:28 ` [PATCH 12/13] wcn36xx: Add Host suspend indication support Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 13/13] wcn36xx: Add host resume request support Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8hvk8k9.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.