Re: [PATCH 05/13] wcn36xx: Add ipv6 address tracking

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3231 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.11-rc1 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20201229-003134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a7d3b150ccc65a022e531e7648080be9fedb1318
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20201229-003134
        git checkout a7d3b150ccc65a022e531e7648080be9fedb1318
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/ath/wcn36xx/main.c:1092:23: warning: no previous prototype for 'wcn36xx_get_first_vif' [-Wmissing-prototypes]
    1092 | struct ieee80211_vif *wcn36xx_get_first_vif(struct wcn36xx *wcn)
         |                       ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/wcn36xx/main.c:1220:6: warning: no previous prototype for 'wcn36xx_ipv6_addr_change' [-Wmissing-prototypes]
    1220 | void wcn36xx_ipv6_addr_change(struct ieee80211_hw *hw,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/wcn36xx_ipv6_addr_change +1220 drivers/net/wireless/ath/wcn36xx/main.c

  1218	
  1219	#if IS_ENABLED(CONFIG_IPV6)
> 1220	void wcn36xx_ipv6_addr_change(struct ieee80211_hw *hw,
  1221				      struct ieee80211_vif *vif,
  1222				      struct inet6_dev *idev)
  1223	{
  1224		struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
  1225		struct inet6_ifaddr *ifa;
  1226		int idx = 0;
  1227	
  1228		memset(vif_priv->tentative_addrs, 0, sizeof(vif_priv->tentative_addrs));
  1229	
  1230		read_lock_bh(&idev->lock);
  1231		list_for_each_entry(ifa, &idev->addr_list, if_list) {
  1232			vif_priv->target_ipv6_addrs[idx] = ifa->addr;
  1233			if (ifa->flags & IFA_F_TENTATIVE)
  1234				__set_bit(idx, vif_priv->tentative_addrs);
  1235			idx++;
  1236			if (idx >= WCN36XX_HAL_IPV6_OFFLOAD_ADDR_MAX)
  1237				break;
  1238			wcn36xx_dbg(WCN36XX_DBG_MAC, "%pI6 %s\n", &ifa->addr,
  1239				    (ifa->flags & IFA_F_TENTATIVE) ? "tentative" : NULL);
  1240		}
  1241		read_unlock_bh(&idev->lock);
  1242	
  1243		vif_priv->num_target_ipv6_addrs = idx;
  1244	}
  1245	#endif
  1246	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66525 bytes --]