All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	kvalo@codeaurora.org, wcn36xx@lists.infradead.org,
	linux-wireless@vger.kernel.org
Cc: kbuild-all@lists.01.org, bryan.odonoghue@linaro.org,
	shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org
Subject: Re: [PATCH 02/13] wcn36xx: Run suspend for the first ieee80211_vif
Date: Tue, 29 Dec 2020 04:48:37 +0800	[thread overview]
Message-ID: <202012290450.6iuHKMFT-lkp@intel.com> (raw)
In-Reply-To: <20201228162839.369156-3-bryan.odonoghue@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 2323 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.11-rc1 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20201229-003134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/76ccb1ff883813f6950d31c6c82c47a180682c4c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20201229-003134
        git checkout 76ccb1ff883813f6950d31c6c82c47a180682c4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/ath/wcn36xx/main.c:1091:23: warning: no previous prototype for 'wcn36xx_get_first_vif' [-Wmissing-prototypes]
    1091 | struct ieee80211_vif *wcn36xx_get_first_vif(struct wcn36xx *wcn)
         |                       ^~~~~~~~~~~~~~~~~~~~~


vim +/wcn36xx_get_first_vif +1091 drivers/net/wireless/ath/wcn36xx/main.c

  1090	
> 1091	struct ieee80211_vif *wcn36xx_get_first_vif(struct wcn36xx *wcn)
  1092	{
  1093		struct wcn36xx_vif *tmp;
  1094		struct ieee80211_vif *vif = NULL;
  1095	
  1096		list_for_each_entry(tmp, &wcn->vif_list, list) {
  1097			vif = wcn36xx_priv_to_vif(tmp);
  1098			if (vif)
  1099				break;
  1100		}
  1101		return vif;
  1102	}
  1103	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66525 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 02/13] wcn36xx: Run suspend for the first ieee80211_vif
Date: Tue, 29 Dec 2020 04:48:37 +0800	[thread overview]
Message-ID: <202012290450.6iuHKMFT-lkp@intel.com> (raw)
In-Reply-To: <20201228162839.369156-3-bryan.odonoghue@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 2379 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.11-rc1 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20201229-003134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/76ccb1ff883813f6950d31c6c82c47a180682c4c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20201229-003134
        git checkout 76ccb1ff883813f6950d31c6c82c47a180682c4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/ath/wcn36xx/main.c:1091:23: warning: no previous prototype for 'wcn36xx_get_first_vif' [-Wmissing-prototypes]
    1091 | struct ieee80211_vif *wcn36xx_get_first_vif(struct wcn36xx *wcn)
         |                       ^~~~~~~~~~~~~~~~~~~~~


vim +/wcn36xx_get_first_vif +1091 drivers/net/wireless/ath/wcn36xx/main.c

  1090	
> 1091	struct ieee80211_vif *wcn36xx_get_first_vif(struct wcn36xx *wcn)
  1092	{
  1093		struct wcn36xx_vif *tmp;
  1094		struct ieee80211_vif *vif = NULL;
  1095	
  1096		list_for_each_entry(tmp, &wcn->vif_list, list) {
  1097			vif = wcn36xx_priv_to_vif(tmp);
  1098			if (vif)
  1099				break;
  1100		}
  1101		return vif;
  1102	}
  1103	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66525 bytes --]

  reply	other threads:[~2020-12-28 23:16 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 16:28 [PATCH 00/13] wcn36xx: Enable downstream consistent Wake on Lan Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 01/13] wcn36xx: Return result of set_power_params in suspend Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 02/13] wcn36xx: Run suspend for the first ieee80211_vif Bryan O'Donoghue
2020-12-28 20:48   ` kernel test robot [this message]
2020-12-28 20:48     ` kernel test robot
2020-12-28 16:28 ` [PATCH 03/13] wcn36xx: Add ipv4 ARP offload support in suspend Bryan O'Donoghue
2021-01-11 11:18   ` Kalle Valo
2020-12-28 16:28 ` [PATCH 04/13] wcn36xx: Do not flush indication queue on suspend/resume Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 05/13] wcn36xx: Add ipv6 address tracking Bryan O'Donoghue
2020-12-28 22:44   ` kernel test robot
2020-12-28 22:44     ` kernel test robot
2020-12-28 16:28 ` [PATCH 06/13] wcn36xx: Add ipv6 namespace offload in suspend Bryan O'Donoghue
2020-12-28 21:49   ` kernel test robot
2020-12-28 21:49     ` kernel test robot
2020-12-29  2:15     ` Bryan O'Donoghue
2020-12-29  2:15       ` Bryan O'Donoghue
2021-01-11 11:27       ` Kalle Valo
2021-01-11 11:27         ` Kalle Valo
2021-01-12 10:51         ` Chen, Rong A
2021-01-12 10:51           ` [kbuild-all] " Chen, Rong A
2021-01-12 11:18           ` Kalle Valo
2021-01-12 11:18             ` [kbuild-all] " Kalle Valo
2021-01-13  1:57             ` Rong Chen
2021-01-13  1:57               ` [kbuild-all] " Rong Chen
2021-01-13  7:11               ` Kalle Valo
2021-01-13  7:11                 ` [kbuild-all] " Kalle Valo
2020-12-28 16:28 ` [PATCH 07/13] wcn36xx: Flag WIPHY_WOWLAN_MAGIC_PKT Bryan O'Donoghue
2021-01-11 11:38   ` Kalle Valo
2021-01-11 11:49     ` Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 08/13] wcn36xx: Add set_rekey_data callback Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 09/13] wcn36xx: Add GTK offload to WoWLAN path Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 10/13] wcn36xx: Add GTK offload info to WoWLAN resume Bryan O'Donoghue
2021-01-11 11:28   ` Kalle Valo
2021-01-11 11:47     ` Bryan O'Donoghue
2021-01-11 11:39   ` Kalle Valo
2020-12-28 16:28 ` [PATCH 11/13] wcn36xx: Do not suspend if scan in progress Bryan O'Donoghue
2020-12-28 21:47   ` Benjamin Li
2021-01-11 11:31   ` Kalle Valo
2021-01-11 11:46     ` Bryan O'Donoghue
2021-01-11 12:26       ` Kalle Valo
2021-01-11 12:40         ` Bryan O'Donoghue
2021-01-11 11:34   ` Kalle Valo
2020-12-28 16:28 ` [PATCH 12/13] wcn36xx: Add Host suspend indication support Bryan O'Donoghue
2020-12-28 16:28 ` [PATCH 13/13] wcn36xx: Add host resume request support Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202012290450.6iuHKMFT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=benl@squareup.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=shawn.guo@linaro.org \
    --cc=wcn36xx@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.